minor code beauty/performance enhancements

git-svn-id: http://svn.klever.net/kin/fireflix/trunk@170 fe716a7a-6dde-0310-88d9-d003556173a8

1 files changed, 8 insertions, 6 deletions

diff --git a/content/fireflix.js b/content/fireflix.js
index 98b6d41..337354e 100644
--- a/content/fireflix.js
+++ b/content/fireflix.js
@@ -89,16 +89,17 @@ var fireflix = {
  },
 
  /* photoset treeview */
  photoset: {
   photos: new Array(),
   fireflix: null,
   init: function(f) {
    this.fireflix = f;
+   pull_elements(this,document,[ 'set_photo' ]);
   },
   rowCount: 0,
   getCellText: function(r,c) {
    var p = this.photos[r];
    if(c.id=='sp_title') return p.title;
    if(c.id=='sp_taken') return p.datetaken;
    if(c.id=='sp_upload') return p.dateupload; /* TODO: unixtime conversion */
    return c.id;
@@ -143,21 +144,21 @@ var fireflix = {
     }, function(x,s,c,m) {
      _this.fireflix.flickr_failure(x,s,c,m);
     }
    );
   },
   on_select: function() {
    if(this.selection.count==1) {
     var p = this.photos[this.selection.currentIndex];
-    document.getElementById('set_photo').src =
+    this.set_photo.src =
      this.fireflix.flickr.get_photo_url(p.server,p.id,p.secret,'t');
-    document.getElementById('set_photo').hidden = false;
+    this.set_photo.hidden = false;
    }else{
-    document.getElementById('set_photo').hidden = true;
+    this.set_photo.hidden = true;
    }
   }
  },
 
  /* photosets treeview */
  photosets: {
   sets: new Array(),
   fireflix: null,
@@ -305,17 +306,18 @@ var fireflix = {
  },
 
  uploads: {
   fireflix: null,
   init: function(f) {
    this.fireflix=f;
    pull_elements(this,document,[
     'upload_filename','upload_title','upload_file_preview',
-    'upload_file_props','upload_progress','upload_tags'
+    'upload_file_props','upload_progress','upload_tags',
+    'cmd_uploads_upload'
    ]);
   },
   files: new Array(),
   rowCount: 0,
   getCellText: function(r,c) {
    var f = this.files[r];
    if(c.id=='up_file') return f.file;
    if(c.id=='up_title') return f.title;
@@ -396,17 +398,17 @@ var fireflix = {
      return;
     }
    }
    dump('uploading done\n');
    this.on_finish_upload();
   },
   upload_to: function(_this) { _this.upload_worker(); },
   on_file_upload: function(f) {
-   document.getElementById('cmd_uploads_upload').setAttribute('disabled','true');
+   this.cmd_uploads_upload.setAttribute('disabled','true');
    for(var fi in this.files) {
     if(this.files[fi].file==f.file) {
      this.tree.ensureRowIsVisible(fi);
      this.selection.rangedSelect(fi,fi,false);
      this.selection.currentIndex = fi;
      this.selToProps();
      break;
     }
@@ -443,17 +445,17 @@ var fireflix = {
        );
       }, function(x,s,c,m) {
        _this.fireflix.flickr_failure(x,s,c,m);
       }
      );
     }
    }
    this.selection.clearSelection();
-   document.getElementById('cmd_uploads_upload').setAttribute('disabled','false');
+   this.cmd_uploads_upload.setAttribute('disabled','false');
    this.upload_progress.setAttribute('hidden','true');
   },
 
   clear_list: function() {
    this.tree.beginUpdateBatch();
    this.rowCount = 0;
    this.files = new Array();
    this.tree.endUpdateBatch();