summaryrefslogtreecommitdiffabout
authorMichael Krelin <hacker@klever.net>2012-01-20 21:36:42 (UTC)
committer Michael Krelin <hacker@klever.net>2012-01-20 21:36:42 (UTC)
commit2c469d2d891899dbb51a6125fec3980dac6a7ec0 (patch) (side-by-side diff)
tree24be6fb4c6334d106c1ce642195c5a7244bc7f97
parent8f8bdd258276b1a53100393d6e7557f078898e71 (diff)
downloadiii-2c469d2d891899dbb51a6125fec3980dac6a7ec0.zip
iii-2c469d2d891899dbb51a6125fec3980dac6a7ec0.tar.gz
iii-2c469d2d891899dbb51a6125fec3980dac6a7ec0.tar.bz2
report exceptions caught while processing requests
Signed-off-by: Michael Krelin <hacker@klever.net>
Diffstat (more/less context) (show whitespace changes)
-rw-r--r--src/eyefiservice.cc23
1 files changed, 13 insertions, 10 deletions
diff --git a/src/eyefiservice.cc b/src/eyefiservice.cc
index e89b2fc..276977a 100644
--- a/src/eyefiservice.cc
+++ b/src/eyefiservice.cc
@@ -27,12 +27,18 @@ static bool detached_child() {
i = dup(i); assert(i==2);
return true;
}
return false;
}
+static int E(eyefiService* efs,const char *c,const std::exception& e) {
+ efs->keep_alive=0;
+ syslog(LOG_ERR,"error while processing %s: %s",c,e.what());
+ return efs->soap_receiverfault(gnu::autosprintf("error processing %s",c),0);
+}
+
int eyefiService::StartSession(
std::string macaddress,std::string cnonce,
int transfermode,long transfermodetimestamp,
struct rns__StartSessionResponse &r ) try {
#ifndef NDEBUG
syslog(LOG_DEBUG,
@@ -57,22 +63,19 @@ int eyefiService::StartSession(
execv("/bin/sh",argv);
syslog(LOG_ERR,"Failed to execute '%s'",cmd.c_str());
_exit(-1);
}
}
return SOAP_OK;
-}catch(std::runtime_error& e) {
- syslog(LOG_ERR,"error while processing StartSession: %s",e.what());
- return soap_receiverfault(e.what(),0);
-}
+}catch(const std::exception& e) { return E(this,"StartSession",e); }
int eyefiService::GetPhotoStatus(
std::string credential, std::string macaddress,
std::string filename, long filesize, std::string filesignature,
int flags,
- struct rns__GetPhotoStatusResponse &r ) {
+ struct rns__GetPhotoStatusResponse &r ) try {
#ifndef NDEBUG
syslog(LOG_DEBUG,
"GetPhotoStatus request from %s with credential=%s, filename=%s, filesize=%ld, filesignature=%s, flags=%d; session nonce=%s",
macaddress.c_str(), credential.c_str(), filename.c_str(), filesize, filesignature.c_str(), flags,
session_nonce.hex().c_str() );
#endif
@@ -84,17 +87,17 @@ int eyefiService::GetPhotoStatus(
#endif
if (credential != computed_credential) throw std::runtime_error("card authentication failed");
r.fileid = 1; r.offset = 0;
return SOAP_OK;
-}
+}catch(const std::exception& e) { return E(this,"GetPhotoStatus",e); }
int eyefiService::MarkLastPhotoInRoll(
std::string macaddress, int mergedelta,
- struct rns__MarkLastPhotoInRollResponse&/* r */ ) {
+ struct rns__MarkLastPhotoInRollResponse&/* r */ ) try {
#ifndef NDEBUG
syslog(LOG_DEBUG,
"MarkLastPhotoInRoll request from %s with mergedelta=%d",
macaddress.c_str(), mergedelta );
#endif
std::string cmd = eyekinfig_t(macaddress).get_on_mark_last_photo_in_roll();
@@ -107,19 +110,19 @@ int eyefiService::MarkLastPhotoInRoll(
syslog(LOG_ERR,"Failed to execute '%s'",cmd.c_str());
_exit(-1);
}
}
keep_alive = 0;
return SOAP_OK;
-}
+}catch(const std::exception& e) { return E(this,"MarkLastPhotoInRoll",e); }
int eyefiService::UploadPhoto(
int fileid, std::string macaddress,
std::string filename, long filesize, std::string filesignature,
std::string encryption, int flags,
- struct rns__UploadPhotoResponse& r ) {
+ struct rns__UploadPhotoResponse& r ) try {
#ifndef NDEBUG
syslog(LOG_DEBUG,
"UploadPhoto request from %s with fileid=%d, filename=%s, filesize=%ld,"
" filesignature=%s, encryption=%s, flags=%04X",
macaddress.c_str(), fileid, filename.c_str(), filesize,
filesignature.c_str(), encryption.c_str(), flags );
@@ -223,7 +226,7 @@ int eyefiService::UploadPhoto(
_exit(-1);
}
}
r.success = true;
return SOAP_OK;
-}
+}catch(const std::exception& e) { return E(this,"UploadPhoto",e); }