From 16c80883ba6c8657bc6129fb9e2695eaf3d3c09b Mon Sep 17 00:00:00 2001 From: Michael Krelin Date: Sun, 20 Mar 2011 02:19:04 +0000 Subject: don't double-fork Signed-off-by: Michael Krelin --- diff --git a/src/eyefiservice.cc b/src/eyefiservice.cc index 0bf26c4..4ca2777 100644 --- a/src/eyefiservice.cc +++ b/src/eyefiservice.cc @@ -14,27 +14,18 @@ static binary_t session_nonce; static bool detached_child() { pid_t p = fork(); - if(p<0) throw std::runtime_error("failed to fork()"); + if(p<0) { + syslog(LOG_ERR,"Failed to fork away for hook execution"); + _exit(-1); + } if(!p) { - p = fork(); - if(p<0) { - syslog(LOG_ERR,"Failed to re-fork child process"); - _exit(-1); - } - if(!p) { - setsid(); - for(int i=getdtablesize();i>=0;--i) close(i); - int i=open("/dev/null",O_RDWR); assert(i==0); - i = dup(i); assert(i==1); - i = dup(i); assert(i==2); - return true; - } - _exit(0); + setsid(); + for(int i=getdtablesize();i>=0;--i) close(i); + int i=open("/dev/null",O_RDWR); assert(i==0); + i = dup(i); assert(i==1); + i = dup(i); assert(i==2); + return true; } - int rc; - if(waitpid(p,&rc,0)<0) throw std::runtime_error("failed to waitpid()"); - if(!WIFEXITED(rc)) throw std::runtime_error("error in forked process"); - if(WEXITSTATUS(rc)) throw std::runtime_error("forked process signalled error"); return false; } -- cgit v0.9.0.2