summaryrefslogtreecommitdiffabout
authorMichael Krelin <hacker@klever.net>2008-05-18 17:19:49 (UTC)
committer Michael Krelin <hacker@klever.net>2008-05-18 17:19:49 (UTC)
commit575d19f96c275d8b77642f20a8975e1cf0100eb5 (patch) (side-by-side diff)
treed67837d29c7cd09f2774c294e462ef9535ed544d
parent2123686e53a99cd32af754d861d71ff61c026732 (diff)
downloadlibopkele-575d19f96c275d8b77642f20a8975e1cf0100eb5.zip
libopkele-575d19f96c275d8b77642f20a8975e1cf0100eb5.tar.gz
libopkele-575d19f96c275d8b77642f20a8975e1cf0100eb5.tar.bz2
more checks on response validity during token acquisition
Signed-off-by: Michael Krelin <hacker@klever.net>
Diffstat (more/less context) (show whitespace changes)
-rw-r--r--include/opkele/oauth.h2
-rw-r--r--lib/oauth-consumer.cc7
2 files changed, 9 insertions, 0 deletions
diff --git a/include/opkele/oauth.h b/include/opkele/oauth.h
index 14d0586..bc6c2fa 100644
--- a/include/opkele/oauth.h
+++ b/include/opkele/oauth.h
@@ -16,2 +16,4 @@ namespace opkele {
: key(k), secret(s) { }
+
+ bool empty() const { return key.empty() && secret.empty(); }
};
diff --git a/lib/oauth-consumer.cc b/lib/oauth-consumer.cc
index bb4e89b..0d31ec7 100644
--- a/lib/oauth-consumer.cc
+++ b/lib/oauth-consumer.cc
@@ -132,2 +132,7 @@ namespace opkele {
throw exception_curl(OPKELE_CP_ "failed to perform curly request",r);
+ long response_code;
+ if( (r=curl.easy_getinfo(CURLINFO_RESPONSE_CODE,&response_code)) )
+ throw exception_curl(OPKELE_CP_ "failed to retrieve curl response code",r);
+ if(response_code!=200) /* TODO: specialize exception */
+ throw exception(OPKELE_CP_ "invalid response from the OAuth provider");
token_t rv;
@@ -155,2 +160,4 @@ namespace opkele {
}
+ if(rv.empty()) /* TODO: specialize */
+ throw exception(OPKELE_CP_ "failed to retrieve token from OAuth provider response");
return rv;