Merge commit '1e3ed01c149aaeed5a64aacff218a5486128fc92' into devel/openid20

2 files changed, 44 insertions, 15 deletions

diff --git a/include/opkele/curl.h b/include/opkele/curl.h
index 5cf8e48..bcaf11d 100644
--- a/include/opkele/curl.h
+++ b/include/opkele/curl.h
@@ -1,72 +1,92 @@
 #ifndef __OPKELE_CURL_H
 #define __OPKELE_CURL_H
 
 #include <cassert>
 #include <string>
 #include <algorithm>
 #include <curl/curl.h>
 
 namespace opkele {
     using std::min;
     using std::string;
 
     namespace util {
 
+        class curl_slist_t {
+            public:
+                curl_slist *_s;
+
+                curl_slist_t() : _s(0) { }
+                curl_slist_t(curl_slist *s) : _s(s) { }
+                virtual ~curl_slist_t() throw();
+
+                curl_slist_t& operator=(curl_slist *s);
+
+                operator const curl_slist*(void) const { return _s; }
+                operator curl_slist*(void) { return _s; }
+
+                void append(const char *str);
+                void append(const string& str) {
+                    append(str.c_str()); }
+        };
+
         class curl_t {
             public:
                 CURL *_c;
 
                 curl_t() : _c(0) { }
                 curl_t(CURL *c) : _c(c) { }
                 virtual ~curl_t() throw();
 
                 curl_t& operator=(CURL *c);
 
                 operator const CURL*(void) const { return _c; }
                 operator CURL*(void) { return _c; }
 
                 CURLcode misc_sets();
 
                 template<typename PT>
                     inline CURLcode easy_setopt(CURLoption o,PT p) { assert(_c); return curl_easy_setopt(_c,o,p); }
+                inline CURLcode easy_setopt(CURLoption o,const curl_slist_t& p) {
+                    assert(_c); return curl_easy_setopt(_c,o,(const curl_slist*)p); }
                 CURLcode easy_perform() { assert(_c); return curl_easy_perform(_c); }
                 template<typename IT>
                     inline CURLcode easy_getinfo(CURLINFO i,IT p) { assert(_c); return curl_easy_getinfo(_c,i,p); }
 
                 static inline CURL *easy_init() { return curl_easy_init(); }
 
                 virtual size_t write(void* /* p */,size_t /* s */,size_t /* nm */) { return 0; }
                 CURLcode set_write();
 
                 virtual int progress(double /* dlt */,double /* dln*/ ,double /* ult */,double /* uln */) { return 0; }
                 CURLcode set_progress();
 
                 virtual size_t header(void* /* p */,size_t s,size_t nm) { return s*nm; }
                 CURLcode set_header();
         };
 
         template<int lim>
             class curl_fetch_string_t : public curl_t {
                 public:
                     curl_fetch_string_t(CURL *c)
                         : curl_t(c) { }
                     ~curl_fetch_string_t() throw() { }
 
                     string response;
 
                     size_t write(void *p,size_t size,size_t nmemb) {
                         size_t bytes = size*nmemb;
                         size_t get = min(lim-response.length(),bytes);
                         response.append((const char *)p,get);
                         return get;
                     }
             };
 
         typedef curl_fetch_string_t<16384> curl_pick_t;
 
 
     }
 
 }
 
 #endif /* __OPKELE_CURL_H */
diff --git a/include/opkele/types.h b/include/opkele/types.h
index ffb9afb..f63bf5d 100644
--- a/include/opkele/types.h
+++ b/include/opkele/types.h
@@ -73,144 +73,153 @@ namespace opkele {
      */
     class association_t {
         public:
 
             virtual ~association_t() { }
 
             /**
              * retrieve the server with which association was established.
              * @return server name
              */
             virtual string server() const = 0;
             /**
              * retrieve the association handle.
              * @return handle
              */
             virtual string handle() const = 0;
             /**
              * retrieve the association type.
              * @return association type
              */
             virtual string assoc_type() const = 0;
             /**
              * retrieve the association secret.
              * @return association secret
              */
             virtual secret_t secret() const = 0; 
             /**
              * retrieve the number of seconds the association expires in.
              * @return seconds till expiration
              */
             virtual int expires_in() const = 0;
             /**
              * check whether the association is stateless.
              * @return true if stateless
              */
             virtual bool stateless() const = 0;
             /**
              * check whether the association is expired.
              * @return true if expired
              */
             virtual bool is_expired() const = 0;
     };
 
     /**
      * the shared_ptr<> for association_t object type
      */
     typedef tr1mem::shared_ptr<association_t> assoc_t;
 
-    class basic_openid_message {
+    class basic_fields {
         public:
-            typedef list<string> fields_t;
             typedef util::forward_iterator_proxy<
                 string,const string&,const string*
                 > fields_iterator;
 
-            basic_openid_message() { }
-            virtual ~basic_openid_message() { }
-            basic_openid_message(const basic_openid_message& x);
-            void copy_to(basic_openid_message& x) const;
-            void append_to(basic_openid_message& x) const;
+            basic_fields() { }
+            virtual ~basic_fields() { }
+            basic_fields(const basic_fields& x);
+            void copy_to(basic_fields& x) const;
+            void append_to(basic_fields& x) const;
 
             virtual bool has_field(const string& n) const = 0;
             virtual const string& get_field(const string& n) const = 0;
 
-            virtual bool has_ns(const string& uri) const;
-            virtual string get_ns(const string& uri) const;
-
             virtual fields_iterator fields_begin() const = 0;
             virtual fields_iterator fields_end() const = 0;
 
-            virtual string append_query(const string& url,const char *pfx="openid.") const;
-            virtual string query_string(const char *pfx="openid.") const;
-
+            virtual string append_query(const string& url,const char *pfx=0) const;
+            virtual string query_string(const char *pfx=0) const;
 
             virtual void reset_fields();
             virtual void set_field(const string& n,const string& v);
             virtual void reset_field(const string& n);
 
+    };
+
+    class basic_openid_message : public basic_fields {
+        public:
+
+            basic_openid_message() { }
+            basic_openid_message(const basic_openid_message& x);
+
+            virtual bool has_ns(const string& uri) const;
+            virtual string get_ns(const string& uri) const;
+
+            virtual string append_query(const string& url,const char *pfx="openid.") const {
+                return basic_fields::append_query(url,pfx); }
+            virtual string query_string(const char *pfx="openid.") const {
+                return basic_fields::query_string(pfx); }
+
             virtual void from_keyvalues(const string& kv);
             virtual void to_keyvalues(ostream& o) const;
 
             virtual void to_htmlhiddens(ostream& o,const char* pfx=0) const;
 
             void add_to_signed(const string& fields);
             string find_ns(const string& uri,const char *pfx) const;
             string allocate_ns(const string& uri,const char *pfx);
     };
 
     class openid_message_t : public basic_openid_message, public map<string,string> {
         public:
             openid_message_t() { }
             openid_message_t(const basic_openid_message& x)
                 : basic_openid_message(x) { }
 
-            void copy_to(basic_openid_message& x) const;
-
             bool has_field(const string& n) const;
             const string& get_field(const string& n) const;
             virtual fields_iterator fields_begin() const;
             virtual fields_iterator fields_end() const;
 
             void reset_fields();
             void set_field(const string& n,const string& v);
             void reset_field(const string& n);
     };
 
     /**
      * request/response parameters map
      */
     class params_t : public openid_message_t {
         public:
 
             /**
              * check whether the parameter is present.
              * @param n the parameter name
              * @return true if yes
              */
             bool has_param(const string& n) const {
                 return has_field(n); }
             /**
              * retrieve the parameter (const version)
              * @param n the parameter name
              * @return the parameter value
              * @throw failed_lookup if there is no such parameter
              */
             const string& get_param(const string& n) const {
                 return get_field(n); }
 
             /**
              * parse the OpenID key/value data.
              * @param kv the OpenID key/value data
              */
             void parse_keyvalues(const string& kv) {
                 from_keyvalues(kv); }
 
             string append_query(const string& url,const char *prefix="openid.") const;
 
     };
 
     struct openid_endpoint_t {
         string uri;
         string claimed_id;
         string local_id;