author | Michael Krelin <hacker@klever.net> | 2008-02-08 11:37:18 (UTC) |
---|---|---|
committer | Michael Krelin <hacker@klever.net> | 2008-02-08 11:37:18 (UTC) |
commit | a62ccf212acb27a092a48d3af8ee0bfb3efdb666 (patch) (side-by-side diff) | |
tree | 5bb03107969e937446ef63e16dacc1faacbd3962 /lib/basic_op.cc | |
parent | 9163a26ec8839a31df888920418280a62ebc5595 (diff) | |
download | libopkele-a62ccf212acb27a092a48d3af8ee0bfb3efdb666.zip libopkele-a62ccf212acb27a092a48d3af8ee0bfb3efdb666.tar.gz libopkele-a62ccf212acb27a092a48d3af8ee0bfb3efdb666.tar.bz2 |
do not allocate stateless assoc ahead of time
that would just pollute the database
Signed-off-by: Michael Krelin <hacker@klever.net>
-rw-r--r-- | lib/basic_op.cc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/lib/basic_op.cc b/lib/basic_op.cc index 9e2ea5a..7a2dbd2 100644 --- a/lib/basic_op.cc +++ b/lib/basic_op.cc @@ -143,12 +143,9 @@ namespace opkele { throw bad_input(OPKELE_CP_ "Invalid checkid_* mode"); try { assoc = retrieve_assoc(invalidate_handle=inm.get_field("assoc_handle")); invalidate_handle.clear(); - }catch(failed_lookup&) { - // no handle specified or no valid assoc found, go dumb - assoc = alloc_assoc("HMAC-SHA256",SHA256_DIGEST_LENGTH,true); - } + }catch(failed_lookup&) { } try { openid2 = (inm.get_field("ns")==OIURI_OPENID20); }catch(failed_lookup&) { openid2 = false; } try { @@ -197,11 +194,13 @@ namespace opkele { } basic_openid_message& basic_op::id_res(basic_openid_message& om, extension_t *ext) { - assert(assoc); assert(!return_to.empty()); assert(!is_id_select()); + if(!assoc) { + assoc = alloc_assoc("HMAC-SHA256",SHA256_DIGEST_LENGTH,true); + } time_t now = time(0); struct tm gmt; gmtime_r(&now,&gmt); char w3timestr[24]; if(!strftime(w3timestr,sizeof(w3timestr),"%Y-%m-%dT%H:%M:%SZ",&gmt)) |