author | Michael Krelin <hacker@klever.net> | 2008-02-08 11:37:18 (UTC) |
---|---|---|
committer | Michael Krelin <hacker@klever.net> | 2008-02-08 11:37:18 (UTC) |
commit | a62ccf212acb27a092a48d3af8ee0bfb3efdb666 (patch) (unidiff) | |
tree | 5bb03107969e937446ef63e16dacc1faacbd3962 /lib | |
parent | 9163a26ec8839a31df888920418280a62ebc5595 (diff) | |
download | libopkele-a62ccf212acb27a092a48d3af8ee0bfb3efdb666.zip libopkele-a62ccf212acb27a092a48d3af8ee0bfb3efdb666.tar.gz libopkele-a62ccf212acb27a092a48d3af8ee0bfb3efdb666.tar.bz2 |
do not allocate stateless assoc ahead of time
that would just pollute the database
Signed-off-by: Michael Krelin <hacker@klever.net>
-rw-r--r-- | lib/basic_op.cc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/lib/basic_op.cc b/lib/basic_op.cc index 9e2ea5a..7a2dbd2 100644 --- a/lib/basic_op.cc +++ b/lib/basic_op.cc | |||
@@ -131,36 +131,33 @@ namespace opkele { | |||
131 | return oum; | 131 | return oum; |
132 | } | 132 | } |
133 | 133 | ||
134 | void basic_op::checkid_(const basic_openid_message& inm, | 134 | void basic_op::checkid_(const basic_openid_message& inm, |
135 | extension_t *ext) { | 135 | extension_t *ext) { |
136 | reset_vars(); | 136 | reset_vars(); |
137 | string mode = inm.get_field("mode"); | 137 | string mode = inm.get_field("mode"); |
138 | if(mode=="checkid_setup") | 138 | if(mode=="checkid_setup") |
139 | mode = mode_checkid_setup; | 139 | mode = mode_checkid_setup; |
140 | else if(mode=="checkid_immediate") | 140 | else if(mode=="checkid_immediate") |
141 | mode = mode_checkid_immediate; | 141 | mode = mode_checkid_immediate; |
142 | else | 142 | else |
143 | throw bad_input(OPKELE_CP_ "Invalid checkid_* mode"); | 143 | throw bad_input(OPKELE_CP_ "Invalid checkid_* mode"); |
144 | try { | 144 | try { |
145 | assoc = retrieve_assoc(invalidate_handle=inm.get_field("assoc_handle")); | 145 | assoc = retrieve_assoc(invalidate_handle=inm.get_field("assoc_handle")); |
146 | invalidate_handle.clear(); | 146 | invalidate_handle.clear(); |
147 | }catch(failed_lookup&) { | 147 | }catch(failed_lookup&) { } |
148 | // no handle specified or no valid assoc found, go dumb | ||
149 | assoc = alloc_assoc("HMAC-SHA256",SHA256_DIGEST_LENGTH,true); | ||
150 | } | ||
151 | try { | 148 | try { |
152 | openid2 = (inm.get_field("ns")==OIURI_OPENID20); | 149 | openid2 = (inm.get_field("ns")==OIURI_OPENID20); |
153 | }catch(failed_lookup&) { openid2 = false; } | 150 | }catch(failed_lookup&) { openid2 = false; } |
154 | try { | 151 | try { |
155 | return_to = inm.get_field("return_to"); | 152 | return_to = inm.get_field("return_to"); |
156 | }catch(failed_lookup&) { } | 153 | }catch(failed_lookup&) { } |
157 | if(openid2) { | 154 | if(openid2) { |
158 | try { | 155 | try { |
159 | realm = inm.get_field("realm"); | 156 | realm = inm.get_field("realm"); |
160 | }catch(failed_lookup&) { | 157 | }catch(failed_lookup&) { |
161 | try { | 158 | try { |
162 | realm = inm.get_field("trust_root"); | 159 | realm = inm.get_field("trust_root"); |
163 | }catch(failed_lookup&) { | 160 | }catch(failed_lookup&) { |
164 | if(return_to.empty()) | 161 | if(return_to.empty()) |
165 | throw bad_input(OPKELE_CP_ | 162 | throw bad_input(OPKELE_CP_ |
166 | "Both realm and return_to are unset"); | 163 | "Both realm and return_to are unset"); |
@@ -185,35 +182,37 @@ namespace opkele { | |||
185 | if(openid2) | 182 | if(openid2) |
186 | throw bad_input(OPKELE_CP_ | 183 | throw bad_input(OPKELE_CP_ |
187 | "claimed_id and identity must be either both present or both absent"); | 184 | "claimed_id and identity must be either both present or both absent"); |
188 | claimed_id = identity; | 185 | claimed_id = identity; |
189 | } | 186 | } |
190 | }catch(failed_lookup&) { | 187 | }catch(failed_lookup&) { |
191 | if(openid2 && inm.has_field("claimed_id")) | 188 | if(openid2 && inm.has_field("claimed_id")) |
192 | throw bad_input(OPKELE_CP_ | 189 | throw bad_input(OPKELE_CP_ |
193 | "claimed_id and identity must be either both present or both absent"); | 190 | "claimed_id and identity must be either both present or both absent"); |
194 | } | 191 | } |
195 | verify_return_to(); | 192 | verify_return_to(); |
196 | if(ext) ext->op_checkid_hook(inm); | 193 | if(ext) ext->op_checkid_hook(inm); |
197 | } | 194 | } |
198 | 195 | ||
199 | basic_openid_message& basic_op::id_res(basic_openid_message& om, | 196 | basic_openid_message& basic_op::id_res(basic_openid_message& om, |
200 | extension_t *ext) { | 197 | extension_t *ext) { |
201 | assert(assoc); | ||
202 | assert(!return_to.empty()); | 198 | assert(!return_to.empty()); |
203 | assert(!is_id_select()); | 199 | assert(!is_id_select()); |
200 | if(!assoc) { | ||
201 | assoc = alloc_assoc("HMAC-SHA256",SHA256_DIGEST_LENGTH,true); | ||
202 | } | ||
204 | time_t now = time(0); | 203 | time_t now = time(0); |
205 | struct tm gmt; gmtime_r(&now,&gmt); | 204 | struct tm gmt; gmtime_r(&now,&gmt); |
206 | char w3timestr[24]; | 205 | char w3timestr[24]; |
207 | if(!strftime(w3timestr,sizeof(w3timestr),"%Y-%m-%dT%H:%M:%SZ",&gmt)) | 206 | if(!strftime(w3timestr,sizeof(w3timestr),"%Y-%m-%dT%H:%M:%SZ",&gmt)) |
208 | throw failed_conversion(OPKELE_CP_ | 207 | throw failed_conversion(OPKELE_CP_ |
209 | "Failed to build time string for nonce" ); | 208 | "Failed to build time string for nonce" ); |
210 | om.set_field("ns",OIURI_OPENID20); | 209 | om.set_field("ns",OIURI_OPENID20); |
211 | om.set_field("mode","id_res"); | 210 | om.set_field("mode","id_res"); |
212 | om.set_field("op_endpoint",get_op_endpoint()); | 211 | om.set_field("op_endpoint",get_op_endpoint()); |
213 | string ats = "ns,mode,op_endpoint,return_to,response_nonce," | 212 | string ats = "ns,mode,op_endpoint,return_to,response_nonce," |
214 | "assoc_handle,signed"; | 213 | "assoc_handle,signed"; |
215 | if(!identity.empty()) { | 214 | if(!identity.empty()) { |
216 | om.set_field("identity",identity); | 215 | om.set_field("identity",identity); |
217 | om.set_field("claimed_id",claimed_id); | 216 | om.set_field("claimed_id",claimed_id); |
218 | ats += ",identity,claimed_id"; | 217 | ats += ",identity,claimed_id"; |
219 | } | 218 | } |