fix for misleading error message about unexpected source

along with a double-freeing offense. When I fail to receive packet not only
I diagnose this unfortunate development, but also start talking about
packet from unexpected source which is kinda weird considering there's
no packet at all.

Signed-off-by: Michael Krelin <hacker@klever.net>

1 files changed, 1 insertions, 0 deletions

diff --git a/PumpKINDlg.cpp b/PumpKINDlg.cpp
index f41b69f..3ff1500 100644..100755
--- a/PumpKINDlg.cpp
+++ b/PumpKINDlg.cpp
@@ -348,512 +348,513 @@ void CPumpKINDlg::OnPaint()
 				pDC.BitBlt(x,y,m_bitmapBack.bmWidth,m_bitmapBack.bmHeight,&bmpDC,0,0,SRCCOPY);

 		bmpDC.DeleteDC();

 		CDialog::OnPaint();

 	}

 }

 

 // The system calls this to obtain the cursor to display while the user drags

 //  the minimized window.

 HCURSOR CPumpKINDlg::OnQueryDragIcon()

 {

 	return (HCURSOR) m_hIcon;

 }

 

 int CPumpKINDlg::OnCreate(LPCREATESTRUCT lpCreateStruct) 

 {

 	if (CDialog::OnCreate(lpCreateStruct) == -1)

 		return -1;

 

 	if(!m_Listener.SetListen(m_bListen)) {

 		m_bListen=FALSE;

 		TRACE0("Failed to create socket\n");

 		AfxMessageBox(IDS_BOX_CANTBIND,MB_OK|MB_ICONEXCLAMATION);

 	}

 

 	if(!m_Trayer->Create(NULL,"PumpKIN TrayIcon",WS_CHILD,CRect(0,0,0,0),this,0)){

 		TRACE0("Failed to create trayer\n");

 		return -1;

 	}

 

 NOTIFYICONDATA nid;

 	memset(&nid,0,sizeof(nid));

 	nid.cbSize=sizeof(nid);

 	nid.hWnd=m_Trayer->m_hWnd;

 	nid.uID=IDC_TRAYICON;

 	nid.uFlags=NIF_MESSAGE|NIF_ICON|NIF_TIP;

 	nid.uCallbackMessage=WM_TRAYICON;

 	nid.hIcon=AfxGetApp()->LoadIcon(IDR_MAINFRAME);

 	// *** Load from resource

 	strcpy(nid.szTip,"PumpKIN");

 	VERIFY(Shell_NotifyIcon(NIM_ADD,&nid));

 

 	return 0;

 }

 

 void CListenSocket::OnReceive(int nErrorCode)

 {

 	ASSERT(m_Daddy);

 	if(nErrorCode){

 		m_Daddy->LogLine(IDS_LOG_LISTENRECEIVEERROR);

 		return;

 	}

 DWORD fionread = 0;

 	VERIFY(IOCtl(FIONREAD,&fionread));	// *** Do some checking on the value acquired

 tftp *tftpRQ = tftp::Allocate(fionread);

 	ASSERT(tftpRQ);

 SOCKADDR_IN sin;

 	if(!tftpRQ->Receive(this,fionread,&sin)){

 		m_Daddy->LogLine(IDS_LOG_LISTENACCEPTERROR);

 		delete tftpRQ;

 		return;

 	}

 #ifndef	NDEBUG

 CString tmp;

 	tmp.Format("%u - %s - %u\n",tftpRQ->Opcode(),inet_ntoa(sin.sin_addr),sin.sin_port);

 	TRACE0(tmp);

 #endif

 POSITION p = m_Daddy->m_Xfers.GetStartPosition();

 	while(p){

 	SOCKET key;

 	CXferSocket *sock;

 		m_Daddy->m_Xfers.GetNextAssoc(p,key,sock);

 		ASSERT(sock);

 		if(sock->m_Peer.sin_addr.s_addr==sin.sin_addr.s_addr && sock->m_Peer.sin_port==sin.sin_port){

 			TRACE0("Ignoring request which we are already processing\n");

 			delete tftpRQ;

 			return;

 		}

 	}

 	switch(tftpRQ->Opcode()){

 	case tftp::opRRQ:

 		// Read Request

 		{

 		CString tmp;

 			tmp.Format(IDS_LOG_RRQSERVE,tftpRQ->rqFileName(),tftpRQ->rqType(),inet_ntoa(sin.sin_addr));

 			m_Daddy->LogLine(tmp);

 		CRRQSocket *s = new CRRQSocket(m_Daddy,tftpRQ->rqFileName(),tftpRQ->rqType(),&sin);

 			ASSERT(s);

 			tftpRQ->GetOptions(&s->m_Options);

 			if(!s->Create())

 				s->Destroy(FALSE);

 		}

 		break;

 	case tftp::opWRQ:

 		// Write Request

 		{

 		CString tmp;

 			tmp.Format(IDS_LOG_WRQSERVE,tftpRQ->rqFileName(),tftpRQ->rqType(),inet_ntoa(sin.sin_addr));

 			m_Daddy->LogLine(tmp);

 		CWRQSocket *s = new CWRQSocket(m_Daddy,tftpRQ->rqFileName(),tftpRQ->rqType(),&sin);

 			ASSERT(s);

 			tftpRQ->GetOptions(&s->m_Options);

 			if(!s->Create(NULL,NULL))

 				s->Destroy(FALSE);

 		}

 		break;

 	default:

 		m_Daddy->LogLine(IDS_LOG_LISTENOPCODE);

 		delete tftpRQ;

 		return;

 	}

 	delete tftpRQ;

 }

 

 BOOL tftp::Receive(CAsyncSocket* socket,UINT maxLength,SOCKADDR_IN *sin)

 {

 	ASSERT(socket);

 int saddrLen = sizeof(SOCKADDR_IN);

 	length = sin ? 

 			socket->ReceiveFrom(udpBase(),maxLength,(SOCKADDR*)sin,&saddrLen)

 		:

 			socket->Receive(udpBase(),maxLength)

 	;

 	if(!length)

 		return FALSE;

 	if(length==(tftpLength)SOCKET_ERROR)

 		return FALSE;

 	return TRUE;

 }

 

 UINT tftp::Opcode()

 {

 	return REVERSEBYTES(opcode);

 }

 

 CString tftp::rqFileName()

 {

 	ASSERT(length);

 	ASSERT(Opcode()==opRRQ || Opcode()==opWRQ);

 CString rv;

 	if(memchr(&data.m_RQ.data,0,length-sizeof(opcode)))

 		rv = (LPCTSTR)data.m_RQ.data;

 	return rv;

 }

 

 CString tftp::rqType()

 {

 	ASSERT(length);

 	ASSERT(Opcode()==opRRQ || Opcode()==opWRQ);

 CString rv;

 char *tmp = (char*)memchr(&data.m_RQ.data,0,length-sizeof(opcode));

 	if(tmp++)

 		rv = (LPCTSTR)tmp;

 	return rv;

 }

 

 UINT tftp::GetOptions(tftp::tftpOptions* ops)

 {

 	ASSERT(length);

 	ASSERT(Opcode()==opRRQ || Opcode()==opWRQ || Opcode()==opOACK);

 	ASSERT(ops);

 tftpOptions& o = *ops;

 LPSTR base = (LPSTR)&data.m_RQ.data;

 UINT basePtr = 0;

 	if(Opcode()==opRRQ || Opcode()==opWRQ){

 		base = (LPSTR)memchr(&data.m_RQ.data,0,length-sizeof(opcode));

 		if(!base)

 			return 0;

 		base++;

 		basePtr = (base-(LPSTR)&data.m_RQ.data);

 		base = (LPSTR)memchr(base,0,length-basePtr);

 		if(!base)

 			return 0;

 		base++;

 		basePtr = (base-(LPSTR)&data.m_RQ.data);

 	}

 	ops->RemoveAll();

 UINT rv = 0;

 	while(basePtr<(length-sizeof(opcode))){

 	CString onam = (LPSTR)&data.m_RQ.data[basePtr];

 		basePtr+=onam.GetLength()+1;

 	CString oval = (LPSTR)&data.m_RQ.data[basePtr];

 		basePtr+=oval.GetLength()+1;

 		onam.MakeLower();

 		o[onam]=oval;

 		rv++;

 	}

 	return rv;

 }

 

 tftp::tftp()

 {

 	length=0;

 }

 

 

 void CXferSocket::OnSend(int nErrorCode)

 {

 	if(nErrorCode){

 		ASSERT(m_Daddy);

 		m_Daddy->LogLine(IDS_LOG_XFERSEND);

 		return;

 	}

 	if(!m_Queue.IsEmpty()){

 	tftp *p = m_Queue.GetHead();

 		ASSERT(p);

 		m_Queue.RemoveHead();

 		if(!p->Send(this,&m_Peer)){

 			ASSERT(m_Daddy);

 			m_Daddy->LogLine(IDS_LOG_XFERUDPSEND);

 		}

 		delete p;

 	}

 	DoSelect();

 	if(m_Queue.IsEmpty()){

 		switch(state){

 		case stateDeny:

 			Destroy(FALSE);

 			break;

 		case stateFinish:

 			Destroy(TRUE);

 			break;

 		}

 	}

 }

 

 BOOL tftp::Send(CAsyncSocket *socket,SOCKADDR_IN* saddr)

 {

 	ASSERT(socket);

 int rv = socket->SendTo(udpBase(),length,(SOCKADDR*)saddr,sizeof(SOCKADDR_IN));

 	if(rv!=length)

 		return FALSE;

 	return TRUE;

 }

 

 void CXferSocket::DoSelect(BOOL do_select)

 {

 	if(m_Peer.sin_addr.s_addr!=INADDR_NONE)

 		AsyncSelect(FD_CLOSE|FD_READ|((m_Queue.IsEmpty()&&!do_select)?0:FD_WRITE));

 }

 

 void CXferSocket::OnReceive(int nErrorCode)

 {

 	if(nErrorCode){

 		ASSERT(m_Daddy);

 		m_Daddy->LogLine(IDS_LOG_XFERRECEIVE);

 		return;

 	}

 	ASSERT(m_Daddy);

 DWORD fionread = 0;

 	VERIFY(IOCtl(FIONREAD,&fionread));

 tftp *p = tftp::Allocate(fionread);

 	ASSERT(p);

 SOCKADDR_IN sin;

 	if(!p->Receive(this,fionread,&sin)){

 		m_Daddy->LogLine(IDS_LOG_XFERUDPRECEIVE);

 		delete p;

+		return;

 	}else

 		if(m_Peer.sin_addr.s_addr==INADDR_NONE){

 			m_Peer.sin_addr=sin.sin_addr;

 			m_Peer.sin_port=sin.sin_port;

 	}

 BOOL alive = TRUE;

 	if(state==stateInit){

 		state=stateXfer;

 		m_Peer.sin_port=sin.sin_port;

 		UpdateList();

 	}

 	if(sin.sin_addr.s_addr!=m_Peer.sin_addr.s_addr || sin.sin_port!=m_Peer.sin_port){

 		m_Daddy->LogLine(IDS_LOG_XFERSOURCETID);

 		// *** Bounce it!

 	}else{

 		alive = OnTFTP(p);

 	}

 	delete p;

 	if(alive){

 		DoSelect();

 		ResetTimeout();

 	}

 }

 

 void CXferSocket::SetPeer(SOCKADDR_IN *sin)

 {

 	ASSERT(sin);

 	memmove(&m_Peer,sin,sizeof(m_Peer));

 }

 

 void CXferSocket::UpdateList()

 {

 	ASSERT(m_Daddy);

 LV_FINDINFO lvf;

 	memset(&lvf,0,sizeof(lvf));

 	lvf.flags=LVFI_PARAM;

 	lvf.lParam=(LPARAM)this;

 int i = m_Daddy->m_List.FindItem(&lvf);

 	if(i<0){

 		ASSERT(IsKindOf(RUNTIME_CLASS(CRRQSocket)) || IsKindOf(RUNTIME_CLASS(CWRQSocket)));

 		i=m_Daddy->m_List.InsertItem(0,m_FileName,IsKindOf(RUNTIME_CLASS(CRRQSocket))?m_Daddy->m_iRRQ:m_Daddy->m_iWRQ);

 		ASSERT(!(i<0));

 		m_Daddy->m_List.SetItemData(i,(DWORD)this);

 	}

 	m_Daddy->m_List.SetItemText(i,CPumpKINDlg::subitemFile,m_FileName);

 	m_Daddy->m_List.SetItemText(i,CPumpKINDlg::subitemType,m_Type);

 	m_Daddy->m_List.SetItemText(i,CPumpKINDlg::subitemPeer,inet_ntoa(m_Peer.sin_addr));

 CString tmp;

 	tmp.Format(IDS_FMT_BYTES,GetACK());

 	m_Daddy->m_List.SetItemText(i,CPumpKINDlg::subitemBytes,tmp);

 	if(m_xferSize>=0){

 		tmp.Format(IDS_FMT_BYTES,m_xferSize);

 		m_Daddy->m_List.SetItemText(i,CPumpKINDlg::subitemTSize,tmp);

 	}

 }

 

 CXferSocket::CXferSocket()

 	: m_wndResolver(NULL), m_Retry(NULL), m_bRetry(FALSE),

 	m_blkSize(512), m_timeOut(30), m_xferSize(-1),

 	m__blkSize(512), m__timeOut(30)

 {

 	m_Daddy=NULL;

 	m_Peer.sin_addr.s_addr=INADDR_NONE;

 	m_Peer.sin_family=AF_INET;

 	state=stateNone;

 }

 

 ULONG CXferSocket::GetACK()

 {

 	return 0;

 }

 

 CXferSocket::CXferSocket(CPumpKINDlg *daddy,LPCTSTR fileName,LPCTSTR type,SOCKADDR_IN* sin)

 	: m_wndResolver(NULL), m_Retry(NULL), m_bRetry(FALSE),

 	m_blkSize(512), m_timeOut(30), m_xferSize(-1),

 	m__blkSize(512), m__timeOut(30)

 {

 	m_Peer.sin_family=AF_INET;

 	state=stateNone;

 	ASSERT(daddy);

 	m_Daddy=daddy;

 	m_timeOut=m__timeOut=m_Daddy->m_TFTPTimeOut.GetTotalSeconds();

 	if(sin){

 		m_Peer.sin_addr.s_addr=sin->sin_addr.s_addr;

 		m_Peer.sin_port=sin->sin_port;

 	}else

 		m_Peer.sin_addr.s_addr=INADDR_NONE;

 	m_FileName=fileName;

 	m_Type=type;

 }

 

 BOOL CRRQSocket::Create(LPCTSTR localFile,LPCTSTR hostName)

 {

 	if(!CAsyncSocket::Create(0,SOCK_DGRAM))

 		return FALSE;

 	ASSERT(m_Daddy);

 	ASSERT(m_Peer.sin_addr.s_addr!=INADDR_NONE || hostName);

 	m_Daddy->m_Xfers[m_hSocket]=this;

 CString lFile = localFile?localFile:m_FileName;

 	TurnSlashes(lFile,TRUE);

 	UpdateList();

 	if(!localFile){	// Check only for incoming requests

 		if(CheckBadRelativeness(m_FileName)){

 			Deny(tftp::errAccessViolation,IDS_TFTP_ERROR_ACCESS);

 			return TRUE;

 		}

 		int atar=m_Daddy->m_aclRules.FindTarget(acl_rule::opRRQ,m_Peer.sin_addr.s_addr);

 		if(atar<0)

 			atar = m_Daddy->m_RRQMode;

 		switch(atar){

 		case CPumpKINDlg::rrqGiveAll:

 			break;

 		case CPumpKINDlg::rrqAlwaysConfirm:

 			if(ConfirmRequest())

 				break;

 		default:

 			TRACE1("Unexpected access target: %d\n",atar);

 		case CPumpKINDlg::rrqDenyAll:

 			Deny(tftp::errAccessViolation,IDS_TFTP_ERROR_ACCESS);

 			return TRUE;

 		}

 	}

 CString fn = localFile?ApplyRootGently(lFile):ApplyRoot(lFile);

 CFileException e;

 	if(!m_File.Open(fn,CFile::modeRead|CFile::shareDenyWrite,&e)){

 		if(localFile){

 		CString tmp;

 			tmp.Format(IDS_LOG_FAILEDLOCALFILE,fn);

 			m_Daddy->LogLine(tmp);

 			return FALSE;

 		}

 		Deny(&e);

 		return TRUE;

 	}

 	m_xferSize=m_File.GetLength();	// *** HANDLE EXCEPTION

 	if(hostName){

 		m_HostName=hostName;

 	

 	CString tmp;

 		tmp.Format(IDS_LOG_SENDING,m_FileName,m_HostName);

 		m_Daddy->LogLine(tmp);

 

 		CString inAddr = hostName;

 	int at = inAddr.Find('@');

 		if(at>=0)

 			inAddr=inAddr.Mid(at+1);

 		if((m_Peer.sin_addr.s_addr=inet_addr((LPCTSTR)inAddr))==INADDR_NONE){

 			ASSERT(!m_wndResolver);

 			m_wndResolver = new CResolver(this);

 			ASSERT(m_wndResolver);

 			return m_wndResolver->Resolve();

 		}

 		else

 			OnHostKnown();

 	}else{

 	tftp::tftpOptions o;

 	CString v;

 		if(m_Options.Lookup(tftpoBSize,v)){

 			m__blkSize=atoi(v);

 			if(m__blkSize){

 				m_blkSize=m__blkSize;

 				v.Format("%u",m_blkSize);

 				o[tftpoBSize]=v;

 			}

 		}

 		if(m_Options.Lookup(tftpoTSize,v)){

 			v.Format("%lu",m_xferSize);

 			o[tftpoTSize]=v;

 		}

 		if(m_Options.Lookup(tftpoTOut,v)){

 			m__timeOut=atoi(v);

 			if(m__timeOut){

 				m_timeOut=m__timeOut;

 				v.Format("%u",m_timeOut);

 				o[tftpoTOut]=v;

 			}

 		}

 		// XXX: see if we can enforce our preference regarding block size here.

 		if(m_xferSize >= (m_blkSize<<16)) {

 			Deny(tftp::errUndefined,IDS_TFTP_ERROR_TOOBIG);

 			return TRUE;

 		}

 		state = stateXfer;

 		m_ACK=0;

 		if(o.GetCount()){

 		tftp *p = tftp::Allocate(tftp::tftpOACK::tftpSize(&o));

 			ASSERT(p);

 			p->SetOpcode(tftp::opOACK);

 			p->data.m_OACK.Set(&o);

 			PostTFTP(p,TRUE);

 		}else

 			DoXfer();

 	}

 	return TRUE;

 }

 

 CRRQSocket::CRRQSocket(CPumpKINDlg *daddy,LPCTSTR fileName,LPCTSTR type,SOCKADDR_IN *sin)

 	: CXferSocket(daddy,fileName,type,sin)

 {

 	m_ACK=0;

 	m_LastSlack=0;

 }

 

 UINT tftp::tftpERROR::tftpSize(LPCTSTR msg)

 {

 	return tftpHdrSize-tftpSlackSize+sizeof(tftp::tftpERROR::tftpErrorCode)+strlen(msg)+1;

 }

 

 tftp* tftp::Allocate(UINT tftpSize)

 {

 	ASSERT(tftpSize);

 tftp* rv = (tftp*) new BYTE[tftpSlackSize+tftpSize];

 	ASSERT(rv);

 	rv->length=tftpSize;

 	return rv;

 }

 

 void tftp::errSet(UINT code,LPCTSTR msg)

 {

 	ASSERT(this);

 	ASSERT(length>=data.m_ERROR.tftpSize(msg));

 	strcpy((char*)data.m_ERROR.data,msg);

 	data.m_ERROR.SetCode(code);

 }

 

 void CXferSocket::PostTFTP(tftp* p,BOOL retryable)

 {

 	ASSERT(p);

 	m_Queue.AddTail(p);

 	DoSelect();

 	if(!m_bRetry){

 		if(retryable)

 			SetTry(p);

 		else

 			SetTry();

 	}

 	ResetTimeout();

 }

 

 void CXferSocket::Deny(UINT errCode,UINT errID)

 {

 	PostError(errCode,errID);

 	state=stateDeny;

 }

 

 void CRRQSocket::DoXfer()

 {

 tftp *p = tftp::Allocate(tftp::tftpDATA::tftpSize(m_blkSize));

 	ASSERT(p);

 	p->SetOpcode(tftp::opDATA);

 	TRY{

 		m_File.Seek(m_ACK*m_blkSize,CFile::begin);

 	int bytes = m_File.Read(p->data.m_DATA.data,m_blkSize);

 		p->data.m_DATA.SetBlock(m_ACK+1);

 		p->length=p->length-m_blkSize+bytes;

 		m_LastSlack = m_blkSize-bytes;