summaryrefslogtreecommitdiffabout
authorLukas Fleischer <cgit@cryptocrack.de>2011-03-30 23:21:39 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2011-05-23 20:58:35 (UTC)
commit070e109c1413d28b54eb6123a9fd24ac98897554 (patch) (side-by-side diff)
tree70f10262cdbc29cb9d083d24c03b1524a3d90ecd
parentc9059710e7a1dbd47c22c412e0ba8f591105e3cf (diff)
downloadcgit-070e109c1413d28b54eb6123a9fd24ac98897554.zip
cgit-070e109c1413d28b54eb6123a9fd24ac98897554.tar.gz
cgit-070e109c1413d28b54eb6123a9fd24ac98897554.tar.bz2
Fix memory leak in http_parse_querystring().
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--html.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/html.c b/html.c
index 6f31097..a0f6db4 100644
--- a/html.c
+++ b/html.c
@@ -281,42 +281,43 @@ char *convert_query_hexchar(char *txt)
if (d1<0 || d2<0) {
memmove(txt, txt+3, n-2);
return txt-1;
} else {
*txt = d1 * 16 + d2;
memmove(txt+1, txt+3, n-2);
return txt;
}
}
int http_parse_querystring(const char *txt_, void (*fn)(const char *name, const char *value))
{
- char *t, *txt, *value = NULL, c;
+ char *o, *t, *txt, *value = NULL, c;
if (!txt_)
return 0;
- t = txt = strdup(txt_);
+ o = t = txt = strdup(txt_);
if (t == NULL) {
printf("Out of memory\n");
exit(1);
}
while((c=*t) != '\0') {
if (c=='=') {
*t = '\0';
value = t+1;
} else if (c=='+') {
*t = ' ';
} else if (c=='%') {
t = convert_query_hexchar(t);
} else if (c=='&') {
*t = '\0';
(*fn)(txt, value);
txt = t+1;
value = NULL;
}
t++;
}
if (t!=txt)
(*fn)(txt, value);
+ free(o);
return 0;
}