summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2007-06-18 22:56:40 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2007-06-18 22:56:40 (UTC)
commit0d05bca502f4a5347fa629045aca97ba9b404acc (patch) (unidiff)
treee11b6a3e183aab02824f83c51759b5d426a64a67
parenta215bf4620113fcefb8dd3442bf3501bd648c463 (diff)
downloadcgit-0d05bca502f4a5347fa629045aca97ba9b404acc.zip
cgit-0d05bca502f4a5347fa629045aca97ba9b404acc.tar.gz
cgit-0d05bca502f4a5347fa629045aca97ba9b404acc.tar.bz2
Add setting to enable/disable extra links on index page
The summary/log/tree links displayed for each repository on the index page lost some of their purpose when the header menu was added, so this commit introduces the parameter 'enable-index-links' which must be set to 1 to enable these links. Suggested-by: Kristian Høgsberg <krh@bitplanet.net> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (show whitespace changes)
-rw-r--r--cgit.h1
-rw-r--r--cgitrc4
-rw-r--r--shared.c3
-rw-r--r--ui-repolist.c25
4 files changed, 26 insertions, 7 deletions
diff --git a/cgit.h b/cgit.h
index bd2dd0d..81c819d 100644
--- a/cgit.h
+++ b/cgit.h
@@ -109,24 +109,25 @@ extern char *cgit_css;
109extern char *cgit_logo; 109extern char *cgit_logo;
110extern char *cgit_index_header; 110extern char *cgit_index_header;
111extern char *cgit_logo_link; 111extern char *cgit_logo_link;
112extern char *cgit_module_link; 112extern char *cgit_module_link;
113extern char *cgit_agefile; 113extern char *cgit_agefile;
114extern char *cgit_virtual_root; 114extern char *cgit_virtual_root;
115extern char *cgit_script_name; 115extern char *cgit_script_name;
116extern char *cgit_cache_root; 116extern char *cgit_cache_root;
117extern char *cgit_repo_group; 117extern char *cgit_repo_group;
118 118
119extern int cgit_nocache; 119extern int cgit_nocache;
120extern int cgit_snapshots; 120extern int cgit_snapshots;
121extern int cgit_enable_index_links;
121extern int cgit_enable_log_filecount; 122extern int cgit_enable_log_filecount;
122extern int cgit_enable_log_linecount; 123extern int cgit_enable_log_linecount;
123extern int cgit_max_lock_attempts; 124extern int cgit_max_lock_attempts;
124extern int cgit_cache_root_ttl; 125extern int cgit_cache_root_ttl;
125extern int cgit_cache_repo_ttl; 126extern int cgit_cache_repo_ttl;
126extern int cgit_cache_dynamic_ttl; 127extern int cgit_cache_dynamic_ttl;
127extern int cgit_cache_static_ttl; 128extern int cgit_cache_static_ttl;
128extern int cgit_cache_max_create_time; 129extern int cgit_cache_max_create_time;
129extern int cgit_summary_log; 130extern int cgit_summary_log;
130 131
131extern int cgit_max_msg_len; 132extern int cgit_max_msg_len;
132extern int cgit_max_repodesc_len; 133extern int cgit_max_repodesc_len;
diff --git a/cgitrc b/cgitrc
index 0f602e4..40877f8 100644
--- a/cgitrc
+++ b/cgitrc
@@ -3,24 +3,28 @@
3## 3##
4 4
5 5
6## Uncomment and set to 1 to deactivate caching of generated pages. Mostly 6## Uncomment and set to 1 to deactivate caching of generated pages. Mostly
7## usefull for testing. 7## usefull for testing.
8#nocache=0 8#nocache=0
9 9
10 10
11## Enable/disable snapshots by default. This can be overridden per repo 11## Enable/disable snapshots by default. This can be overridden per repo
12#snapshots=0 12#snapshots=0
13 13
14 14
15## Enable/disable extra links to summary/log/tree per repo on index page
16#enable-index-links=0
17
18
15## Enable/disable display of 'number of files changed' in log view 19## Enable/disable display of 'number of files changed' in log view
16#enable-log-filecount=0 20#enable-log-filecount=0
17 21
18 22
19## Enable/disable display of 'number of lines changed' in log view 23## Enable/disable display of 'number of lines changed' in log view
20#enable-log-linecount=0 24#enable-log-linecount=0
21 25
22 26
23## Enable/disable display of HEAD shortlog in summary view. Set it to maximum 27## Enable/disable display of HEAD shortlog in summary view. Set it to maximum
24## number of commits that should be displayed 28## number of commits that should be displayed
25#summary-log=0 29#summary-log=0
26 30
diff --git a/shared.c b/shared.c
index f20fb5c..ab00bc9 100644
--- a/shared.c
+++ b/shared.c
@@ -17,24 +17,25 @@ char *cgit_css = "/cgit.css";
17char *cgit_logo = "/git-logo.png"; 17char *cgit_logo = "/git-logo.png";
18char *cgit_index_header = NULL; 18char *cgit_index_header = NULL;
19char *cgit_logo_link = "http://www.kernel.org/pub/software/scm/git/docs/"; 19char *cgit_logo_link = "http://www.kernel.org/pub/software/scm/git/docs/";
20char *cgit_module_link = "./?repo=%s&page=commit&id=%s"; 20char *cgit_module_link = "./?repo=%s&page=commit&id=%s";
21char *cgit_agefile = "info/web/last-modified"; 21char *cgit_agefile = "info/web/last-modified";
22char *cgit_virtual_root = NULL; 22char *cgit_virtual_root = NULL;
23char *cgit_script_name = CGIT_SCRIPT_NAME; 23char *cgit_script_name = CGIT_SCRIPT_NAME;
24char *cgit_cache_root = "/var/cache/cgit"; 24char *cgit_cache_root = "/var/cache/cgit";
25char *cgit_repo_group = NULL; 25char *cgit_repo_group = NULL;
26 26
27int cgit_nocache = 0; 27int cgit_nocache = 0;
28int cgit_snapshots = 0; 28int cgit_snapshots = 0;
29int cgit_enable_index_links = 0;
29int cgit_enable_log_filecount = 0; 30int cgit_enable_log_filecount = 0;
30int cgit_enable_log_linecount = 0; 31int cgit_enable_log_linecount = 0;
31int cgit_max_lock_attempts = 5; 32int cgit_max_lock_attempts = 5;
32int cgit_cache_root_ttl = 5; 33int cgit_cache_root_ttl = 5;
33int cgit_cache_repo_ttl = 5; 34int cgit_cache_repo_ttl = 5;
34int cgit_cache_dynamic_ttl = 5; 35int cgit_cache_dynamic_ttl = 5;
35int cgit_cache_static_ttl = -1; 36int cgit_cache_static_ttl = -1;
36int cgit_cache_max_create_time = 5; 37int cgit_cache_max_create_time = 5;
37int cgit_summary_log = 0; 38int cgit_summary_log = 0;
38 39
39int cgit_max_msg_len = 60; 40int cgit_max_msg_len = 60;
40int cgit_max_repodesc_len = 60; 41int cgit_max_repodesc_len = 60;
@@ -137,24 +138,26 @@ void cgit_global_config_cb(const char *name, const char *value)
137 else if (!strcmp(name, "index-header")) 138 else if (!strcmp(name, "index-header"))
138 cgit_index_header = xstrdup(value); 139 cgit_index_header = xstrdup(value);
139 else if (!strcmp(name, "logo-link")) 140 else if (!strcmp(name, "logo-link"))
140 cgit_logo_link = xstrdup(value); 141 cgit_logo_link = xstrdup(value);
141 else if (!strcmp(name, "module-link")) 142 else if (!strcmp(name, "module-link"))
142 cgit_module_link = xstrdup(value); 143 cgit_module_link = xstrdup(value);
143 else if (!strcmp(name, "virtual-root")) 144 else if (!strcmp(name, "virtual-root"))
144 cgit_virtual_root = xstrdup(value); 145 cgit_virtual_root = xstrdup(value);
145 else if (!strcmp(name, "nocache")) 146 else if (!strcmp(name, "nocache"))
146 cgit_nocache = atoi(value); 147 cgit_nocache = atoi(value);
147 else if (!strcmp(name, "snapshots")) 148 else if (!strcmp(name, "snapshots"))
148 cgit_snapshots = atoi(value); 149 cgit_snapshots = atoi(value);
150 else if (!strcmp(name, "enable-index-links"))
151 cgit_enable_index_links = atoi(value);
149 else if (!strcmp(name, "enable-log-filecount")) 152 else if (!strcmp(name, "enable-log-filecount"))
150 cgit_enable_log_filecount = atoi(value); 153 cgit_enable_log_filecount = atoi(value);
151 else if (!strcmp(name, "enable-log-linecount")) 154 else if (!strcmp(name, "enable-log-linecount"))
152 cgit_enable_log_linecount = atoi(value); 155 cgit_enable_log_linecount = atoi(value);
153 else if (!strcmp(name, "cache-root")) 156 else if (!strcmp(name, "cache-root"))
154 cgit_cache_root = xstrdup(value); 157 cgit_cache_root = xstrdup(value);
155 else if (!strcmp(name, "cache-root-ttl")) 158 else if (!strcmp(name, "cache-root-ttl"))
156 cgit_cache_root_ttl = atoi(value); 159 cgit_cache_root_ttl = atoi(value);
157 else if (!strcmp(name, "cache-repo-ttl")) 160 else if (!strcmp(name, "cache-repo-ttl"))
158 cgit_cache_repo_ttl = atoi(value); 161 cgit_cache_repo_ttl = atoi(value);
159 else if (!strcmp(name, "cache-static-ttl")) 162 else if (!strcmp(name, "cache-static-ttl"))
160 cgit_cache_static_ttl = atoi(value); 163 cgit_cache_static_ttl = atoi(value);
diff --git a/ui-repolist.c b/ui-repolist.c
index 4f820a8..c735368 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -35,64 +35,75 @@ static void print_modtime(struct repoinfo *repo)
35 cgit_print_age(read_agefile(path), -1, NULL); 35 cgit_print_age(read_agefile(path), -1, NULL);
36 return; 36 return;
37 } 37 }
38 38
39 path = fmt("%s/refs/heads/%s", repo->path, repo->defbranch); 39 path = fmt("%s/refs/heads/%s", repo->path, repo->defbranch);
40 if (stat(path, &s) != 0) 40 if (stat(path, &s) != 0)
41 return; 41 return;
42 cgit_print_age(s.st_mtime, -1, NULL); 42 cgit_print_age(s.st_mtime, -1, NULL);
43} 43}
44 44
45void cgit_print_repolist(struct cacheitem *item) 45void cgit_print_repolist(struct cacheitem *item)
46{ 46{
47 int i; 47 int i, columns = 4;
48 char *last_group = NULL; 48 char *last_group = NULL;
49 49
50 if (cgit_enable_index_links)
51 columns++;
52
50 cgit_print_docstart(cgit_root_title, item); 53 cgit_print_docstart(cgit_root_title, item);
51 cgit_print_pageheader(cgit_root_title, 0); 54 cgit_print_pageheader(cgit_root_title, 0);
52 55
53 html("<table class='list nowrap'>"); 56 html("<table class='list nowrap'>");
54 if (cgit_index_header) { 57 if (cgit_index_header) {
55 html("<tr class='nohover'><td colspan='5' class='include-block'>"); 58 htmlf("<tr class='nohover'><td colspan='%d' class='include-block'>",
59 columns);
56 html_include(cgit_index_header); 60 html_include(cgit_index_header);
57 html("</td></tr>"); 61 html("</td></tr>");
58 } 62 }
59 html("<tr class='nohover'>" 63 html("<tr class='nohover'>"
60 "<th class='left'>Name</th>" 64 "<th class='left'>Name</th>"
61 "<th class='left'>Description</th>" 65 "<th class='left'>Description</th>"
62 "<th class='left'>Owner</th>" 66 "<th class='left'>Owner</th>"
63 "<th class='left'>Idle</th>" 67 "<th class='left'>Idle</th>");
64 "<th>Links</th></tr>\n"); 68 if (cgit_enable_index_links)
69 html("<th>Links</th>");
70 html("</tr>\n");
65 71
66 for (i=0; i<cgit_repolist.count; i++) { 72 for (i=0; i<cgit_repolist.count; i++) {
67 cgit_repo = &cgit_repolist.repos[i]; 73 cgit_repo = &cgit_repolist.repos[i];
68 if ((last_group == NULL && cgit_repo->group != NULL) || 74 if ((last_group == NULL && cgit_repo->group != NULL) ||
69 (last_group != NULL && cgit_repo->group == NULL) || 75 (last_group != NULL && cgit_repo->group == NULL) ||
70 (last_group != NULL && cgit_repo->group != NULL && 76 (last_group != NULL && cgit_repo->group != NULL &&
71 strcmp(cgit_repo->group, last_group))) { 77 strcmp(cgit_repo->group, last_group))) {
72 html("<tr class='nohover'><td colspan='4' class='repogroup'>"); 78 htmlf("<tr class='nohover'><td colspan='%d' class='repogroup'>",
79 columns);
73 html_txt(cgit_repo->group); 80 html_txt(cgit_repo->group);
74 html("</td></tr>"); 81 html("</td></tr>");
75 last_group = cgit_repo->group; 82 last_group = cgit_repo->group;
76 } 83 }
77 htmlf("<tr><td class='%s'>", 84 htmlf("<tr><td class='%s'>",
78 cgit_repo->group ? "sublevel-repo" : "toplevel-repo"); 85 cgit_repo->group ? "sublevel-repo" : "toplevel-repo");
79 html_link_open(cgit_repourl(cgit_repo->url), NULL, NULL); 86 html_link_open(cgit_repourl(cgit_repo->url), NULL, NULL);
80 html_txt(cgit_repo->name); 87 html_txt(cgit_repo->name);
81 html_link_close(); 88 html_link_close();
82 html("</td><td>"); 89 html("</td><td>");
83 html_ntxt(cgit_max_repodesc_len, cgit_repo->desc); 90 html_ntxt(cgit_max_repodesc_len, cgit_repo->desc);
84 html("</td><td>"); 91 html("</td><td>");
85 html_txt(cgit_repo->owner); 92 html_txt(cgit_repo->owner);
86 html("</td><td>"); 93 html("</td><td>");
87 print_modtime(cgit_repo); 94 print_modtime(cgit_repo);
88 html("</td><td>"); 95 html("</td>");
96 if (cgit_enable_index_links) {
97 html("<td>");
89 html_link_open(cgit_repourl(cgit_repo->url), 98 html_link_open(cgit_repourl(cgit_repo->url),
90 NULL, "button"); 99 NULL, "button");
91 html("summary</a>"); 100 html("summary</a>");
92 cgit_log_link("log", NULL, "button", NULL, NULL, NULL); 101 cgit_log_link("log", NULL, "button", NULL, NULL, NULL);
93 cgit_tree_link("tree", NULL, "button", NULL, NULL, NULL); 102 cgit_tree_link("tree", NULL, "button", NULL, NULL, NULL);
94 html("</td></tr>\n"); 103 html("</td>");
104 }
105 html("</tr>\n");
95 } 106 }
96 html("</table>"); 107 html("</table>");
97 cgit_print_docend(); 108 cgit_print_docend();
98} 109}