author | Lars Hjemli <hjemli@gmail.com> | 2007-05-18 01:54:15 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-05-18 20:51:02 (UTC) |
commit | 72fa5c63f80262019d807658cc537c9897c4b1d1 (patch) (side-by-side diff) | |
tree | dd10f33b94e95574a145ddd7e82b22356039f3a0 | |
parent | 30ccdcaa74ebc0aab2b7843b0db8251d0ddf56de (diff) | |
download | cgit-72fa5c63f80262019d807658cc537c9897c4b1d1.zip cgit-72fa5c63f80262019d807658cc537c9897c4b1d1.tar.gz cgit-72fa5c63f80262019d807658cc537c9897c4b1d1.tar.bz2 |
cache_safe_filename() needs more buffers
The single static buffer makes it impossible to use the result of two
different calls to this function simultaneously. Fix it by using 4
buffers.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | cache.c | 11 |
1 files changed, 8 insertions, 3 deletions
@@ -3,36 +3,41 @@ * Copyright (C) 2006 Lars Hjemli * * Licensed under GNU General Public License v2 * (see COPYING for full license text) */ #include "cgit.h" const int NOLOCK = -1; char *cache_safe_filename(const char *unsafe) { - static char buf[PATH_MAX]; - char *s = buf; + static char buf[4][PATH_MAX]; + static int bufidx; + char *s; char c; + bufidx++; + bufidx &= 3; + s = buf[bufidx]; + while(unsafe && (c = *unsafe++) != 0) { if (c == '/' || c == ' ' || c == '&' || c == '|' || c == '>' || c == '<' || c == '.') c = '_'; *s++ = c; } *s = '\0'; - return buf; + return buf[bufidx]; } int cache_exist(struct cacheitem *item) { if (stat(item->name, &item->st)) { item->st.st_mtime = 0; return 0; } return 1; } int cache_create_dirs() |