author | Lars Hjemli <hjemli@gmail.com> | 2007-12-18 08:26:50 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2008-01-10 11:50:12 (UTC) |
commit | f39c3c99a12154cdafcdc501a821e3fadd3c0602 (patch) (side-by-side diff) | |
tree | afd672cf704388099510977fe4882dabb66f7463 | |
parent | f80ff37a1706e6774ca21a3ce1fceeb17f89a37a (diff) | |
download | cgit-f39c3c99a12154cdafcdc501a821e3fadd3c0602.zip cgit-f39c3c99a12154cdafcdc501a821e3fadd3c0602.tar.gz cgit-f39c3c99a12154cdafcdc501a821e3fadd3c0602.tar.bz2 |
Check for NULL-subject in patch view
While at it, make sure the commit message ends with a '\n'.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-patch.c | 7 |
1 files changed, 6 insertions, 1 deletions
@@ -87,19 +87,24 @@ void cgit_print_patch(char *hex, struct cacheitem *item) cgit_print_error(fmt("Bad commit reference: %s", hex)); return; } info = cgit_parse_commit(commit); hashcpy(old_sha1, commit->parents->item->object.sha1); patchname = fmt("%s.patch", sha1_to_hex(sha1)); cgit_print_snapshot_start("text/plain", patchname, item); htmlf("From %s Mon Sep 17 00:00:00 2001\n", sha1_to_hex(sha1)); htmlf("From: %s%s\n", info->author, info->author_email); html("Date: "); cgit_print_date(info->author_date, "%a, %d %b %Y %H:%M:%S %z%n"); - htmlf("Subject: %s\n\n%s", info->subject, info->msg); + htmlf("Subject: %s\n\n", info->subject); + if (info->msg && *info->msg) { + htmlf("%s", info->msg); + if (info->msg[strlen(info->msg) - 1] != '\n') + html("\n"); + } html("---\n"); cgit_diff_tree(old_sha1, sha1, filepair_cb, NULL); html("--\n"); htmlf("cgit %s\n", CGIT_VERSION); cgit_free_commitinfo(info); } |