summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2007-12-18 08:26:50 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2008-01-10 11:50:12 (UTC)
commitf39c3c99a12154cdafcdc501a821e3fadd3c0602 (patch) (unidiff)
treeafd672cf704388099510977fe4882dabb66f7463
parentf80ff37a1706e6774ca21a3ce1fceeb17f89a37a (diff)
downloadcgit-f39c3c99a12154cdafcdc501a821e3fadd3c0602.zip
cgit-f39c3c99a12154cdafcdc501a821e3fadd3c0602.tar.gz
cgit-f39c3c99a12154cdafcdc501a821e3fadd3c0602.tar.bz2
Check for NULL-subject in patch view
While at it, make sure the commit message ends with a '\n'. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--ui-patch.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/ui-patch.c b/ui-patch.c
index ef79c7c..e7a010a 100644
--- a/ui-patch.c
+++ b/ui-patch.c
@@ -87,19 +87,24 @@ void cgit_print_patch(char *hex, struct cacheitem *item)
87 cgit_print_error(fmt("Bad commit reference: %s", hex)); 87 cgit_print_error(fmt("Bad commit reference: %s", hex));
88 return; 88 return;
89 } 89 }
90 info = cgit_parse_commit(commit); 90 info = cgit_parse_commit(commit);
91 hashcpy(old_sha1, commit->parents->item->object.sha1); 91 hashcpy(old_sha1, commit->parents->item->object.sha1);
92 92
93 patchname = fmt("%s.patch", sha1_to_hex(sha1)); 93 patchname = fmt("%s.patch", sha1_to_hex(sha1));
94 cgit_print_snapshot_start("text/plain", patchname, item); 94 cgit_print_snapshot_start("text/plain", patchname, item);
95 htmlf("From %s Mon Sep 17 00:00:00 2001\n", sha1_to_hex(sha1)); 95 htmlf("From %s Mon Sep 17 00:00:00 2001\n", sha1_to_hex(sha1));
96 htmlf("From: %s%s\n", info->author, info->author_email); 96 htmlf("From: %s%s\n", info->author, info->author_email);
97 html("Date: "); 97 html("Date: ");
98 cgit_print_date(info->author_date, "%a, %d %b %Y %H:%M:%S %z%n"); 98 cgit_print_date(info->author_date, "%a, %d %b %Y %H:%M:%S %z%n");
99 htmlf("Subject: %s\n\n%s", info->subject, info->msg); 99 htmlf("Subject: %s\n\n", info->subject);
100 if (info->msg && *info->msg) {
101 htmlf("%s", info->msg);
102 if (info->msg[strlen(info->msg) - 1] != '\n')
103 html("\n");
104 }
100 html("---\n"); 105 html("---\n");
101 cgit_diff_tree(old_sha1, sha1, filepair_cb, NULL); 106 cgit_diff_tree(old_sha1, sha1, filepair_cb, NULL);
102 html("--\n"); 107 html("--\n");
103 htmlf("cgit %s\n", CGIT_VERSION); 108 htmlf("cgit %s\n", CGIT_VERSION);
104 cgit_free_commitinfo(info); 109 cgit_free_commitinfo(info);
105} 110}