summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2008-09-23 15:54:45 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2008-09-23 15:54:45 (UTC)
commitf82b19407dd876e6c02a572615bf34b09f6fa831 (patch) (unidiff)
tree9b08ab9bfc821f4fc2d53be62f338083e93d4ca1
parent04619c9b8512921a87187b9adf8573e2bdacd0a6 (diff)
downloadcgit-f82b19407dd876e6c02a572615bf34b09f6fa831.zip
cgit-f82b19407dd876e6c02a572615bf34b09f6fa831.tar.gz
cgit-f82b19407dd876e6c02a572615bf34b09f6fa831.tar.bz2
ui-diff: make diffstat header a link to the full diff
When printing a path-filtered diff it wasn't obvious how to get back to the full diff (clicking the 'diff' tab would do this). Making the diffstat heading into a link seems to improve the usability. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--ui-diff.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/ui-diff.c b/ui-diff.c
index 7ab1e49..878496d 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -132,25 +132,28 @@ static void inspect_filepair(struct diff_filepair *pair)
132 items[files-1].removed = lines_removed; 132 items[files-1].removed = lines_removed;
133 if (lines_added + lines_removed > max_changes) 133 if (lines_added + lines_removed > max_changes)
134 max_changes = lines_added + lines_removed; 134 max_changes = lines_added + lines_removed;
135 total_adds += lines_added; 135 total_adds += lines_added;
136 total_rems += lines_removed; 136 total_rems += lines_removed;
137} 137}
138 138
139void cgit_print_diffstat(const unsigned char *old_sha1, 139void cgit_print_diffstat(const unsigned char *old_sha1,
140 const unsigned char *new_sha1) 140 const unsigned char *new_sha1)
141{ 141{
142 int i; 142 int i;
143 143
144 html("<div class='diffstat-header'>Diffstat</div>"); 144 html("<div class='diffstat-header'>");
145 cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1,
146 ctx.qry.sha2, NULL);
147 html("</div>");
145 html("<table summary='diffstat' class='diffstat'>"); 148 html("<table summary='diffstat' class='diffstat'>");
146 max_changes = 0; 149 max_changes = 0;
147 cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, NULL); 150 cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, NULL);
148 for(i = 0; i<files; i++) 151 for(i = 0; i<files; i++)
149 print_fileinfo(&items[i]); 152 print_fileinfo(&items[i]);
150 html("</table>"); 153 html("</table>");
151 html("<div class='diffstat-summary'>"); 154 html("<div class='diffstat-summary'>");
152 htmlf("%d files changed, %d insertions, %d deletions", 155 htmlf("%d files changed, %d insertions, %d deletions",
153 files, total_adds, total_rems); 156 files, total_adds, total_rems);
154 html("</div>"); 157 html("</div>");
155} 158}
156 159