author | Ondrej Jirman <ondrej.jirman@zonio.net> | 2007-05-26 01:27:49 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2007-05-31 08:24:43 (UTC) |
commit | 6130231ed5e7475836a44d79d5f09e300e71a407 (patch) (side-by-side diff) | |
tree | 9fc492315a0e9f23f1e8b0fba2420c2626a82152 | |
parent | a922615dae5d1f7b932dd1fc5a5f121748d96c5a (diff) | |
download | cgit-6130231ed5e7475836a44d79d5f09e300e71a407.zip cgit-6130231ed5e7475836a44d79d5f09e300e71a407.tar.gz cgit-6130231ed5e7475836a44d79d5f09e300e71a407.tar.bz2 |
Check for NULL commit buffer in cgit_parse_commit()
This can be NULL, so try not to segfault.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | parsing.c | 3 |
1 files changed, 3 insertions, 0 deletions
@@ -187,32 +187,35 @@ char *substr(const char *head, const char *tail) } struct commitinfo *cgit_parse_commit(struct commit *commit) { struct commitinfo *ret; char *p = commit->buffer, *t = commit->buffer; ret = xmalloc(sizeof(*ret)); ret->commit = commit; ret->author = NULL; ret->author_email = NULL; ret->committer = NULL; ret->committer_email = NULL; ret->subject = NULL; ret->msg = NULL; + if (p == NULL) + return ret; + if (strncmp(p, "tree ", 5)) die("Bad commit: %s", sha1_to_hex(commit->object.sha1)); else p += 46; // "tree " + hex[40] + "\n" while (!strncmp(p, "parent ", 7)) p += 48; // "parent " + hex[40] + "\n" if (!strncmp(p, "author ", 7)) { p += 7; t = strchr(p, '<') - 1; ret->author = substr(p, t); p = t; t = strchr(t, '>') + 1; ret->author_email = substr(p, t); ret->author_date = atol(++t); |