summaryrefslogtreecommitdiffabout
authorMark Lodato <lodatom@gmail.com>2010-02-09 04:04:41 (UTC)
committer Mark Lodato <lodatom@gmail.com>2010-02-09 04:04:41 (UTC)
commit8aab27f24de70acfbdcee31c634a4b1facf23b92 (patch) (unidiff)
tree10e5f83a5f0c2a286ec2d1feecf6732f863c9a47
parent547a64fbd65de293c290f4e18bbeae958d54aaa7 (diff)
downloadcgit-8aab27f24de70acfbdcee31c634a4b1facf23b92.zip
cgit-8aab27f24de70acfbdcee31c634a4b1facf23b92.tar.gz
cgit-8aab27f24de70acfbdcee31c634a4b1facf23b92.tar.bz2
html: make all strings 'const char *'
None of the html_* functions modify their argument, so they can all be 'const char *' instead of a simple 'char *'. This removes the need to cast (or copy) when trying to print a const string. Signed-off-by: Mark Lodato <lodatom@gmail.com>
Diffstat (more/less context) (show whitespace changes)
-rw-r--r--html.c34
-rw-r--r--html.h18
2 files changed, 26 insertions, 26 deletions
diff --git a/html.c b/html.c
index 66ba65d..4033200 100644
--- a/html.c
+++ b/html.c
@@ -64,7 +64,7 @@ void html_status(int code, const char *msg, int more_headers)
64} 64}
65 65
66void html_txt(char *txt) 66void html_txt(const char *txt)
67{ 67{
68 char *t = txt; 68 const char *t = txt;
69 while(t && *t){ 69 while(t && *t){
70 int c = *t; 70 int c = *t;
@@ -85,7 +85,7 @@ void html_txt(char *txt)
85} 85}
86 86
87void html_ntxt(int len, char *txt) 87void html_ntxt(int len, const char *txt)
88{ 88{
89 char *t = txt; 89 const char *t = txt;
90 while(t && *t && len--){ 90 while(t && *t && len--){
91 int c = *t; 91 int c = *t;
@@ -108,7 +108,7 @@ void html_ntxt(int len, char *txt)
108} 108}
109 109
110void html_attr(char *txt) 110void html_attr(const char *txt)
111{ 111{
112 char *t = txt; 112 const char *t = txt;
113 while(t && *t){ 113 while(t && *t){
114 int c = *t; 114 int c = *t;
@@ -131,7 +131,7 @@ void html_attr(char *txt)
131} 131}
132 132
133void html_url_path(char *txt) 133void html_url_path(const char *txt)
134{ 134{
135 char *t = txt; 135 const char *t = txt;
136 while(t && *t){ 136 while(t && *t){
137 int c = *t; 137 int c = *t;
@@ -147,7 +147,7 @@ void html_url_path(char *txt)
147} 147}
148 148
149void html_url_arg(char *txt) 149void html_url_arg(const char *txt)
150{ 150{
151 char *t = txt; 151 const char *t = txt;
152 while(t && *t){ 152 while(t && *t){
153 int c = *t; 153 int c = *t;
@@ -163,5 +163,5 @@ void html_url_arg(char *txt)
163} 163}
164 164
165void html_hidden(char *name, char *value) 165void html_hidden(const char *name, const char *value)
166{ 166{
167 html("<input type='hidden' name='"); 167 html("<input type='hidden' name='");
@@ -172,5 +172,5 @@ void html_hidden(char *name, char *value)
172} 172}
173 173
174void html_option(char *value, char *text, char *selected_value) 174void html_option(const char *value, const char *text, const char *selected_value)
175{ 175{
176 html("<option value='"); 176 html("<option value='");
@@ -184,5 +184,5 @@ void html_option(char *value, char *text, char *selected_value)
184} 184}
185 185
186void html_link_open(char *url, char *title, char *class) 186void html_link_open(const char *url, const char *title, const char *class)
187{ 187{
188 html("<a href='"); 188 html("<a href='");
@@ -258,12 +258,12 @@ char *convert_query_hexchar(char *txt)
258} 258}
259 259
260int http_parse_querystring(char *txt, void (*fn)(const char *name, const char *value)) 260int http_parse_querystring(const char *txt_, void (*fn)(const char *name, const char *value))
261{ 261{
262 char *t, *value = NULL, c; 262 char *t, *txt, *value = NULL, c;
263 263
264 if (!txt) 264 if (!txt_)
265 return 0; 265 return 0;
266 266
267 t = txt = strdup(txt); 267 t = txt = strdup(txt_);
268 if (t == NULL) { 268 if (t == NULL) {
269 printf("Out of memory\n"); 269 printf("Out of memory\n");
diff --git a/html.h b/html.h
index a55d4b2..16d55ec 100644
--- a/html.h
+++ b/html.h
@@ -8,17 +8,17 @@ extern void html(const char *txt);
8extern void htmlf(const char *format,...); 8extern void htmlf(const char *format,...);
9extern void html_status(int code, const char *msg, int more_headers); 9extern void html_status(int code, const char *msg, int more_headers);
10extern void html_txt(char *txt); 10extern void html_txt(const char *txt);
11extern void html_ntxt(int len, char *txt); 11extern void html_ntxt(int len, const char *txt);
12extern void html_attr(char *txt); 12extern void html_attr(const char *txt);
13extern void html_url_path(char *txt); 13extern void html_url_path(const char *txt);
14extern void html_url_arg(char *txt); 14extern void html_url_arg(const char *txt);
15extern void html_hidden(char *name, char *value); 15extern void html_hidden(const char *name, const char *value);
16extern void html_option(char *value, char *text, char *selected_value); 16extern void html_option(const char *value, const char *text, const char *selected_value);
17extern void html_link_open(char *url, char *title, char *class); 17extern void html_link_open(const char *url, const char *title, const char *class);
18extern void html_link_close(void); 18extern void html_link_close(void);
19extern void html_fileperm(unsigned short mode); 19extern void html_fileperm(unsigned short mode);
20extern int html_include(const char *filename); 20extern int html_include(const char *filename);
21 21
22extern int http_parse_querystring(char *txt, void (*fn)(const char *name, const char *value)); 22extern int http_parse_querystring(const char *txt, void (*fn)(const char *name, const char *value));
23 23
24#endif /* HTML_H */ 24#endif /* HTML_H */