Cleanup page header

Fix some invalid html, remove dead code.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>

1 files changed, 4 insertions, 17 deletions

diff --git a/ui-shared.c b/ui-shared.c
index bb08c4a..8a804c2 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -463,90 +463,77 @@ void add_hidden_formfields(int incl_head, int incl_search, char *page)
                         html_hidden("qt", ctx.qry.grep);
                 if (ctx.qry.search)
                         html_hidden("q", ctx.qry.search);
         }
 }
 
 char *hc(struct cgit_cmd *cmd, const char *page)
 {
         return (strcmp(cmd->name, page) ? NULL : "active");
 }
 
 void cgit_print_pageheader(struct cgit_context *ctx)
 {
         struct cgit_cmd *cmd = cgit_get_cmd(ctx);
 
         html("<table id='header'>\n");
         html("<tr>\n");
         html("<td class='logo' rowspan='2'><a href='");
         if (ctx->cfg.logo_link)
                 html_attr(ctx->cfg.logo_link);
         else
                 html_attr(cgit_rooturl());
         html("'><img src='");
         html_attr(ctx->cfg.logo);
-        html("'/></a></td>\n");
+        html("' alt='cgit logo'/></a></td>\n");
 
         html("<td class='main'>");
         if (ctx->repo) {
-/*
-                html("<a href='");
-                html_attr(cgit_rooturl());
-                html("'>index</a> : ");
-*/
                 reporevlink(NULL, ctx->repo->name, NULL, hc(cmd, "summary"),
                             ctx->qry.head, NULL, NULL);
                 html(" : ");
                 html_txt(ctx->qry.page);
                 html("</td><td class='form'>");
                 html("<form method='get' action=''>\n");
                 add_hidden_formfields(0, 1, ctx->qry.page);
                 html("<select name='h' onchange='this.form.submit();'>\n");
                 for_each_branch_ref(print_branch_option, ctx->qry.head);
                 html("</select> ");
                 html("<input type='submit' name='' value='switch'/>");
                 html("</form>");
         } else
                 html_txt(ctx->cfg.root_title);
-        html("</td>\n");
+        html("</td></tr>\n");
 
         html("<tr><td class='sub'");
         if (ctx->repo) {
                 html(" colspan='2'>");
                 html_txt(ctx->repo->desc);
-        }
-/*
-        else if (ctx->cfg.root_subtitle)
-                html_txt(ctx->cfg.root_subtitle);
-*/
-        else {
+        } else {
                 html(">");
                 html_txt("a fast webinterface for the git dscm");
         }
-        html("</td></tr>\n");
-
-        html("</tr>\n");
-        html("</table>\n");
+        html("</td></tr></table>\n");
 
         html("<table class='tabs'><tr><td>\n");
         if (ctx->repo) {
                 reporevlink(NULL, "summary", NULL, hc(cmd, "summary"),
                             ctx->qry.head, NULL, NULL);
                 cgit_refs_link("refs", NULL, hc(cmd, "refs"), ctx->qry.head,
                                ctx->qry.sha1, NULL);
                 cgit_log_link("log", NULL, hc(cmd, "log"), ctx->qry.head,
                               NULL, NULL, 0, NULL, NULL);
                 cgit_tree_link("tree", NULL, hc(cmd, "tree"), ctx->qry.head,
                                ctx->qry.sha1, NULL);
                 cgit_commit_link("commit", NULL, hc(cmd, "commit"),
                                  ctx->qry.head, ctx->qry.sha1);
                 cgit_diff_link("diff", NULL, hc(cmd, "diff"), ctx->qry.head,
                                ctx->qry.sha1, ctx->qry.sha2, NULL);
                 html("</td><td class='form'>");
                 html("<form class='right' method='get' action='");
                 if (ctx->cfg.virtual_root)
                         html_attr(cgit_fileurl(ctx->qry.repo, "log",
                                                ctx->qry.path, NULL));
                 html("'>\n");
                 add_hidden_formfields(1, 0, "log");
                 html("<select name='qt'>\n");
                 html_option("grep", "log msg", ctx->qry.grep);