summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2008-04-17 16:29:50 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2008-04-17 16:33:33 (UTC)
commit9ec5cd7944a7099515b7d41107007d6332a2540e (patch) (unidiff)
tree3d3284c73a72e7122cde02b0eb7ff1f4d8cd1a0d
parent3cfcb086abfc2e94426623b487a47a8b5cc57b7e (diff)
downloadcgit-9ec5cd7944a7099515b7d41107007d6332a2540e.zip
cgit-9ec5cd7944a7099515b7d41107007d6332a2540e.tar.gz
cgit-9ec5cd7944a7099515b7d41107007d6332a2540e.tar.bz2
Fix commitdiff annoyance
Someone were a bit sloppy when the commitdiff got included 'inline' in commit 89aa3c0d0a4c6d9885272602005975b763ea1604. This patch deletes a stray `)` and makes sure the diffstat summary `<div>` is closed before the full diff is printed. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--ui-commit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ui-commit.c b/ui-commit.c
index dd36cc0..12a96fb 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -206,31 +206,31 @@ void cgit_print_commit(char *hex)
206 if (ctx.repo->snapshots) { 206 if (ctx.repo->snapshots) {
207 html("<tr><th>download</th><td colspan='2' class='sha1'>"); 207 html("<tr><th>download</th><td colspan='2' class='sha1'>");
208 cgit_print_snapshot_links(ctx.qry.repo, ctx.qry.head, 208 cgit_print_snapshot_links(ctx.qry.repo, ctx.qry.head,
209 hex, ctx.repo->snapshots); 209 hex, ctx.repo->snapshots);
210 html("</td></tr>"); 210 html("</td></tr>");
211 } 211 }
212 html("</table>\n"); 212 html("</table>\n");
213 html("<div class='commit-subject'>"); 213 html("<div class='commit-subject'>");
214 html_txt(info->subject); 214 html_txt(info->subject);
215 html("</div>"); 215 html("</div>");
216 html("<div class='commit-msg'>"); 216 html("<div class='commit-msg'>");
217 html_txt(info->msg); 217 html_txt(info->msg);
218 html("</div>"); 218 html("</div>");
219 if (!(commit->parents && commit->parents->next && commit->parents->next->next)) { 219 if (!(commit->parents && commit->parents->next && commit->parents->next->next)) {
220 html("<div class='diffstat-header'>Diffstat</div>"); 220 html("<div class='diffstat-header'>Diffstat</div>");
221 html("<table summary='diffstat' class='diffstat'>"); 221 html("<table summary='diffstat' class='diffstat'>");
222 max_changes = 0; 222 max_changes = 0;
223 cgit_diff_commit(commit, inspect_filepair); 223 cgit_diff_commit(commit, inspect_filepair);
224 for(i = 0; i<files; i++) 224 for(i = 0; i<files; i++)
225 print_fileinfo(&items[i]); 225 print_fileinfo(&items[i]);
226 html("</table>"); 226 html("</table>");
227 html("<div class='diffstat-summary'>"); 227 html("<div class='diffstat-summary'>");
228 htmlf("%d files changed, %d insertions, %d deletions", 228 htmlf("%d files changed, %d insertions, %d deletions",
229 files, total_adds, total_rems); 229 files, total_adds, total_rems);
230 html("</div>");
230 cgit_print_diff(ctx.qry.sha1, 231 cgit_print_diff(ctx.qry.sha1,
231 sha1_to_hex(commit->parents->item->object.sha1), 232 sha1_to_hex(commit->parents->item->object.sha1),
232 NULL); 233 NULL);
233 html(")</div>");
234 } 234 }
235 cgit_free_commitinfo(info); 235 cgit_free_commitinfo(info);
236} 236}