author | Johan Herland <johan@herland.net> | 2010-06-09 23:09:31 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2010-06-19 08:40:23 (UTC) |
commit | c46e468dd229d5a20d99801072b4a8f8d970104f (patch) (unidiff) | |
tree | c75f13ee117732ff4a41d8ec05a14e52f5117691 | |
parent | 48f7b982d3bb52f1307df73ceb6dd4cab3fdcc80 (diff) | |
download | cgit-c46e468dd229d5a20d99801072b4a8f8d970104f.zip cgit-c46e468dd229d5a20d99801072b4a8f8d970104f.tar.gz cgit-c46e468dd229d5a20d99801072b4a8f8d970104f.tar.bz2 |
ui-diff: Teach diffstat to obey path limit
Also indicate in the diffstat header if a path limit is in effect.
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-diff.c | 8 |
1 files changed, 5 insertions, 3 deletions
@@ -133,59 +133,61 @@ static void inspect_filepair(struct diff_filepair *pair) | |||
133 | slots = 4; | 133 | slots = 4; |
134 | else | 134 | else |
135 | slots = slots * 2; | 135 | slots = slots * 2; |
136 | items = xrealloc(items, slots * sizeof(struct fileinfo)); | 136 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
137 | } | 137 | } |
138 | items[files-1].status = pair->status; | 138 | items[files-1].status = pair->status; |
139 | hashcpy(items[files-1].old_sha1, pair->one->sha1); | 139 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
140 | hashcpy(items[files-1].new_sha1, pair->two->sha1); | 140 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
141 | items[files-1].old_mode = pair->one->mode; | 141 | items[files-1].old_mode = pair->one->mode; |
142 | items[files-1].new_mode = pair->two->mode; | 142 | items[files-1].new_mode = pair->two->mode; |
143 | items[files-1].old_path = xstrdup(pair->one->path); | 143 | items[files-1].old_path = xstrdup(pair->one->path); |
144 | items[files-1].new_path = xstrdup(pair->two->path); | 144 | items[files-1].new_path = xstrdup(pair->two->path); |
145 | items[files-1].added = lines_added; | 145 | items[files-1].added = lines_added; |
146 | items[files-1].removed = lines_removed; | 146 | items[files-1].removed = lines_removed; |
147 | items[files-1].old_size = old_size; | 147 | items[files-1].old_size = old_size; |
148 | items[files-1].new_size = new_size; | 148 | items[files-1].new_size = new_size; |
149 | items[files-1].binary = binary; | 149 | items[files-1].binary = binary; |
150 | if (lines_added + lines_removed > max_changes) | 150 | if (lines_added + lines_removed > max_changes) |
151 | max_changes = lines_added + lines_removed; | 151 | max_changes = lines_added + lines_removed; |
152 | total_adds += lines_added; | 152 | total_adds += lines_added; |
153 | total_rems += lines_removed; | 153 | total_rems += lines_removed; |
154 | } | 154 | } |
155 | 155 | ||
156 | void cgit_print_diffstat(const unsigned char *old_sha1, | 156 | void cgit_print_diffstat(const unsigned char *old_sha1, |
157 | const unsigned char *new_sha1) | 157 | const unsigned char *new_sha1, const char *prefix) |
158 | { | 158 | { |
159 | int i; | 159 | int i; |
160 | 160 | ||
161 | html("<div class='diffstat-header'>"); | 161 | html("<div class='diffstat-header'>"); |
162 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, | 162 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
163 | ctx.qry.sha2, NULL, 0); | 163 | ctx.qry.sha2, NULL, 0); |
164 | if (prefix) | ||
165 | htmlf(" (limited to '%s')", prefix); | ||
164 | html("</div>"); | 166 | html("</div>"); |
165 | html("<table summary='diffstat' class='diffstat'>"); | 167 | html("<table summary='diffstat' class='diffstat'>"); |
166 | max_changes = 0; | 168 | max_changes = 0; |
167 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, NULL); | 169 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix); |
168 | for(i = 0; i<files; i++) | 170 | for(i = 0; i<files; i++) |
169 | print_fileinfo(&items[i]); | 171 | print_fileinfo(&items[i]); |
170 | html("</table>"); | 172 | html("</table>"); |
171 | html("<div class='diffstat-summary'>"); | 173 | html("<div class='diffstat-summary'>"); |
172 | htmlf("%d files changed, %d insertions, %d deletions", | 174 | htmlf("%d files changed, %d insertions, %d deletions", |
173 | files, total_adds, total_rems); | 175 | files, total_adds, total_rems); |
174 | html("</div>"); | 176 | html("</div>"); |
175 | } | 177 | } |
176 | 178 | ||
177 | 179 | ||
178 | /* | 180 | /* |
179 | * print a single line returned from xdiff | 181 | * print a single line returned from xdiff |
180 | */ | 182 | */ |
181 | static void print_line(char *line, int len) | 183 | static void print_line(char *line, int len) |
182 | { | 184 | { |
183 | char *class = "ctx"; | 185 | char *class = "ctx"; |
184 | char c = line[len-1]; | 186 | char c = line[len-1]; |
185 | 187 | ||
186 | if (line[0] == '+') | 188 | if (line[0] == '+') |
187 | class = "add"; | 189 | class = "add"; |
188 | else if (line[0] == '-') | 190 | else if (line[0] == '-') |
189 | class = "del"; | 191 | class = "del"; |
190 | else if (line[0] == '@') | 192 | else if (line[0] == '@') |
191 | class = "hunk"; | 193 | class = "hunk"; |
@@ -317,37 +319,37 @@ void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefi | |||
317 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); | 319 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); |
318 | 320 | ||
319 | if (old_rev) | 321 | if (old_rev) |
320 | get_sha1(old_rev, old_rev_sha1); | 322 | get_sha1(old_rev, old_rev_sha1); |
321 | else if (commit->parents && commit->parents->item) | 323 | else if (commit->parents && commit->parents->item) |
322 | hashcpy(old_rev_sha1, commit->parents->item->object.sha1); | 324 | hashcpy(old_rev_sha1, commit->parents->item->object.sha1); |
323 | else | 325 | else |
324 | hashclr(old_rev_sha1); | 326 | hashclr(old_rev_sha1); |
325 | 327 | ||
326 | if (!is_null_sha1(old_rev_sha1)) { | 328 | if (!is_null_sha1(old_rev_sha1)) { |
327 | type = sha1_object_info(old_rev_sha1, &size); | 329 | type = sha1_object_info(old_rev_sha1, &size); |
328 | if (type == OBJ_BAD) { | 330 | if (type == OBJ_BAD) { |
329 | cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); | 331 | cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); |
330 | return; | 332 | return; |
331 | } | 333 | } |
332 | commit2 = lookup_commit_reference(old_rev_sha1); | 334 | commit2 = lookup_commit_reference(old_rev_sha1); |
333 | if (!commit2 || parse_commit(commit2)) | 335 | if (!commit2 || parse_commit(commit2)) |
334 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); | 336 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); |
335 | } | 337 | } |
336 | 338 | ||
337 | if ((ctx.qry.ssdiff && !ctx.cfg.ssdiff) || (!ctx.qry.ssdiff && ctx.cfg.ssdiff)) | 339 | if ((ctx.qry.ssdiff && !ctx.cfg.ssdiff) || (!ctx.qry.ssdiff && ctx.cfg.ssdiff)) |
338 | use_ssdiff = 1; | 340 | use_ssdiff = 1; |
339 | 341 | ||
340 | print_ssdiff_link(); | 342 | print_ssdiff_link(); |
341 | cgit_print_diffstat(old_rev_sha1, new_rev_sha1); | 343 | cgit_print_diffstat(old_rev_sha1, new_rev_sha1, prefix); |
342 | 344 | ||
343 | if (use_ssdiff) { | 345 | if (use_ssdiff) { |
344 | html("<table summary='ssdiff' class='ssdiff'>"); | 346 | html("<table summary='ssdiff' class='ssdiff'>"); |
345 | } else { | 347 | } else { |
346 | html("<table summary='diff' class='diff'>"); | 348 | html("<table summary='diff' class='diff'>"); |
347 | html("<tr><td>"); | 349 | html("<tr><td>"); |
348 | } | 350 | } |
349 | cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); | 351 | cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); |
350 | if (!use_ssdiff) | 352 | if (!use_ssdiff) |
351 | html("</td></tr>"); | 353 | html("</td></tr>"); |
352 | html("</table>"); | 354 | html("</table>"); |
353 | } | 355 | } |