summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2006-12-28 00:54:43 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2006-12-28 00:54:43 (UTC)
commit27cd3b2a700e1cc46cd0393ddea48c07b62ee3a6 (patch) (unidiff)
tree041158893604fa4127bc0df31a2c22f8d48b852f
parentc43f1246cb759eb811ab0ebef0613b86dda99581 (diff)
downloadcgit-27cd3b2a700e1cc46cd0393ddea48c07b62ee3a6.zip
cgit-27cd3b2a700e1cc46cd0393ddea48c07b62ee3a6.tar.gz
cgit-27cd3b2a700e1cc46cd0393ddea48c07b62ee3a6.tar.bz2
Test for NULL-pointers in html_txt() and friends
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--html.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/html.c b/html.c
index 957b326..3a5d28d 100644
--- a/html.c
+++ b/html.c
@@ -16,143 +16,142 @@ char *fmt(const char *format, ...)
16 va_list args; 16 va_list args;
17 17
18 bufidx++; 18 bufidx++;
19 bufidx &= 7; 19 bufidx &= 7;
20 20
21 va_start(args, format); 21 va_start(args, format);
22 len = vsnprintf(buf[bufidx], sizeof(buf[bufidx]), format, args); 22 len = vsnprintf(buf[bufidx], sizeof(buf[bufidx]), format, args);
23 va_end(args); 23 va_end(args);
24 if (len>sizeof(buf[bufidx])) 24 if (len>sizeof(buf[bufidx]))
25 die("[html.c] string truncated: %s", format); 25 die("[html.c] string truncated: %s", format);
26 return buf[bufidx]; 26 return buf[bufidx];
27} 27}
28 28
29void html(const char *txt) 29void html(const char *txt)
30{ 30{
31 write(htmlfd, txt, strlen(txt)); 31 write(htmlfd, txt, strlen(txt));
32} 32}
33 33
34void htmlf(const char *format, ...) 34void htmlf(const char *format, ...)
35{ 35{
36 static char buf[65536]; 36 static char buf[65536];
37 va_list args; 37 va_list args;
38 38
39 va_start(args, format); 39 va_start(args, format);
40 vsnprintf(buf, sizeof(buf), format, args); 40 vsnprintf(buf, sizeof(buf), format, args);
41 va_end(args); 41 va_end(args);
42 html(buf); 42 html(buf);
43} 43}
44 44
45void html_txt(char *txt) 45void html_txt(char *txt)
46{ 46{
47 char *t = txt; 47 char *t = txt;
48 while(*t){ 48 while(t && *t){
49 int c = *t; 49 int c = *t;
50 if (c=='<' || c=='>' || c=='&') { 50 if (c=='<' || c=='>' || c=='&') {
51 *t = '\0'; 51 *t = '\0';
52 html(txt); 52 html(txt);
53 *t = c; 53 *t = c;
54 if (c=='>') 54 if (c=='>')
55 html("&gt;"); 55 html("&gt;");
56 else if (c=='<') 56 else if (c=='<')
57 html("&lt;"); 57 html("&lt;");
58 else if (c=='&') 58 else if (c=='&')
59 html("&amp;"); 59 html("&amp;");
60 txt = t+1; 60 txt = t+1;
61 } 61 }
62 t++; 62 t++;
63 } 63 }
64 if (t!=txt) 64 if (t!=txt)
65 html(txt); 65 html(txt);
66} 66}
67 67
68void html_ntxt(int len, char *txt) 68void html_ntxt(int len, char *txt)
69{ 69{
70 char *t = txt; 70 char *t = txt;
71 while(*t && len--){ 71 while(t && *t && len--){
72 int c = *t; 72 int c = *t;
73 if (c=='<' || c=='>' || c=='&') { 73 if (c=='<' || c=='>' || c=='&') {
74 *t = '\0'; 74 *t = '\0';
75 html(txt); 75 html(txt);
76 *t = c; 76 *t = c;
77 if (c=='>') 77 if (c=='>')
78 html("&gt;"); 78 html("&gt;");
79 else if (c=='<') 79 else if (c=='<')
80 html("&lt;"); 80 html("&lt;");
81 else if (c=='&') 81 else if (c=='&')
82 html("&amp;"); 82 html("&amp;");
83 txt = t+1; 83 txt = t+1;
84 } 84 }
85 t++; 85 t++;
86 } 86 }
87 if (t!=txt) { 87 if (t!=txt) {
88 char c = *t; 88 char c = *t;
89 *t = '\0'; 89 *t = '\0';
90 html(txt); 90 html(txt);
91 *t = c; 91 *t = c;
92 } 92 }
93 if (len<0) 93 if (len<0)
94 html("..."); 94 html("...");
95} 95}
96 96
97void html_attr(char *txt) 97void html_attr(char *txt)
98{ 98{
99 char *t = txt; 99 char *t = txt;
100 while(*t){ 100 while(t && *t){
101 int c = *t; 101 int c = *t;
102 if (c=='<' || c=='>' || c=='\'') { 102 if (c=='<' || c=='>' || c=='\'') {
103 *t = '\0'; 103 *t = '\0';
104 html(txt); 104 html(txt);
105 *t = c; 105 *t = c;
106 if (c=='>') 106 if (c=='>')
107 html("&gt;"); 107 html("&gt;");
108 else if (c=='<') 108 else if (c=='<')
109 html("&lt;"); 109 html("&lt;");
110 else if (c=='\'') 110 else if (c=='\'')
111 html("&quote;"); 111 html("&quote;");
112 txt = t+1; 112 txt = t+1;
113 } 113 }
114 t++; 114 t++;
115 } 115 }
116 if (t!=txt) 116 if (t!=txt)
117 html(txt); 117 html(txt);
118} 118}
119 119
120void html_link_open(char *url, char *title, char *class) 120void html_link_open(char *url, char *title, char *class)
121{ 121{
122 html("<a href='"); 122 html("<a href='");
123 html_attr(url); 123 html_attr(url);
124 if (title) { 124 if (title) {
125 html("' title='"); 125 html("' title='");
126 html_attr(title); 126 html_attr(title);
127 } 127 }
128 if (class) { 128 if (class) {
129 html("' class='"); 129 html("' class='");
130 html_attr(class); 130 html_attr(class);
131 } 131 }
132 html("'>"); 132 html("'>");
133} 133}
134 134
135void html_link_close(void) 135void html_link_close(void)
136{ 136{
137 html("</a>"); 137 html("</a>");
138} 138}
139 139
140void html_fileperm(unsigned short mode) 140void html_fileperm(unsigned short mode)
141{ 141{
142 htmlf("%c%c%c", (mode & 4 ? 'r' : '-'), 142 htmlf("%c%c%c", (mode & 4 ? 'r' : '-'),
143 (mode & 2 ? 'w' : '-'), (mode & 1 ? 'x' : '-')); 143 (mode & 2 ? 'w' : '-'), (mode & 1 ? 'x' : '-'));
144} 144}
145 145
146void html_filemode(unsigned short mode) 146void html_filemode(unsigned short mode)
147{ 147{
148 if (S_ISDIR(mode)) 148 if (S_ISDIR(mode))
149 html("d"); 149 html("d");
150 else if (S_ISLNK(mode)) 150 else if (S_ISLNK(mode))
151 html("l"); 151 html("l");
152 else 152 else
153 html("-"); 153 html("-");
154 html_fileperm(mode >> 6); 154 html_fileperm(mode >> 6);
155 html_fileperm(mode >> 3); 155 html_fileperm(mode >> 3);
156 html_fileperm(mode); 156 html_fileperm(mode);
157} 157}
158