Use utf8::reencode_string from git

This replaces the iconv-support in cgit with similar functions already
existing in git.

Signed-off-by: Lars Hjemli <hjemli@gmai.com>

2 files changed, 5 insertions, 60 deletions

diff --git a/cgit.h b/cgit.h
index 6c7a941..6291c58 100644
--- a/cgit.h
+++ b/cgit.h
@@ -1,50 +1,51 @@
 #ifndef CGIT_H
 #define CGIT_H
 
 
 #include <git-compat-util.h>
 #include <cache.h>
 #include <grep.h>
 #include <object.h>
 #include <tree.h>
 #include <commit.h>
 #include <tag.h>
 #include <diff.h>
 #include <diffcore.h>
 #include <refs.h>
 #include <revision.h>
 #include <log-tree.h>
 #include <archive.h>
 #include <xdiff/xdiff.h>
+#include <utf8.h>
 
 
 /*
  * The valid cgit repo-commands
  */
 #define CMD_LOG      1
 #define CMD_COMMIT   2
 #define CMD_DIFF     3
 #define CMD_TREE     4
 #define CMD_BLOB     5
 #define CMD_SNAPSHOT 6
 #define CMD_TAG      7
 #define CMD_REFS     8
 
 /*
  * Dateformats used on misc. pages
  */
 #define FMT_LONGDATE "%Y-%m-%d %H:%M:%S"
 #define FMT_SHORTDATE "%Y-%m-%d"
 
 
 /*
  * Limits used for relative dates
  */
 #define TM_MIN    60
 #define TM_HOUR  (TM_MIN * 60)
 #define TM_DAY   (TM_HOUR * 24)
 #define TM_WEEK  (TM_DAY * 7)
 #define TM_YEAR  (TM_DAY * 365)
 #define TM_MONTH (TM_YEAR / 12.0)
 
 
diff --git a/parsing.c b/parsing.c
index c731084..e8c7ab9 100644
--- a/parsing.c
+++ b/parsing.c
@@ -1,42 +1,40 @@
 /* config.c: parsing of config files
  *
  * Copyright (C) 2006 Lars Hjemli
  *
  * Licensed under GNU General Public License v2
  *   (see COPYING for full license text)
  */
 
-#include <iconv.h>
-
 #include "cgit.h"
 
 int next_char(FILE *f)
 {
 	int c = fgetc(f);
 	if (c=='\r') {
 		c = fgetc(f);
 		if (c!='\n') {
 			ungetc(c, f);
 			c = '\r';
 		}
 	}
 	return c;
 }
 
 void skip_line(FILE *f)
 {
 	int c;
 
 	while((c=next_char(f)) && c!='\n' && c!=EOF)
 		;
 }
 
 int read_config_line(FILE *f, char *line, const char **value, int bufsize)
 {
 	int i = 0, isname = 0;
 
 	*value = NULL;
 	while(i<bufsize-1) {
 		int c = next_char(f);
 		if (!isname && (c=='#' || c==';')) {
 			skip_line(f);
@@ -149,120 +147,64 @@ void cgit_parse_url(const char *url)
 	if (!url || url[0] == '\0')
 		return;
 
 	cgit_repo = cgit_get_repoinfo(url);
 	if (cgit_repo) {
 		cgit_query_repo = cgit_repo->url;
 		return;
 	}
 
 	cmd = strchr(url, '/');
 	while (!cgit_repo && cmd) {
 		cmd[0] = '\0';
 		cgit_repo = cgit_get_repoinfo(url);
 		if (cgit_repo == NULL) {
 			cmd[0] = '/';
 			cmd = strchr(cmd + 1, '/');
 			continue;
 		}
 
 		cgit_query_repo = cgit_repo->url;
 		p = strchr(cmd + 1, '/');
 		if (p) {
 			p[0] = '\0';
 			if (p[1])
 				cgit_query_path = trim_end(p + 1, '/');
 		}
 		cgit_cmd = cgit_get_cmd_index(cmd + 1);
 		cgit_query_page = xstrdup(cmd + 1);
 		return;
 	}
 }
 
-static char *iconv_msg(char *msg, const char *encoding)
-{
-	iconv_t msg_conv = iconv_open(PAGE_ENCODING, encoding);
-	size_t inlen = strlen(msg);
-	char *in;
-	char *out;
-	size_t inleft;
-	size_t outleft;
-	char *buf;
-	char *ret;
-	size_t buf_sz;
-	int again, fail;
-
-	if(msg_conv == (iconv_t)-1)
-		return NULL;
-
-	buf_sz = inlen * 2;
-	buf = xmalloc(buf_sz+1);
-	do {
-		in = msg;
-		inleft = inlen;
-
-		out = buf;
-		outleft = buf_sz;
-		iconv(msg_conv, &in, &inleft, &out, &outleft);
-
-		if(inleft == 0) {
-			fail = 0;
-			again = 0;
-		} else if(inleft != 0 && errno == E2BIG) {
-			fail = 0;
-			again = 1;
-
-			buf_sz *= 2;
-			free(buf);
-			buf = xmalloc(buf_sz+1);
-		} else {
-			fail = 1;
-			again = 0;
-		}
-	} while(again && !fail);
-
-	if(fail) {
-		free(buf);
-		ret = NULL;
-	} else {
-		buf = xrealloc(buf, out - buf);
-		*out = 0;
-		ret = buf;
-	}
-
-	iconv_close(msg_conv);
-
-	return ret;
-}
-
 char *substr(const char *head, const char *tail)
 {
 	char *buf;
 
 	buf = xmalloc(tail - head + 1);
 	strncpy(buf, head, tail - head);
 	buf[tail - head] = '\0';
 	return buf;
 }
 
 struct commitinfo *cgit_parse_commit(struct commit *commit)
 {
 	struct commitinfo *ret;
 	char *p = commit->buffer, *t = commit->buffer;
 
 	ret = xmalloc(sizeof(*ret));
 	ret->commit = commit;
 	ret->author = NULL;
 	ret->author_email = NULL;
 	ret->committer = NULL;
 	ret->committer_email = NULL;
 	ret->subject = NULL;
 	ret->msg = NULL;
 	ret->msg_encoding = NULL;
 
 	if (p == NULL)
 		return ret;
 
 	if (strncmp(p, "tree ", 5))
 		die("Bad commit: %s", sha1_to_hex(commit->object.sha1));
 	else
 		p += 46; // "tree " + hex[40] + "\n"
@@ -292,71 +234,73 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
 		p = strchr(t, '\n') + 1;
 	}
 
 	if (!strncmp(p, "encoding ", 9)) {
 		p += 9;
 		t = strchr(p, '\n') + 1;
 		ret->msg_encoding = substr(p, t);
 		p = t;
 	} else
 		ret->msg_encoding = xstrdup(PAGE_ENCODING);
 
 	while (*p && (*p != '\n'))
 		p = strchr(p, '\n') + 1; // skip unknown header fields
 
 	while (*p == '\n')
 		p = strchr(p, '\n') + 1;
 
 	t = strchr(p, '\n');
 	if (t) {
 		if (*t == '\0')
 			ret->subject = "** empty **";
 		else
 			ret->subject = substr(p, t);
 		p = t + 1;
 
 		while (*p == '\n')
 			p = strchr(p, '\n') + 1;
 		ret->msg = xstrdup(p);
 	} else
 		ret->subject = substr(p, p+strlen(p));
 
 	if(strcmp(ret->msg_encoding, PAGE_ENCODING)) {
-		t = iconv_msg(ret->subject, ret->msg_encoding);
+		t = reencode_string(ret->subject, PAGE_ENCODING,
+				    ret->msg_encoding);
 		if(t) {
 			free(ret->subject);
 			ret->subject = t;
 		}
 
-		t = iconv_msg(ret->msg, ret->msg_encoding);
+		t = reencode_string(ret->msg, PAGE_ENCODING,
+				    ret->msg_encoding);
 		if(t) {
 			free(ret->msg);
 			ret->msg = t;
 		}
 	}
 
 	return ret;
 }
 
 
 struct taginfo *cgit_parse_tag(struct tag *tag)
 {
 	void *data;
 	enum object_type type;
 	unsigned long size;
 	char *p, *t;
 	struct taginfo *ret;
 
 	data = read_sha1_file(tag->object.sha1, &type, &size);
 	if (!data || type != OBJ_TAG) {
 		free(data);
 		return 0;
 	}
 
 	ret = xmalloc(sizeof(*ret));
 	ret->tagger = NULL;
 	ret->tagger_email = NULL;
 	ret->tagger_date = 0;
 	ret->msg = NULL;
 
 	p = data;