summaryrefslogtreecommitdiffabout
authorMark Lodato <lodatom@gmail.com>2010-09-04 15:09:57 (UTC)
committer Mark Lodato <lodatom@gmail.com>2010-09-04 15:11:40 (UTC)
commita4c58d92bfee0cf2e35ab1c5e828a6d790108a69 (patch) (unidiff)
tree4b6073081a04216525facaf06db956b4a08dffac
parentbf8293d3196d49d6c4a48b254a04415183ca2762 (diff)
downloadcgit-a4c58d92bfee0cf2e35ab1c5e828a6d790108a69.zip
cgit-a4c58d92bfee0cf2e35ab1c5e828a6d790108a69.tar.gz
cgit-a4c58d92bfee0cf2e35ab1c5e828a6d790108a69.tar.bz2
use __attribute__ to catch printf format mistakes
Use "__attribute__((format (printf,N,M)))", as is done in git, do catch mistakes in printf-style format strings. Signed-off-by: Mark Lodato <lodatom@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--cache.h1
-rw-r--r--cgit.h1
-rw-r--r--html.h3
3 files changed, 5 insertions, 0 deletions
diff --git a/cache.h b/cache.h
index ac9276b..5cfdb4f 100644
--- a/cache.h
+++ b/cache.h
@@ -27,11 +27,12 @@ extern int cache_process(int size, const char *path, const char *key, int ttl,
27 27
28 28
29/* List info about all cache entries on stdout */ 29/* List info about all cache entries on stdout */
30extern int cache_ls(const char *path); 30extern int cache_ls(const char *path);
31 31
32/* Print a message to stdout */ 32/* Print a message to stdout */
33__attribute__((format (printf,1,2)))
33extern void cache_log(const char *format, ...); 34extern void cache_log(const char *format, ...);
34 35
35extern unsigned long hash_str(const char *str); 36extern unsigned long hash_str(const char *str);
36 37
37#endif /* CGIT_CACHE_H */ 38#endif /* CGIT_CACHE_H */
diff --git a/cgit.h b/cgit.h
index 4090cd4..8f84281 100644
--- a/cgit.h
+++ b/cgit.h
@@ -290,12 +290,13 @@ extern int cgit_diff_files(const unsigned char *old_sha1,
290extern void cgit_diff_tree(const unsigned char *old_sha1, 290extern void cgit_diff_tree(const unsigned char *old_sha1,
291 const unsigned char *new_sha1, 291 const unsigned char *new_sha1,
292 filepair_fn fn, const char *prefix, int ignorews); 292 filepair_fn fn, const char *prefix, int ignorews);
293 293
294extern void cgit_diff_commit(struct commit *commit, filepair_fn fn); 294extern void cgit_diff_commit(struct commit *commit, filepair_fn fn);
295 295
296__attribute__((format (printf,1,2)))
296extern char *fmt(const char *format,...); 297extern char *fmt(const char *format,...);
297 298
298extern struct commitinfo *cgit_parse_commit(struct commit *commit); 299extern struct commitinfo *cgit_parse_commit(struct commit *commit);
299extern struct taginfo *cgit_parse_tag(struct tag *tag); 300extern struct taginfo *cgit_parse_tag(struct tag *tag);
300extern void cgit_parse_url(const char *url); 301extern void cgit_parse_url(const char *url);
301 302
diff --git a/html.h b/html.h
index 16d55ec..1135fb8 100644
--- a/html.h
+++ b/html.h
@@ -2,13 +2,16 @@
2#define HTML_H 2#define HTML_H
3 3
4extern int htmlfd; 4extern int htmlfd;
5 5
6extern void html_raw(const char *txt, size_t size); 6extern void html_raw(const char *txt, size_t size);
7extern void html(const char *txt); 7extern void html(const char *txt);
8
9__attribute__((format (printf,1,2)))
8extern void htmlf(const char *format,...); 10extern void htmlf(const char *format,...);
11
9extern void html_status(int code, const char *msg, int more_headers); 12extern void html_status(int code, const char *msg, int more_headers);
10extern void html_txt(const char *txt); 13extern void html_txt(const char *txt);
11extern void html_ntxt(int len, const char *txt); 14extern void html_ntxt(int len, const char *txt);
12extern void html_attr(const char *txt); 15extern void html_attr(const char *txt);
13extern void html_url_path(const char *txt); 16extern void html_url_path(const char *txt);
14extern void html_url_arg(const char *txt); 17extern void html_url_arg(const char *txt);