Handle missing timestamp in commit/tag objects

When a commit or tag lacks author/committer/tagger timestamp, do not skip
the next line in the commit/tag object.

Also, do not bother to print timestamps with value 0 as it is close to certain
to be bogus.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>

2 files changed, 7 insertions, 3 deletions

diff --git a/parsing.c b/parsing.c
index 30e7648..55a485d 100644
--- a/parsing.c
+++ b/parsing.c
@@ -215,24 +215,24 @@ struct commitinfo *cgit_parse_commit(struct commit *commit)
 		p += 7;
 		t = strchr(p, '<') - 1;
 		ret->author = substr(p, t);
 		p = t;
 		t = strchr(t, '>') + 1;
 		ret->author_email = substr(p, t);
-		ret->author_date = atol(++t);
+		ret->author_date = atol(t+1);
 		p = strchr(t, '\n') + 1;
 	}
 
 	if (!strncmp(p, "committer ", 9)) {
 		p += 9;
 		t = strchr(p, '<') - 1;
 		ret->committer = substr(p, t);
 		p = t;
 		t = strchr(t, '>') + 1;
 		ret->committer_email = substr(p, t);
-		ret->committer_date = atol(++t);
+		ret->committer_date = atol(t+1);
 		p = strchr(t, '\n') + 1;
 	}
 
 	while (*p && (*p != '\n'))
 		p = strchr(p, '\n') + 1; // skip unknown header fields
 
@@ -287,13 +287,13 @@ struct taginfo *cgit_parse_tag(struct tag *tag)
 			p += 7;
 			t = strchr(p, '<') - 1;
 			ret->tagger = substr(p, t);
 			p = t;
 			t = strchr(t, '>') + 1;
 			ret->tagger_email = substr(p, t);
-			ret->tagger_date = atol(++t);
+			ret->tagger_date = atol(t+1);
 		}
 		p = strchr(p, '\n') + 1;
 	}
 
 	while (p && *p && (*p != '\n'))
 		p = strchr(p, '\n') + 1; // skip unknown tag fields
diff --git a/ui-shared.c b/ui-shared.c
index 72a7b44..4944dfd 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -301,21 +301,25 @@ void cgit_object_link(struct object *obj)
 
 void cgit_print_date(time_t secs, char *format)
 {
 	char buf[64];
 	struct tm *time;
 
+	if (!secs)
+		return;
 	time = gmtime(&secs);
 	strftime(buf, sizeof(buf)-1, format, time);
 	html_txt(buf);
 }
 
 void cgit_print_age(time_t t, time_t max_relative, char *format)
 {
 	time_t now, secs;
 
+	if (!t)
+		return;
 	time(&now);
 	secs = now - t;
 
 	if (secs > max_relative && max_relative >= 0) {
 		cgit_print_date(t, format);
 		return;