summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2011-05-22 10:22:56 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2011-05-23 20:58:35 (UTC)
commit084ca50972b4be120eba8d22ce585766ae315c36 (patch) (side-by-side diff)
tree2121925ba34a7f5821567c56a16ae6d8c92b46f7
parentafe04daa3380ae144c2c9b486674c98e5dd082a3 (diff)
downloadcgit-084ca50972b4be120eba8d22ce585766ae315c36.zip
cgit-084ca50972b4be120eba8d22ce585766ae315c36.tar.gz
cgit-084ca50972b4be120eba8d22ce585766ae315c36.tar.bz2
tests: add tests for links with space in path and/or args
These tests tries to detect bad links in various pages. On the log page, there currently exists links which are not properly escaped due to the use of cgit_fileurl() when building the link. For now, this bug is simply tagged as such. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rwxr-xr-xtests/setup.sh11
-rwxr-xr-xtests/t0101-index.sh1
-rwxr-xr-xtests/t0103-log.sh10
3 files changed, 19 insertions, 3 deletions
diff --git a/tests/setup.sh b/tests/setup.sh
index 9f66d89..b2f1169 100755
--- a/tests/setup.sh
+++ b/tests/setup.sh
@@ -17,16 +17,16 @@
mkrepo() {
name=$1
count=$2
dir=$PWD
- test -d $name && return
+ test -d "$name" && return
printf "Creating testrepo %s\n" $name
- mkdir -p $name
- cd $name
+ mkdir -p "$name"
+ cd "$name"
git init
n=1
while test $n -le $count
do
echo $n >file-$n
git add file-$n
@@ -47,12 +47,13 @@ setup_repos()
{
rm -rf trash/cache
mkdir -p trash/cache
mkrepo trash/repos/foo 5 >/dev/null
mkrepo trash/repos/bar 50 >/dev/null
mkrepo trash/repos/foo+bar 10 testplus >/dev/null
+ mkrepo "trash/repos/with space" 2 >/dev/null
cat >trash/cgitrc <<EOF
virtual-root=/
cache-root=$PWD/trash/cache
cache-size=1021
snapshots=tar.gz tar.bz zip
@@ -72,12 +73,16 @@ repo.url=bar
repo.path=$PWD/trash/repos/bar/.git
repo.desc=the bar repo
repo.url=foo+bar
repo.path=$PWD/trash/repos/foo+bar/.git
repo.desc=the foo+bar repo
+
+repo.url=with space
+repo.path=$PWD/trash/repos/with space/.git
+repo.desc=spaced repo
EOF
}
prepare_tests()
{
setup_repos
diff --git a/tests/t0101-index.sh b/tests/t0101-index.sh
index 07e39f9..573a351 100755
--- a/tests/t0101-index.sh
+++ b/tests/t0101-index.sh
@@ -8,10 +8,11 @@ run_test 'generate index page' 'cgit_url "" >trash/tmp'
run_test 'find foo repo' 'grep -e "foo" trash/tmp'
run_test 'find foo description' 'grep -e "\[no description\]" trash/tmp'
run_test 'find bar repo' 'grep -e "bar" trash/tmp'
run_test 'find bar description' 'grep -e "the bar repo" trash/tmp'
run_test 'find foo+bar repo' 'grep -e ">foo+bar<" trash/tmp'
run_test 'verify foo+bar link' 'grep -e "/foo+bar/" trash/tmp'
+run_test 'verify "with%20space" link' 'grep -e "/with%20space/" trash/tmp'
run_test 'no tree-link' '! grep -e "foo/tree" trash/tmp'
run_test 'no log-link' '! grep -e "foo/log" trash/tmp'
tests_done
diff --git a/tests/t0103-log.sh b/tests/t0103-log.sh
index b08cd29..def5c18 100755
--- a/tests/t0103-log.sh
+++ b/tests/t0103-log.sh
@@ -9,7 +9,17 @@ run_test 'find commit 1' 'grep -e "commit 1" trash/tmp'
run_test 'find commit 5' 'grep -e "commit 5" trash/tmp'
run_test 'generate bar/log' 'cgit_url "bar/log" >trash/tmp'
run_test 'find commit 1' 'grep -e "commit 1" trash/tmp'
run_test 'find commit 50' 'grep -e "commit 50" trash/tmp'
+run_test 'generate "with%20space/log?qt=grep&q=commit+1"' '
+ cgit_url "with+space/log&qt=grep&q=commit+1" >trash/tmp
+'
+run_test 'find commit 1' 'grep -e "commit 1" trash/tmp'
+run_test 'find link with %20 in path' 'grep -e "/with%20space/log/?qt=grep" trash/tmp'
+run_test 'find link with + in arg' 'grep -e "/log/?qt=grep&q=commit+1" trash/tmp'
+run_test BUG 'no links with space in path' '! grep -e "href=./with space/" trash/tmp'
+run_test 'no links with space in arg' '! grep -e "q=commit 1" trash/tmp'
+run_test 'commit 2 is not visible' '! grep -e "commit 2" trash/tmp'
+
tests_done