summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2011-06-02 10:30:26 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2011-06-02 10:30:26 (UTC)
commitd885158f6ac29e04bd14dd132331c7e3a93e7490 (patch) (side-by-side diff)
tree15dee6a8e4f3cfd2737a50725e480d09220ee0dd
parent2aabeaf834a47c2fd64e045a28cd2e5b90658939 (diff)
downloadcgit-d885158f6ac29e04bd14dd132331c7e3a93e7490.zip
cgit-d885158f6ac29e04bd14dd132331c7e3a93e7490.tar.gz
cgit-d885158f6ac29e04bd14dd132331c7e3a93e7490.tar.bz2
ui-log.c: do not link from age column
The link url wasn't properly escaped, and since the link was identical to the one used on the commit message it didn't serve any special purpose. Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rwxr-xr-xtests/t0103-log.sh2
-rw-r--r--ui-log.c9
2 files changed, 1 insertions, 10 deletions
diff --git a/tests/t0103-log.sh b/tests/t0103-log.sh
index def5c18..75dd761 100755
--- a/tests/t0103-log.sh
+++ b/tests/t0103-log.sh
@@ -20,3 +20,3 @@ run_test 'find link with %20 in path' 'grep -e "/with%20space/log/?qt=grep" tras
run_test 'find link with + in arg' 'grep -e "/log/?qt=grep&q=commit+1" trash/tmp'
-run_test BUG 'no links with space in path' '! grep -e "href=./with space/" trash/tmp'
+run_test 'no links with space in path' '! grep -e "href=./with space/" trash/tmp'
run_test 'no links with space in arg' '! grep -e "q=commit 1" trash/tmp'
diff --git a/ui-log.c b/ui-log.c
index 8add66a..15ed6a3 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -97,3 +97,2 @@ void print_commit(struct commit *commit, struct rev_info *revs)
struct commitinfo *info;
- char *tmp;
int cols = revs->graph ? 3 : 2;
@@ -132,7 +131,3 @@ void print_commit(struct commit *commit, struct rev_info *revs)
html("<td>");
- tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1));
- tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp);
- html_link_open(tmp, NULL, NULL);
cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE);
- html_link_close();
html("</td>");
@@ -174,7 +169,3 @@ void print_commit(struct commit *commit, struct rev_info *revs)
html("</td><td>");
- tmp = fmt("id=%s", sha1_to_hex(commit->object.sha1));
- tmp = cgit_fileurl(ctx.repo->url, "commit", ctx.qry.vpath, tmp);
- html_link_open(tmp, NULL, NULL);
cgit_print_age(commit->date, TM_WEEK * 2, FMT_SHORTDATE);
- html_link_close();
}