summaryrefslogtreecommitdiffabout
authorLars Hjemli <hjemli@gmail.com>2011-05-22 10:45:32 (UTC)
committer Lars Hjemli <hjemli@gmail.com>2011-05-23 20:58:35 (UTC)
commitdc1a8eadd4c063fe6782fa99f9db41c46b85d048 (patch) (side-by-side diff)
treeb946f7378d4a4e846c2b247ee7ed12b3f0784e7e
parent084ca50972b4be120eba8d22ce585766ae315c36 (diff)
downloadcgit-dc1a8eadd4c063fe6782fa99f9db41c46b85d048.zip
cgit-dc1a8eadd4c063fe6782fa99f9db41c46b85d048.tar.gz
cgit-dc1a8eadd4c063fe6782fa99f9db41c46b85d048.tar.bz2
shared.c: do not modify const memory
Noticed-by: zhongjj <zhongjj@lemote.com> Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--shared.c14
1 files changed, 3 insertions, 11 deletions
diff --git a/shared.c b/shared.c
index 7ec2e19..3926b4a 100644
--- a/shared.c
+++ b/shared.c
@@ -100,23 +100,15 @@ void *cgit_free_commitinfo(struct commitinfo *info)
char *trim_end(const char *str, char c)
{
int len;
- char *s, *t;
if (str == NULL)
return NULL;
- t = (char *)str;
- len = strlen(t);
- while(len > 0 && t[len - 1] == c)
+ len = strlen(str);
+ while(len > 0 && str[len - 1] == c)
len--;
-
if (len == 0)
return NULL;
-
- c = t[len];
- t[len] = '\0';
- s = xstrdup(t);
- t[len] = c;
- return s;
+ return xstrndup(str, len);
}
char *strlpart(char *txt, int maxlen)