cache_safe_filename() needs more buffers

The single static buffer makes it impossible to use the result of two
different calls to this function simultaneously. Fix it by using 4
buffers.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>

1 files changed, 9 insertions, 4 deletions

diff --git a/cache.c b/cache.c
index 7cdea9b..372e38d 100644
--- a/cache.c
+++ b/cache.c
@@ -9,24 +9,29 @@
 #include "cgit.h"
 
 const int NOLOCK = -1;
 
 char *cache_safe_filename(const char *unsafe)
 {
-        static char buf[PATH_MAX];
-        char *s = buf;
+        static char buf[4][PATH_MAX];
+        static int bufidx;
+        char *s;
         char c;
 
+        bufidx++;
+        bufidx &= 3;
+        s = buf[bufidx];
+
         while(unsafe && (c = *unsafe++) != 0) {
-                if (c == '/' || c == ' ' || c == '&' || c == '|' || 
+                if (c == '/' || c == ' ' || c == '&' || c == '|' ||
                     c == '>' || c == '<' || c == '.')
                         c = '_';
                 *s++ = c;
         }
         *s = '\0';
-        return buf;
+        return buf[bufidx];
 }
 
 int cache_exist(struct cacheitem *item)
 {
         if (stat(item->name, &item->st)) {
                 item->st.st_mtime = 0;