| author | Lars Hjemli <hjemli@gmail.com> | 2006-12-11 21:53:50 (UTC) |
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2006-12-11 21:53:50 (UTC) |
| commit | fbaf1171b4e343929dd43ecac7cd9d1c692b84ec (patch) (side-by-side diff) | |
| tree | 40b7007b2e1e85f2e91e052b33555df2e9fb5e14 /cgit.h | |
| parent | 44923f8953c66dc9b852316b655ab3b5aec9478e (diff) | |
| download | cgit-fbaf1171b4e343929dd43ecac7cd9d1c692b84ec.zip cgit-fbaf1171b4e343929dd43ecac7cd9d1c692b84ec.tar.gz cgit-fbaf1171b4e343929dd43ecac7cd9d1c692b84ec.tar.bz2 | |
Don't truncate valid cachefiles
An embarrassing thinko in cgit_check_cache() would truncate valid cachefiles
in the following situation:
1) process A notices a missing/expired cachefile
2) process B gets scheduled, locks, fills and unlocks the cachefile
3) process A gets scheduled, locks the cachefile, notices that the cachefile
now exist/is not expired anymore, and continues to overwrite it with an
empty lockfile.
Thanks to Linus for noticing (again).
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
| -rw-r--r-- | cgit.h | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -65,8 +65,9 @@ extern int cgit_parse_query(char *txt, configfn fn); extern void cache_prepare(struct cacheitem *item); extern int cache_lock(struct cacheitem *item); extern int cache_unlock(struct cacheitem *item); +extern int cache_cancel_lock(struct cacheitem *item); extern int cache_exist(struct cacheitem *item); extern int cache_expired(struct cacheitem *item); extern char *cgit_repourl(const char *reponame); |