author | Mark Lodato <lodatom@gmail.com> | 2010-09-04 15:09:57 (UTC) |
---|---|---|
committer | Mark Lodato <lodatom@gmail.com> | 2010-09-04 15:11:40 (UTC) |
commit | a4c58d92bfee0cf2e35ab1c5e828a6d790108a69 (patch) (unidiff) | |
tree | 4b6073081a04216525facaf06db956b4a08dffac /cgit.h | |
parent | bf8293d3196d49d6c4a48b254a04415183ca2762 (diff) | |
download | cgit-a4c58d92bfee0cf2e35ab1c5e828a6d790108a69.zip cgit-a4c58d92bfee0cf2e35ab1c5e828a6d790108a69.tar.gz cgit-a4c58d92bfee0cf2e35ab1c5e828a6d790108a69.tar.bz2 |
use __attribute__ to catch printf format mistakes
Use "__attribute__((format (printf,N,M)))", as is done in git, do catch
mistakes in printf-style format strings.
Signed-off-by: Mark Lodato <lodatom@gmail.com>
-rw-r--r-- | cgit.h | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -248,66 +248,67 @@ struct cgit_context { | |||
248 | struct cgit_config cfg; | 248 | struct cgit_config cfg; |
249 | struct cgit_repo *repo; | 249 | struct cgit_repo *repo; |
250 | struct cgit_page page; | 250 | struct cgit_page page; |
251 | }; | 251 | }; |
252 | 252 | ||
253 | struct cgit_snapshot_format { | 253 | struct cgit_snapshot_format { |
254 | const char *suffix; | 254 | const char *suffix; |
255 | const char *mimetype; | 255 | const char *mimetype; |
256 | write_archive_fn_t write_func; | 256 | write_archive_fn_t write_func; |
257 | int bit; | 257 | int bit; |
258 | }; | 258 | }; |
259 | 259 | ||
260 | extern const char *cgit_version; | 260 | extern const char *cgit_version; |
261 | 261 | ||
262 | extern struct cgit_repolist cgit_repolist; | 262 | extern struct cgit_repolist cgit_repolist; |
263 | extern struct cgit_context ctx; | 263 | extern struct cgit_context ctx; |
264 | extern const struct cgit_snapshot_format cgit_snapshot_formats[]; | 264 | extern const struct cgit_snapshot_format cgit_snapshot_formats[]; |
265 | 265 | ||
266 | extern struct cgit_repo *cgit_add_repo(const char *url); | 266 | extern struct cgit_repo *cgit_add_repo(const char *url); |
267 | extern struct cgit_repo *cgit_get_repoinfo(const char *url); | 267 | extern struct cgit_repo *cgit_get_repoinfo(const char *url); |
268 | extern void cgit_repo_config_cb(const char *name, const char *value); | 268 | extern void cgit_repo_config_cb(const char *name, const char *value); |
269 | 269 | ||
270 | extern int chk_zero(int result, char *msg); | 270 | extern int chk_zero(int result, char *msg); |
271 | extern int chk_positive(int result, char *msg); | 271 | extern int chk_positive(int result, char *msg); |
272 | extern int chk_non_negative(int result, char *msg); | 272 | extern int chk_non_negative(int result, char *msg); |
273 | 273 | ||
274 | extern char *trim_end(const char *str, char c); | 274 | extern char *trim_end(const char *str, char c); |
275 | extern char *strlpart(char *txt, int maxlen); | 275 | extern char *strlpart(char *txt, int maxlen); |
276 | extern char *strrpart(char *txt, int maxlen); | 276 | extern char *strrpart(char *txt, int maxlen); |
277 | 277 | ||
278 | extern void cgit_add_ref(struct reflist *list, struct refinfo *ref); | 278 | extern void cgit_add_ref(struct reflist *list, struct refinfo *ref); |
279 | extern int cgit_refs_cb(const char *refname, const unsigned char *sha1, | 279 | extern int cgit_refs_cb(const char *refname, const unsigned char *sha1, |
280 | int flags, void *cb_data); | 280 | int flags, void *cb_data); |
281 | 281 | ||
282 | extern void *cgit_free_commitinfo(struct commitinfo *info); | 282 | extern void *cgit_free_commitinfo(struct commitinfo *info); |
283 | 283 | ||
284 | extern int cgit_diff_files(const unsigned char *old_sha1, | 284 | extern int cgit_diff_files(const unsigned char *old_sha1, |
285 | const unsigned char *new_sha1, | 285 | const unsigned char *new_sha1, |
286 | unsigned long *old_size, unsigned long *new_size, | 286 | unsigned long *old_size, unsigned long *new_size, |
287 | int *binary, int context, int ignorews, | 287 | int *binary, int context, int ignorews, |
288 | linediff_fn fn); | 288 | linediff_fn fn); |
289 | 289 | ||
290 | extern void cgit_diff_tree(const unsigned char *old_sha1, | 290 | extern void cgit_diff_tree(const unsigned char *old_sha1, |
291 | const unsigned char *new_sha1, | 291 | const unsigned char *new_sha1, |
292 | filepair_fn fn, const char *prefix, int ignorews); | 292 | filepair_fn fn, const char *prefix, int ignorews); |
293 | 293 | ||
294 | extern void cgit_diff_commit(struct commit *commit, filepair_fn fn); | 294 | extern void cgit_diff_commit(struct commit *commit, filepair_fn fn); |
295 | 295 | ||
296 | __attribute__((format (printf,1,2))) | ||
296 | extern char *fmt(const char *format,...); | 297 | extern char *fmt(const char *format,...); |
297 | 298 | ||
298 | extern struct commitinfo *cgit_parse_commit(struct commit *commit); | 299 | extern struct commitinfo *cgit_parse_commit(struct commit *commit); |
299 | extern struct taginfo *cgit_parse_tag(struct tag *tag); | 300 | extern struct taginfo *cgit_parse_tag(struct tag *tag); |
300 | extern void cgit_parse_url(const char *url); | 301 | extern void cgit_parse_url(const char *url); |
301 | 302 | ||
302 | extern const char *cgit_repobasename(const char *reponame); | 303 | extern const char *cgit_repobasename(const char *reponame); |
303 | 304 | ||
304 | extern int cgit_parse_snapshots_mask(const char *str); | 305 | extern int cgit_parse_snapshots_mask(const char *str); |
305 | 306 | ||
306 | extern int cgit_open_filter(struct cgit_filter *filter); | 307 | extern int cgit_open_filter(struct cgit_filter *filter); |
307 | extern int cgit_close_filter(struct cgit_filter *filter); | 308 | extern int cgit_close_filter(struct cgit_filter *filter); |
308 | 309 | ||
309 | extern int readfile(const char *path, char **buf, size_t *size); | 310 | extern int readfile(const char *path, char **buf, size_t *size); |
310 | 311 | ||
311 | extern char *expand_macros(const char *txt); | 312 | extern char *expand_macros(const char *txt); |
312 | 313 | ||
313 | #endif /* CGIT_H */ | 314 | #endif /* CGIT_H */ |