author | Simon Arlott <simon@fire.lp0.eu> | 2009-03-07 00:06:24 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2009-08-18 12:27:41 (UTC) |
commit | 011f2e9bdddcbfe65da397629bca87d167313a28 (patch) (side-by-side diff) | |
tree | 606b84a7b0211a6c4536bb508d57d4f19d20c3ab /scan-tree.c | |
parent | 6421dc38db02eff8d3ada93e87a2f7e5292af131 (diff) | |
download | cgit-011f2e9bdddcbfe65da397629bca87d167313a28.zip cgit-011f2e9bdddcbfe65da397629bca87d167313a28.tar.gz cgit-011f2e9bdddcbfe65da397629bca87d167313a28.tar.bz2 |
truncate buffer before reading empty files
If readfile() reads an empty file, fgets() won't truncate the buffer
and it'll still contain the contents of the previously read file.
[lh: fixed similar issue in ui-repolist.c]
Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | scan-tree.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/scan-tree.c b/scan-tree.c index cdafb02..47f3988 100644 --- a/scan-tree.c +++ b/scan-tree.c @@ -21,48 +21,49 @@ static int is_git_dir(const char *path) } if (!S_ISDIR(st.st_mode)) return 0; sprintf(buf, "%s/HEAD", path); if (stat(buf, &st)) { if (errno != ENOENT) fprintf(stderr, "Error checking path %s: %s (%d)\n", path, strerror(errno), errno); return 0; } if (!S_ISREG(st.st_mode)) return 0; return 1; } char *readfile(const char *path) { FILE *f; static char buf[MAX_PATH]; if (!(f = fopen(path, "r"))) return NULL; + buf[0] = 0; fgets(buf, MAX_PATH, f); fclose(f); return buf; } static void add_repo(const char *base, const char *path) { struct cgit_repo *repo; struct stat st; struct passwd *pwd; char *p; if (stat(path, &st)) { fprintf(stderr, "Error accessing %s: %s (%d)\n", path, strerror(errno), errno); return; } if ((pwd = getpwuid(st.st_uid)) == NULL) { fprintf(stderr, "Error reading owner-info for %s: %s (%d)\n", path, strerror(errno), errno); return; } if (base == path) p = fmt("%s", path); |