| author | Lars Hjemli <hjemli@gmail.com> | 2008-02-24 14:27:33 (UTC) |
|---|---|---|
| committer | Lars Hjemli <hjemli@gmail.com> | 2008-02-24 14:27:33 (UTC) |
| commit | 19134112bf942c0492f2095b668ea31c1a498f1a (patch) (side-by-side diff) | |
| tree | b41e1a3a1a80b82b62fa7c5355526dd4b309cae4 /tests/setup.sh | |
| parent | e0572c39f78b4f88c706a49a60e211302b8e015c (diff) | |
| download | cgit-19134112bf942c0492f2095b668ea31c1a498f1a.zip cgit-19134112bf942c0492f2095b668ea31c1a498f1a.tar.gz cgit-19134112bf942c0492f2095b668ea31c1a498f1a.tar.bz2 | |
Add regression-test for description-less repos
The segfault fixed in commit eacde43d7184452e1fdc90b982b531f1f5239923 was
triggered when the html-functions manipulated string literals. One callpatch
which could trigger the bug is in ui-repolist.c when repo descriptions are
passed to html_ntxt(): if a repo is lacking a description, the literal
string "[no description]" is used.
This patch changes test/setup.sh such that the first repo has no description,
and adds tests for both "[no description]" and "the bar repo" (description
of the other repo) to tests/t0101-index.sh, which should be enought to catch
regressions in these functions.
Noticed-by: Hiroki Hattori <seagull.kamome@gmail.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
| -rwxr-xr-x | tests/setup.sh | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tests/setup.sh b/tests/setup.sh index 51d5a75..9bb1f12 100755 --- a/tests/setup.sh +++ b/tests/setup.sh @@ -49,17 +49,19 @@ snapshots=tar.gz tar.bz zip enable-log-filecount=1 enable-log-linecount=1 summary-log=5 summary-branches=5 summary-tags=5 repo.url=foo repo.path=$PWD/trash/repos/foo/.git -repo.desc=the foo repo +# Do not specify a description for this repo, as it then will be assigned +# the constant value "[no description]" (which actually used to cause a +# segfault). repo.url=bar repo.path=$PWD/trash/repos/bar/.git repo.desc=the bar repo EOF } prepare_tests() |