author | Lars Hjemli <hjemli@gmail.com> | 2008-02-24 14:27:33 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2008-02-24 14:27:33 (UTC) |
commit | 19134112bf942c0492f2095b668ea31c1a498f1a (patch) (side-by-side diff) | |
tree | b41e1a3a1a80b82b62fa7c5355526dd4b309cae4 /tests/t0101-index.sh | |
parent | e0572c39f78b4f88c706a49a60e211302b8e015c (diff) | |
download | cgit-19134112bf942c0492f2095b668ea31c1a498f1a.zip cgit-19134112bf942c0492f2095b668ea31c1a498f1a.tar.gz cgit-19134112bf942c0492f2095b668ea31c1a498f1a.tar.bz2 |
Add regression-test for description-less repos
The segfault fixed in commit eacde43d7184452e1fdc90b982b531f1f5239923 was
triggered when the html-functions manipulated string literals. One callpatch
which could trigger the bug is in ui-repolist.c when repo descriptions are
passed to html_ntxt(): if a repo is lacking a description, the literal
string "[no description]" is used.
This patch changes test/setup.sh such that the first repo has no description,
and adds tests for both "[no description]" and "the bar repo" (description
of the other repo) to tests/t0101-index.sh, which should be enought to catch
regressions in these functions.
Noticed-by: Hiroki Hattori <seagull.kamome@gmail.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rwxr-xr-x | tests/t0101-index.sh | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/tests/t0101-index.sh b/tests/t0101-index.sh index 12ed00c..59edc59 100755 --- a/tests/t0101-index.sh +++ b/tests/t0101-index.sh @@ -3,11 +3,13 @@ . ./setup.sh prepare_tests "Check content on index page" run_test 'generate index page' 'cgit_url "" >trash/tmp' run_test 'find foo repo' 'grep -e "foo" trash/tmp' +run_test 'find foo description' 'grep -e "\[no description\]" trash/tmp' run_test 'find bar repo' 'grep -e "bar" trash/tmp' +run_test 'find bar description' 'grep -e "the bar repo" trash/tmp' run_test 'no tree-link' 'grep -ve "foo/tree" trash/tmp' run_test 'no log-link' 'grep -ve "foo/log" trash/tmp' tests_done |