author | Lars Hjemli <hjemli@gmail.com> | 2011-05-22 10:22:56 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2011-05-23 20:58:35 (UTC) |
commit | 084ca50972b4be120eba8d22ce585766ae315c36 (patch) (unidiff) | |
tree | 2121925ba34a7f5821567c56a16ae6d8c92b46f7 /tests/t0103-log.sh | |
parent | afe04daa3380ae144c2c9b486674c98e5dd082a3 (diff) | |
download | cgit-084ca50972b4be120eba8d22ce585766ae315c36.zip cgit-084ca50972b4be120eba8d22ce585766ae315c36.tar.gz cgit-084ca50972b4be120eba8d22ce585766ae315c36.tar.bz2 |
tests: add tests for links with space in path and/or args
These tests tries to detect bad links in various pages. On the log page,
there currently exists links which are not properly escaped due to the
use of cgit_fileurl() when building the link. For now, this bug is simply
tagged as such.
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rwxr-xr-x | tests/t0103-log.sh | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/tests/t0103-log.sh b/tests/t0103-log.sh index b08cd29..def5c18 100755 --- a/tests/t0103-log.sh +++ b/tests/t0103-log.sh | |||
@@ -1,15 +1,25 @@ | |||
1 | #!/bin/sh | 1 | #!/bin/sh |
2 | 2 | ||
3 | . ./setup.sh | 3 | . ./setup.sh |
4 | 4 | ||
5 | prepare_tests "Check content on log page" | 5 | prepare_tests "Check content on log page" |
6 | 6 | ||
7 | run_test 'generate foo/log' 'cgit_url "foo/log" >trash/tmp' | 7 | run_test 'generate foo/log' 'cgit_url "foo/log" >trash/tmp' |
8 | run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' | 8 | run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' |
9 | run_test 'find commit 5' 'grep -e "commit 5" trash/tmp' | 9 | run_test 'find commit 5' 'grep -e "commit 5" trash/tmp' |
10 | 10 | ||
11 | run_test 'generate bar/log' 'cgit_url "bar/log" >trash/tmp' | 11 | run_test 'generate bar/log' 'cgit_url "bar/log" >trash/tmp' |
12 | run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' | 12 | run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' |
13 | run_test 'find commit 50' 'grep -e "commit 50" trash/tmp' | 13 | run_test 'find commit 50' 'grep -e "commit 50" trash/tmp' |
14 | 14 | ||
15 | run_test 'generate "with%20space/log?qt=grep&q=commit+1"' ' | ||
16 | cgit_url "with+space/log&qt=grep&q=commit+1" >trash/tmp | ||
17 | ' | ||
18 | run_test 'find commit 1' 'grep -e "commit 1" trash/tmp' | ||
19 | run_test 'find link with %20 in path' 'grep -e "/with%20space/log/?qt=grep" trash/tmp' | ||
20 | run_test 'find link with + in arg' 'grep -e "/log/?qt=grep&q=commit+1" trash/tmp' | ||
21 | run_test BUG 'no links with space in path' '! grep -e "href=./with space/" trash/tmp' | ||
22 | run_test 'no links with space in arg' '! grep -e "q=commit 1" trash/tmp' | ||
23 | run_test 'commit 2 is not visible' '! grep -e "commit 2" trash/tmp' | ||
24 | |||
15 | tests_done | 25 | tests_done |