author | Simon Arlott <simon@fire.lp0.eu> | 2009-03-07 00:06:24 (UTC) |
---|---|---|
committer | Lars Hjemli <hjemli@gmail.com> | 2009-08-18 12:27:41 (UTC) |
commit | 011f2e9bdddcbfe65da397629bca87d167313a28 (patch) (side-by-side diff) | |
tree | 606b84a7b0211a6c4536bb508d57d4f19d20c3ab /ui-repolist.c | |
parent | 6421dc38db02eff8d3ada93e87a2f7e5292af131 (diff) | |
download | cgit-011f2e9bdddcbfe65da397629bca87d167313a28.zip cgit-011f2e9bdddcbfe65da397629bca87d167313a28.tar.gz cgit-011f2e9bdddcbfe65da397629bca87d167313a28.tar.bz2 |
truncate buffer before reading empty files
If readfile() reads an empty file, fgets() won't truncate the buffer
and it'll still contain the contents of the previously read file.
[lh: fixed similar issue in ui-repolist.c]
Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-repolist.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/ui-repolist.c b/ui-repolist.c index 2c13d50..3aedde5 100644 --- a/ui-repolist.c +++ b/ui-repolist.c @@ -2,48 +2,49 @@ * * Copyright (C) 2006 Lars Hjemli * * Licensed under GNU General Public License v2 * (see COPYING for full license text) */ /* This is needed for strcasestr to be defined by <string.h> */ #define _GNU_SOURCE 1 #include <string.h> #include <time.h> #include "cgit.h" #include "html.h" #include "ui-shared.h" time_t read_agefile(char *path) { FILE *f; static char buf[64], buf2[64]; if (!(f = fopen(path, "r"))) return -1; + buf[0] = 0; if (fgets(buf, sizeof(buf), f) == NULL) return -1; fclose(f); if (parse_date(buf, buf2, sizeof(buf2))) return strtoul(buf2, NULL, 10); else return 0; } static int get_repo_modtime(const struct cgit_repo *repo, time_t *mtime) { char *path; struct stat s; struct cgit_repo *r = (struct cgit_repo *)repo; if (repo->mtime != -1) { *mtime = repo->mtime; return 1; } path = fmt("%s/%s", repo->path, ctx.cfg.agefile); if (stat(path, &s) == 0) { *mtime = read_agefile(path); r->mtime = *mtime; return 1; |