Introduce struct cgit_context

This struct will hold all the cgit runtime information currently found in
a multitude of global variables.

The first cleanup removes all querystring-related variables.

Signed-off-by: Lars Hjemli <hjemli@gmail.com>

1 files changed, 43 insertions, 43 deletions

diff --git a/ui-shared.c b/ui-shared.c
index 60aa2e3..6a41fb0 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -103,28 +103,28 @@ const char *cgit_repobasename(const char *reponame)
         while( p && rvbuf[p]=='/') rvbuf[p--]=0;
         /* find last slash in the remaining string */
         rv = strrchr(rvbuf,'/');
         if(rv)
                 return ++rv;
         return rvbuf;
 }
 
 char *cgit_currurl()
 {
         if (!cgit_virtual_root)
                 return cgit_script_name;
-        else if (cgit_query_page)
-                return fmt("%s/%s/%s/", cgit_virtual_root, cgit_query_repo, cgit_query_page);
-        else if (cgit_query_repo)
-                return fmt("%s/%s/", cgit_virtual_root, cgit_query_repo);
+        else if (ctx.qry.page)
+                return fmt("%s/%s/%s/", cgit_virtual_root, ctx.qry.repo, ctx.qry.page);
+        else if (ctx.qry.repo)
+                return fmt("%s/%s/", cgit_virtual_root, ctx.qry.repo);
         else
                 return fmt("%s/", cgit_virtual_root);
 }
 
 static char *repolink(char *title, char *class, char *page, char *head,
                       char *path)
 {
         char *delim = "?";
 
         html("<a");
         if (title) {
                 html(" title='");
@@ -170,47 +170,47 @@ static char *repolink(char *title, char *class, char *page, char *head,
                 html_attr(head);
                 delim = "&amp;";
         }
         return fmt("%s", delim);
 }
 
 static void reporevlink(char *page, char *name, char *title, char *class,
                         char *head, char *rev, char *path)
 {
         char *delim;
 
         delim = repolink(title, class, page, head, path);
-        if (rev && strcmp(rev, cgit_query_head)) {
+        if (rev && strcmp(rev, ctx.qry.head)) {
                 html(delim);
                 html("id=");
                 html_attr(rev);
         }
         html("'>");
         html_txt(name);
         html("</a>");
 }
 
 void cgit_tree_link(char *name, char *title, char *class, char *head,
                     char *rev, char *path)
 {
         reporevlink("tree", name, title, class, head, rev, path);
 }
 
 void cgit_log_link(char *name, char *title, char *class, char *head,
                    char *rev, char *path, int ofs, char *grep, char *pattern)
 {
         char *delim;
 
         delim = repolink(title, class, "log", head, path);
-        if (rev && strcmp(rev, cgit_query_head)) {
+        if (rev && strcmp(rev, ctx.qry.head)) {
                 html(delim);
                 html("id=");
                 html_attr(rev);
                 delim = "&";
         }
         if (grep && pattern) {
                 html(delim);
                 html("qt=");
                 html_attr(grep);
                 delim = "&";
                 html(delim);
                 html("q=");
@@ -247,25 +247,25 @@ void cgit_refs_link(char *name, char *title, char *class, char *head,
 void cgit_snapshot_link(char *name, char *title, char *class, char *head,
                         char *rev, char *archivename)
 {
         reporevlink("snapshot", name, title, class, head, rev, archivename);
 }
 
 void cgit_diff_link(char *name, char *title, char *class, char *head,
                     char *new_rev, char *old_rev, char *path)
 {
         char *delim;
 
         delim = repolink(title, class, "diff", head, path);
-        if (new_rev && strcmp(new_rev, cgit_query_head)) {
+        if (new_rev && strcmp(new_rev, ctx.qry.head)) {
                 html(delim);
                 html("id=");
                 html_attr(new_rev);
                 delim = "&amp;";
         }
         if (old_rev) {
                 html(delim);
                 html("id2=");
                 html_attr(old_rev);
         }
         html("'>");
         html_txt(name);
@@ -275,38 +275,38 @@ void cgit_diff_link(char *name, char *title, char *class, char *head,
 void cgit_patch_link(char *name, char *title, char *class, char *head,
                      char *rev)
 {
         reporevlink("patch", name, title, class, head, rev, NULL);
 }
 
 void cgit_object_link(struct object *obj)
 {
         char *page, *arg, *url;
 
         if (obj->type == OBJ_COMMIT) {
                 cgit_commit_link(fmt("commit %s", sha1_to_hex(obj->sha1)), NULL, NULL,
-                                 cgit_query_head, sha1_to_hex(obj->sha1));
+                                 ctx.qry.head, sha1_to_hex(obj->sha1));
                 return;
         } else if (obj->type == OBJ_TREE) {
                 page = "tree";
                 arg = "id";
         } else if (obj->type == OBJ_TAG) {
                 page = "tag";
                 arg = "id";
         } else {
                 page = "blob";
                 arg = "id";
         }
 
-        url = cgit_pageurl(cgit_query_repo, page,
+        url = cgit_pageurl(ctx.qry.repo, page,
                            fmt("%s=%s", arg, sha1_to_hex(obj->sha1)));
         html_link_open(url, NULL, NULL);
         htmlf("%s %s", typename(obj->type),
               sha1_to_hex(obj->sha1));
         html_link_close();
 }
 
 void cgit_print_date(time_t secs, char *format)
 {
         char buf[64];
         struct tm *time;
 
@@ -383,25 +383,25 @@ void cgit_print_docstart(char *title, struct cacheitem *item)
         html("<body>\n");
 }
 
 void cgit_print_docend()
 {
         html("</td>\n</tr>\n</table>\n</body>\n</html>\n");
 }
 
 int print_branch_option(const char *refname, const unsigned char *sha1,
                         int flags, void *cb_data)
 {
         char *name = (char *)refname;
-        html_option(name, name, cgit_query_head);
+        html_option(name, name, ctx.qry.head);
         return 0;
 }
 
 int print_archive_ref(const char *refname, const unsigned char *sha1,
                        int flags, void *cb_data)
 {
         struct tag *tag;
         struct taginfo *info;
         struct object *obj;
         char buf[256], *url;
         unsigned char fileid[20];
         int *header = (int *)cb_data;
@@ -417,141 +417,141 @@ int print_archive_ref(const char *refname, const unsigned char *sha1,
                 if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag)))
                         return 0;
                 hashcpy(fileid, tag->tagged->sha1);
         } else if (obj->type != OBJ_BLOB) {
                 return 0;
         } else {
                 hashcpy(fileid, sha1);
         }
         if (!*header) {
                 html("<h1>download</h1>\n");
                 *header = 1;
         }
-        url = cgit_pageurl(cgit_query_repo, "blob",
+        url = cgit_pageurl(ctx.qry.repo, "blob",
                            fmt("id=%s&amp;path=%s", sha1_to_hex(fileid),
                                buf));
         html_link_open(url, NULL, "menu");
         html_txt(strlpart(buf, 20));
         html_link_close();
         return 0;
 }
 
 void add_hidden_formfields(int incl_head, int incl_search, char *page)
 {
         char *url;
 
         if (!cgit_virtual_root) {
-                url = fmt("%s/%s", cgit_query_repo, page);
-                if (cgit_query_path)
-                        url = fmt("%s/%s", url, cgit_query_path);
+                url = fmt("%s/%s", ctx.qry.repo, page);
+                if (ctx.qry.path)
+                        url = fmt("%s/%s", url, ctx.qry.path);
                 html_hidden("url", url);
         }
 
-        if (incl_head && strcmp(cgit_query_head, cgit_repo->defbranch))
-                html_hidden("h", cgit_query_head);
+        if (incl_head && strcmp(ctx.qry.head, cgit_repo->defbranch))
+                html_hidden("h", ctx.qry.head);
 
-        if (cgit_query_sha1)
-                html_hidden("id", cgit_query_sha1);
-        if (cgit_query_sha2)
-                html_hidden("id2", cgit_query_sha2);
+        if (ctx.qry.sha1)
+                html_hidden("id", ctx.qry.sha1);
+        if (ctx.qry.sha2)
+                html_hidden("id2", ctx.qry.sha2);
 
         if (incl_search) {
-                if (cgit_query_grep)
-                        html_hidden("qt", cgit_query_grep);
-                if (cgit_query_search)
-                        html_hidden("q", cgit_query_search);
+                if (ctx.qry.grep)
+                        html_hidden("qt", ctx.qry.grep);
+                if (ctx.qry.search)
+                        html_hidden("q", ctx.qry.search);
         }
 }
 
 void cgit_print_pageheader(char *title, int show_search)
 {
         static const char *default_info = "This is cgit, a fast webinterface for git repositories";
         int header = 0;
         char *url;
 
         html("<table id='layout' summary=''>\n");
         html("<tr><td id='sidebar'>\n");
         html("<table class='sidebar' cellspacing='0' summary=''>\n");
         html("<tr><td class='sidebar'>\n<a href='");
         html_attr(cgit_rooturl());
         htmlf("'><img src='%s' alt='cgit'/></a>\n",
               cgit_logo);
         html("</td></tr>\n<tr><td class='sidebar'>\n");
-        if (cgit_query_repo) {
+        if (ctx.qry.repo) {
                 html("<h1 class='first'>");
                 html_txt(strrpart(cgit_repo->name, 20));
                 html("</h1>\n");
                 html_txt(cgit_repo->desc);
                 if (cgit_repo->owner) {
                         html("<h1>owner</h1>\n");
                         html_txt(cgit_repo->owner);
                 }
                 html("<h1>navigate</h1>\n");
-                reporevlink(NULL, "summary", NULL, "menu", cgit_query_head,
+                reporevlink(NULL, "summary", NULL, "menu", ctx.qry.head,
                             NULL, NULL);
-                cgit_log_link("log", NULL, "menu", cgit_query_head, NULL, NULL,
+                cgit_log_link("log", NULL, "menu", ctx.qry.head, NULL, NULL,
                               0, NULL, NULL);
-                cgit_tree_link("tree", NULL, "menu", cgit_query_head,
-                               cgit_query_sha1, NULL);
-                cgit_commit_link("commit", NULL, "menu", cgit_query_head,
-                              cgit_query_sha1);
-                cgit_diff_link("diff", NULL, "menu", cgit_query_head,
-                               cgit_query_sha1, cgit_query_sha2, NULL);
-                cgit_patch_link("patch", NULL, "menu", cgit_query_head,
-                                cgit_query_sha1);
+                cgit_tree_link("tree", NULL, "menu", ctx.qry.head,
+                               ctx.qry.sha1, NULL);
+                cgit_commit_link("commit", NULL, "menu", ctx.qry.head,
+                              ctx.qry.sha1);
+                cgit_diff_link("diff", NULL, "menu", ctx.qry.head,
+                               ctx.qry.sha1, ctx.qry.sha2, NULL);
+                cgit_patch_link("patch", NULL, "menu", ctx.qry.head,
+                                ctx.qry.sha1);
 
                 for_each_ref(print_archive_ref, &header);
 
                 if (cgit_repo->clone_url || cgit_clone_prefix) {
                         html("<h1>clone</h1>\n");
                         if (cgit_repo->clone_url)
                                 url = cgit_repo->clone_url;
                         else
                                 url = fmt("%s%s", cgit_clone_prefix,
                                           cgit_repo->url);
                         html("<a class='menu' href='");
                         html_attr(url);
                         html("' title='");
                         html_attr(url);
                         html("'>\n");
                         html_txt(strrpart(url, 20));
                         html("</a>\n");
                 }
 
                 html("<h1>branch</h1>\n");
                 html("<form method='get' action=''>\n");
-                add_hidden_formfields(0, 1, cgit_query_page);
+                add_hidden_formfields(0, 1, ctx.qry.page);
         //      html("<table summary='branch selector' class='grid'><tr><td id='branch-dropdown-cell'>");
                 html("<select name='h' onchange='this.form.submit();'>\n");
-                for_each_branch_ref(print_branch_option, cgit_query_head);
+                for_each_branch_ref(print_branch_option, ctx.qry.head);
                 html("</select>\n");
         //      html("</td><td>");
                 html("<noscript><input type='submit' id='switch-btn' value='switch'/></noscript>\n");
         //      html("</td></tr></table>");
                 html("</form>\n");
 
                 html("<h1>search</h1>\n");
                 html("<form method='get' action='");
                 if (cgit_virtual_root)
-                        html_attr(cgit_fileurl(cgit_query_repo, "log",
-                                               cgit_query_path, NULL));
+                        html_attr(cgit_fileurl(ctx.qry.repo, "log",
+                                               ctx.qry.path, NULL));
                 html("'>\n");
                 add_hidden_formfields(1, 0, "log");
                 html("<select name='qt'>\n");
-                html_option("grep", "log msg", cgit_query_grep);
-                html_option("author", "author", cgit_query_grep);
-                html_option("committer", "committer", cgit_query_grep);
+                html_option("grep", "log msg", ctx.qry.grep);
+                html_option("author", "author", ctx.qry.grep);
+                html_option("committer", "committer", ctx.qry.grep);
                 html("</select>\n");
                 html("<input class='txt' type='text' name='q' value='");
-                html_attr(cgit_query_search);
+                html_attr(ctx.qry.search);
                 html("'/>\n");
                 html("</form>\n");
         } else {
                 if (!cgit_index_info || html_include(cgit_index_info))
                         html(default_info);
         }
 
         html("</td></tr></table></td>\n");
 
         html("<td id='content'>\n");
 }