12 files changed, 94 insertions, 41 deletions

diff --git a/Makefile b/Makefile
index cb7875e..f8a4d47 100644
--- a/Makefile
+++ b/Makefile
@@ -12,4 +12,7 @@ INSTALL = install
 # Define NO_STRCASESTR if you don't have strcasestr.
 #
+# Define NO_OPENSSL to disable linking with OpenSSL and use bundled SHA1
+# implementation (slower).
+#
 # Define NEEDS_LIBICONV if linking with libc is not enough (eg. Darwin).
 #
@@ -69,5 +72,5 @@ endif
 
 
-EXTLIBS = git/libgit.a git/xdiff/lib.a -lz -lcrypto
+EXTLIBS = git/libgit.a git/xdiff/lib.a -lz
 OBJECTS =
 OBJECTS += cache.o
@@ -125,4 +128,10 @@ ifdef NO_STRCASESTR
         CFLAGS += -DNO_STRCASESTR
 endif
+ifdef NO_OPENSSL
+        CFLAGS += -DNO_OPENSSL
+        GIT_OPTIONS += NO_OPENSSL=1
+else
+        EXTLIBS += -lcrypto
+endif
 
 cgit: $(OBJECTS) libgit
@@ -134,6 +143,6 @@ cgit.o: VERSION
 
 libgit:
-        $(QUIET_SUBDIR0)git $(QUIET_SUBDIR1) NO_CURL=1 libgit.a
-        $(QUIET_SUBDIR0)git $(QUIET_SUBDIR1) NO_CURL=1 xdiff/lib.a
+        $(QUIET_SUBDIR0)git $(QUIET_SUBDIR1) NO_CURL=1 $(GIT_OPTIONS) libgit.a
+        $(QUIET_SUBDIR0)git $(QUIET_SUBDIR1) NO_CURL=1 $(GIT_OPTIONS) xdiff/lib.a
 
 test: all
diff --git a/cgit.c b/cgit.c
index ff678fb..4f68a4b 100644
--- a/cgit.c
+++ b/cgit.c
@@ -69,7 +69,7 @@ void repo_config(struct cgit_repo *repo, const char *name, const char *value)
         else if (!strcmp(name, "readme") && value != NULL) {
                 if (*value == '/')
-                        ctx.repo->readme = xstrdup(value);
+                        repo->readme = xstrdup(value);
                 else
-                        ctx.repo->readme = xstrdup(fmt("%s/%s", ctx.repo->path, value));
+                        repo->readme = xstrdup(fmt("%s/%s", repo->path, value));
         } else if (ctx.cfg.enable_filter_overrides) {
                 if (!strcmp(name, "about-filter"))
@@ -166,4 +166,6 @@ void config_cb(const char *name, const char *value)
         else if (!strcmp(name, "max-repodesc-length"))
                 ctx.cfg.max_repodesc_len = atoi(value);
+        else if (!strcmp(name, "max-blob-size"))
+                ctx.cfg.max_blob_size = atoi(value);
         else if (!strcmp(name, "max-repo-count"))
                 ctx.cfg.max_repo_count = atoi(value);
@@ -212,4 +214,6 @@ static void querystring_cb(const char *name, const char *value)
                 ctx.qry.page = xstrdup(value);
         } else if (!strcmp(name, "url")) {
+                if (*value == '/')
+                        value++;
                 ctx.qry.url = xstrdup(value);
                 cgit_parse_url(value);
@@ -273,4 +277,5 @@ static void prepare_context(struct cgit_context *ctx)
         ctx->cfg.max_msg_len = 80;
         ctx->cfg.max_repodesc_len = 80;
+        ctx->cfg.max_blob_size = 0;
         ctx->cfg.max_stats = 0;
         ctx->cfg.module_link = "./?repo=%s&page=commit&id=%s";
diff --git a/cgit.css b/cgit.css
index 9e6d2a4..0cb894a 100644
--- a/cgit.css
+++ b/cgit.css
@@ -163,4 +163,9 @@ table.list td a {
 }
 
+table.list td a.ls-dir {
+        font-weight: bold;
+        color: #00f;
+}
+
 table.list td a:hover {
         color: #00f;
diff --git a/cgit.h b/cgit.h
index b7b0adb..5941ec0 100644
--- a/cgit.h
+++ b/cgit.h
@@ -187,4 +187,5 @@ struct cgit_config {
         int max_msg_len;
         int max_repodesc_len;
+        int max_blob_size;
         int max_stats;
         int nocache;
diff --git a/cgitrc.5.txt b/cgitrc.5.txt
index 252d546..70e4c78 100644
--- a/cgitrc.5.txt
+++ b/cgitrc.5.txt
@@ -1,2 +1,5 @@
+:man source:   cgit
+:man manual:   cgit
+
 CGITRC(5)
 ========
@@ -175,4 +178,8 @@ max-repodesc-length::
         on the repository index page. Default value: "80".
 
+max-blob-size::
+        Specifies the maximum size of a blob to display HTML for in KBytes.
+        Default value: "0" (limit disabled).
+
 max-stats::
         Set the default maximum statistics period. Valid values are "week",
@@ -426,6 +433,6 @@ mimetype.svg=image/svg+xml
 ##
 ## List of repositories.
-## PS: Any repositories listed when repo.group is unset will not be
-##     displayed under a group heading
+## PS: Any repositories listed when section is unset will not be
+##     displayed under a section heading
 ## PPS: This list could be kept in a different file (e.g. '/etc/cgitrepos')
 ##      and included like this:
@@ -449,5 +456,5 @@ repo.readme=info/web/about.html
 
 # The next repositories will be displayed under the 'extras' heading
-repo.group=extras
+section=extras
 
 
@@ -462,5 +469,5 @@ repo.desc=the wizard of foo
 
 # Add some mirrored repositories
-repo.group=mirrors
+section=mirrors
 
 
diff --git a/filters/syntax-highlighting.sh b/filters/syntax-highlighting.sh
index 999ad0c..6b1c576 100755
--- a/filters/syntax-highlighting.sh
+++ b/filters/syntax-highlighting.sh
@@ -4,4 +4,8 @@
 # filter options in cgitrc.
 #
+# This script requires a shell supporting the ${var##pattern} syntax.
+# It is supported by at least dash and bash, however busybox environments
+# might have to use an external call to sed instead.
+#
 # Note: the highlight command (http://www.andre-simon.de/) uses css for syntax
 # highlighting, so you'll probably want something like the following included
@@ -21,19 +25,10 @@
 # table.blob .kwd  { color:#010181; }
 
-case "$1" in
-        *.c)
-                highlight -f -I -X -S c
-                ;;
-        *.h)
-                highlight -f -I -X -S c
-                ;;
-        *.sh)
-                highlight -f -I -X -S sh
-                ;;
-        *.css)
-                highlight -f -I -X -S css
-                ;;
-        *)
-                highlight -f -I -X -S txt
-                ;;
-esac
+# store filename and extension in local vars
+BASENAME="$1"
+EXTENSION="${BASENAME##*.}"
+
+# map Makefile and Makefile.* to .mk
+[ "${BASENAME%%.*}" == "Makefile" ] && EXTENSION=mk
+
+exec highlight --force -f -I -X -S $EXTENSION 2>/dev/null
diff --git a/shared.c b/shared.c
index d7b2d5a..9362d21 100644
--- a/shared.c
+++ b/shared.c
@@ -401,5 +401,5 @@ int cgit_close_filter(struct cgit_filter *filter)
 int readfile(const char *path, char **buf, size_t *size)
 {
-        int fd;
+        int fd, e;
         struct stat st;
 
@@ -407,11 +407,18 @@ int readfile(const char *path, char **buf, size_t *size)
         if (fd == -1)
                 return errno;
-        if (fstat(fd, &st))
-                return errno;
-        if (!S_ISREG(st.st_mode))
+        if (fstat(fd, &st)) {
+                e = errno;
+                close(fd);
+                return e;
+        }
+        if (!S_ISREG(st.st_mode)) {
+                close(fd);
                 return EISDIR;
+        }
         *buf = xmalloc(st.st_size + 1);
         *size = read_in_full(fd, *buf, st.st_size);
+        e = errno;
         (*buf)[*size] = '\0';
-        return (*size == st.st_size ? 0 : errno);
+        close(fd);
+        return (*size == st.st_size ? 0 : e);
 }
diff --git a/ui-repolist.c b/ui-repolist.c
index 3ef2e99..0a0b6ca 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -95,5 +95,5 @@ int is_in_url(struct cgit_repo *repo)
 void print_sort_header(const char *title, const char *sort)
 {
-        htmlf("<th class='left'><a href='./?s=%s", sort);
+        htmlf("<th class='left'><a href='%s?s=%s", cgit_rooturl(), sort);
         if (ctx.qry.search) {
                 html("&q=");
diff --git a/ui-shared.c b/ui-shared.c
index de55eff..08ea003 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -21,5 +21,5 @@ static char *http_date(time_t t)
         static char month[][4] =
                 {"Jan", "Feb", "Mar", "Apr", "May", "Jun",
-                 "Jul", "Aug", "Sep", "Oct", "Now", "Dec"};
+                 "Jul", "Aug", "Sep", "Oct", "Nov", "Dec"};
         struct tm *tm = gmtime(&t);
         return fmt("%s, %02d %s %04d %02d:%02d:%02d GMT", day[tm->tm_wday],
@@ -783,11 +783,16 @@ void cgit_print_snapshot_links(const char *repo, const char *head,
 {
         const struct cgit_snapshot_format* f;
+        char *prefix;
             char *filename;
+        unsigned char sha1[20];
 
+        if (get_sha1(fmt("refs/tags/%s", hex), sha1) == 0 &&
+            (hex[0] == 'v' || hex[0] == 'V') && isdigit(hex[1]))
+                hex++;
+        prefix = xstrdup(fmt("%s-%s", cgit_repobasename(repo), hex));
         for (f = cgit_snapshot_formats; f->suffix; f++) {
                 if (!(snapshots & f->bit))
                         continue;
-                filename = fmt("%s-%s%s", cgit_repobasename(repo), hex,
-                               f->suffix);
+                filename = fmt("%s%s", prefix, f->suffix);
                 cgit_snapshot_link(filename, NULL, NULL, NULL, NULL, filename);
                 html("<br/>");
diff --git a/ui-shared.h b/ui-shared.h
index 166246d..9ebc1f9 100644
--- a/ui-shared.h
+++ b/ui-shared.h
@@ -4,4 +4,5 @@
 extern char *cgit_httpscheme();
 extern char *cgit_hosturl();
+extern char *cgit_rooturl();
 extern char *cgit_repourl(const char *reponame);
 extern char *cgit_fileurl(const char *reponame, const char *pagename,
diff --git a/ui-tag.c b/ui-tag.c
index c2d72af..39e4cb8 100644
--- a/ui-tag.c
+++ b/ui-tag.c
@@ -31,4 +31,12 @@ static void print_tag_content(char *buf)
 }
 
+void print_download_links(char *revname)
+{
+        html("<tr><th>download</th><td class='sha1'>");
+        cgit_print_snapshot_links(ctx.qry.repo, ctx.qry.head,
+                                  revname, ctx.repo->snapshots);
+        html("</td></tr>");
+}
+
 void cgit_print_tag(char *revname)
 {
@@ -57,14 +65,14 @@ void cgit_print_tag(char *revname)
                 }
                 html("<table class='commit-info'>\n");
-                htmlf("<tr><td>Tag name</td><td>");
+                htmlf("<tr><td>tag name</td><td>");
                 html_txt(revname);
                 htmlf(" (%s)</td></tr>\n", sha1_to_hex(sha1));
                 if (info->tagger_date > 0) {
-                        html("<tr><td>Tag date</td><td>");
+                        html("<tr><td>tag date</td><td>");
                         cgit_print_date(info->tagger_date, FMT_LONGDATE, ctx.cfg.local_time);
                         html("</td></tr>\n");
                 }
                 if (info->tagger) {
-                        html("<tr><td>Tagged by</td><td>");
+                        html("<tr><td>tagged by</td><td>");
                         html_txt(info->tagger);
                         if (info->tagger_email && !ctx.cfg.noplainemail) {
@@ -74,17 +82,21 @@ void cgit_print_tag(char *revname)
                         html("</td></tr>\n");
                 }
-                html("<tr><td>Tagged object</td><td>");
+                html("<tr><td>tagged object</td><td class='sha1'>");
                 cgit_object_link(tag->tagged);
                 html("</td></tr>\n");
+                if (ctx.repo->snapshots)
+                        print_download_links(revname);
                 html("</table>\n");
                 print_tag_content(info->msg);
         } else {
                 html("<table class='commit-info'>\n");
-                htmlf("<tr><td>Tag name</td><td>");
+                htmlf("<tr><td>tag name</td><td>");
                 html_txt(revname);
                 html("</td></tr>\n");
-                html("<tr><td>Tagged object</td><td>");
+                html("<tr><td>Tagged object</td><td class='sha1'>");
                 cgit_object_link(obj);
                 html("</td></tr>\n");
+                if (ctx.repo->snapshots)
+                        print_download_links(revname);
                 html("</table>\n");
         }
diff --git a/ui-tree.c b/ui-tree.c
index f53ab64..f281937 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -108,4 +108,10 @@ static void print_object(const unsigned char *sha1, char *path, const char *base
         htmlf(")<br/>blob: %s\n", sha1_to_hex(sha1));
 
+        if (ctx.cfg.max_blob_size && size / 1024 > ctx.cfg.max_blob_size) {
+                htmlf("<div class='error'>blob size (%dKB) exceeds display size limit (%dKB).</div>",
+                                size / 1024, ctx.cfg.max_blob_size);
+                return;
+        }
+
         if (buffer_is_binary(buf, size))
                 print_binary_buffer(buf, size);