summaryrefslogtreecommitdiffabout
Unidiff
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--cgit.css6
-rwxr-xr-xtests/t0105-commit.sh2
-rw-r--r--ui-commit.c4
-rw-r--r--ui-log.h1
4 files changed, 12 insertions, 1 deletions
diff --git a/cgit.css b/cgit.css
index f844efa..957d5aa 100644
--- a/cgit.css
+++ b/cgit.css
@@ -479,48 +479,54 @@ div.footer {
479a.branch-deco { 479a.branch-deco {
480 margin: 0px 0.5em; 480 margin: 0px 0.5em;
481 padding: 0px 0.25em; 481 padding: 0px 0.25em;
482 background-color: #88ff88; 482 background-color: #88ff88;
483 border: solid 1px #007700; 483 border: solid 1px #007700;
484} 484}
485a.tag-deco { 485a.tag-deco {
486 margin: 0px 0.5em; 486 margin: 0px 0.5em;
487 padding: 0px 0.25em; 487 padding: 0px 0.25em;
488 background-color: #ffff88; 488 background-color: #ffff88;
489 border: solid 1px #777700; 489 border: solid 1px #777700;
490} 490}
491a.remote-deco { 491a.remote-deco {
492 margin: 0px 0.5em; 492 margin: 0px 0.5em;
493 padding: 0px 0.25em; 493 padding: 0px 0.25em;
494 background-color: #ccccff; 494 background-color: #ccccff;
495 border: solid 1px #000077; 495 border: solid 1px #000077;
496} 496}
497a.deco { 497a.deco {
498 margin: 0px 0.5em; 498 margin: 0px 0.5em;
499 padding: 0px 0.25em; 499 padding: 0px 0.25em;
500 background-color: #ff8888; 500 background-color: #ff8888;
501 border: solid 1px #770000; 501 border: solid 1px #770000;
502} 502}
503
504div.commit-subject a {
505 margin-left: 1em;
506 font-size: 75%;
507}
508
503table.stats { 509table.stats {
504 border: solid 1px black; 510 border: solid 1px black;
505 border-collapse: collapse; 511 border-collapse: collapse;
506} 512}
507 513
508table.stats th { 514table.stats th {
509 text-align: left; 515 text-align: left;
510 padding: 1px 0.5em; 516 padding: 1px 0.5em;
511 background-color: #eee; 517 background-color: #eee;
512 border: solid 1px black; 518 border: solid 1px black;
513} 519}
514 520
515table.stats td { 521table.stats td {
516 text-align: right; 522 text-align: right;
517 padding: 1px 0.5em; 523 padding: 1px 0.5em;
518 border: solid 1px black; 524 border: solid 1px black;
519} 525}
520 526
521table.stats td.total { 527table.stats td.total {
522 font-weight: bold; 528 font-weight: bold;
523 text-align: left; 529 text-align: left;
524} 530}
525 531
526table.stats td.sum { 532table.stats td.sum {
diff --git a/tests/t0105-commit.sh b/tests/t0105-commit.sh
index a864612..ae794c8 100755
--- a/tests/t0105-commit.sh
+++ b/tests/t0105-commit.sh
@@ -1,36 +1,36 @@
1#!/bin/sh 1#!/bin/sh
2 2
3. ./setup.sh 3. ./setup.sh
4 4
5prepare_tests "Check content on commit page" 5prepare_tests "Check content on commit page"
6 6
7run_test 'generate foo/commit' 'cgit_url "foo/commit" >trash/tmp' 7run_test 'generate foo/commit' 'cgit_url "foo/commit" >trash/tmp'
8run_test 'find tree link' 'grep -e "<a href=./foo/tree/.>" trash/tmp' 8run_test 'find tree link' 'grep -e "<a href=./foo/tree/.>" trash/tmp'
9run_test 'find parent link' 'grep -E "<a href=./foo/commit/\?id=.+>" trash/tmp' 9run_test 'find parent link' 'grep -E "<a href=./foo/commit/\?id=.+>" trash/tmp'
10 10
11run_test 'find commit subject' ' 11run_test 'find commit subject' '
12 grep -e "<div class=.commit-subject.>commit 5</div>" trash/tmp 12 grep -e "<div class=.commit-subject.>commit 5<" trash/tmp
13' 13'
14 14
15run_test 'find commit msg' 'grep -e "<div class=.commit-msg.></div>" trash/tmp' 15run_test 'find commit msg' 'grep -e "<div class=.commit-msg.></div>" trash/tmp'
16run_test 'find diffstat' 'grep -e "<table summary=.diffstat. class=.diffstat.>" trash/tmp' 16run_test 'find diffstat' 'grep -e "<table summary=.diffstat. class=.diffstat.>" trash/tmp'
17 17
18run_test 'find diff summary' ' 18run_test 'find diff summary' '
19 grep -e "1 files changed, 1 insertions, 0 deletions" trash/tmp 19 grep -e "1 files changed, 1 insertions, 0 deletions" trash/tmp
20' 20'
21 21
22run_test 'get root commit' ' 22run_test 'get root commit' '
23 root=$(cd trash/repos/foo && git rev-list --reverse HEAD | head -1) && 23 root=$(cd trash/repos/foo && git rev-list --reverse HEAD | head -1) &&
24 cgit_url "foo/commit&id=$root" >trash/tmp && 24 cgit_url "foo/commit&id=$root" >trash/tmp &&
25 grep "</html>" trash/tmp 25 grep "</html>" trash/tmp
26' 26'
27 27
28run_test 'root commit contains diffstat' ' 28run_test 'root commit contains diffstat' '
29 grep "<a href=./foo/diff/file-1.id=[0-9a-f]\{40\}.>file-1</a>" trash/tmp 29 grep "<a href=./foo/diff/file-1.id=[0-9a-f]\{40\}.>file-1</a>" trash/tmp
30' 30'
31 31
32run_test 'root commit contains diff' ' 32run_test 'root commit contains diff' '
33 grep ">diff --git a/file-1 b/file-1<" trash/tmp && 33 grep ">diff --git a/file-1 b/file-1<" trash/tmp &&
34 grep -e "<div class=.add.>+1</div>" trash/tmp 34 grep -e "<div class=.add.>+1</div>" trash/tmp
35' 35'
36 36
diff --git a/ui-commit.c b/ui-commit.c
index a6a85a4..41ce70e 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -1,60 +1,63 @@
1/* ui-commit.c: generate commit view 1/* ui-commit.c: generate commit view
2 * 2 *
3 * Copyright (C) 2006 Lars Hjemli 3 * Copyright (C) 2006 Lars Hjemli
4 * 4 *
5 * Licensed under GNU General Public License v2 5 * Licensed under GNU General Public License v2
6 * (see COPYING for full license text) 6 * (see COPYING for full license text)
7 */ 7 */
8 8
9#include "cgit.h" 9#include "cgit.h"
10#include "html.h" 10#include "html.h"
11#include "ui-shared.h" 11#include "ui-shared.h"
12#include "ui-diff.h" 12#include "ui-diff.h"
13#include "ui-log.h"
13 14
14void cgit_print_commit(char *hex) 15void cgit_print_commit(char *hex)
15{ 16{
16 struct commit *commit, *parent; 17 struct commit *commit, *parent;
17 struct commitinfo *info; 18 struct commitinfo *info;
18 struct commit_list *p; 19 struct commit_list *p;
19 unsigned char sha1[20]; 20 unsigned char sha1[20];
20 char *tmp; 21 char *tmp;
21 int parents = 0; 22 int parents = 0;
22 23
23 if (!hex) 24 if (!hex)
24 hex = ctx.qry.head; 25 hex = ctx.qry.head;
25 26
26 if (get_sha1(hex, sha1)) { 27 if (get_sha1(hex, sha1)) {
27 cgit_print_error(fmt("Bad object id: %s", hex)); 28 cgit_print_error(fmt("Bad object id: %s", hex));
28 return; 29 return;
29 } 30 }
30 commit = lookup_commit_reference(sha1); 31 commit = lookup_commit_reference(sha1);
31 if (!commit) { 32 if (!commit) {
32 cgit_print_error(fmt("Bad commit reference: %s", hex)); 33 cgit_print_error(fmt("Bad commit reference: %s", hex));
33 return; 34 return;
34 } 35 }
35 info = cgit_parse_commit(commit); 36 info = cgit_parse_commit(commit);
36 37
38 load_ref_decorations();
39
37 html("<table summary='commit info' class='commit-info'>\n"); 40 html("<table summary='commit info' class='commit-info'>\n");
38 html("<tr><th>author</th><td>"); 41 html("<tr><th>author</th><td>");
39 html_txt(info->author); 42 html_txt(info->author);
40 html(" "); 43 html(" ");
41 html_txt(info->author_email); 44 html_txt(info->author_email);
42 html("</td><td class='right'>"); 45 html("</td><td class='right'>");
43 cgit_print_date(info->author_date, FMT_LONGDATE, ctx.cfg.local_time); 46 cgit_print_date(info->author_date, FMT_LONGDATE, ctx.cfg.local_time);
44 html("</td></tr>\n"); 47 html("</td></tr>\n");
45 html("<tr><th>committer</th><td>"); 48 html("<tr><th>committer</th><td>");
46 html_txt(info->committer); 49 html_txt(info->committer);
47 html(" "); 50 html(" ");
48 html_txt(info->committer_email); 51 html_txt(info->committer_email);
49 html("</td><td class='right'>"); 52 html("</td><td class='right'>");
50 cgit_print_date(info->committer_date, FMT_LONGDATE, ctx.cfg.local_time); 53 cgit_print_date(info->committer_date, FMT_LONGDATE, ctx.cfg.local_time);
51 html("</td></tr>\n"); 54 html("</td></tr>\n");
52 html("<tr><th>commit</th><td colspan='2' class='sha1'>"); 55 html("<tr><th>commit</th><td colspan='2' class='sha1'>");
53 tmp = sha1_to_hex(commit->object.sha1); 56 tmp = sha1_to_hex(commit->object.sha1);
54 cgit_commit_link(tmp, NULL, NULL, ctx.qry.head, tmp); 57 cgit_commit_link(tmp, NULL, NULL, ctx.qry.head, tmp);
55 html(" ("); 58 html(" (");
56 cgit_patch_link("patch", NULL, NULL, NULL, tmp); 59 cgit_patch_link("patch", NULL, NULL, NULL, tmp);
57 html(")</td></tr>\n"); 60 html(")</td></tr>\n");
58 html("<tr><th>tree</th><td colspan='2' class='sha1'>"); 61 html("<tr><th>tree</th><td colspan='2' class='sha1'>");
59 tmp = xstrdup(hex); 62 tmp = xstrdup(hex);
60 cgit_tree_link(sha1_to_hex(commit->tree->object.sha1), NULL, NULL, 63 cgit_tree_link(sha1_to_hex(commit->tree->object.sha1), NULL, NULL,
@@ -66,37 +69,38 @@ void cgit_print_commit(char *hex)
66 html("<tr><td colspan='3'>"); 69 html("<tr><td colspan='3'>");
67 cgit_print_error("Error reading parent commit"); 70 cgit_print_error("Error reading parent commit");
68 html("</td></tr>"); 71 html("</td></tr>");
69 continue; 72 continue;
70 } 73 }
71 html("<tr><th>parent</th>" 74 html("<tr><th>parent</th>"
72 "<td colspan='2' class='sha1'>"); 75 "<td colspan='2' class='sha1'>");
73 cgit_commit_link(sha1_to_hex(p->item->object.sha1), NULL, NULL, 76 cgit_commit_link(sha1_to_hex(p->item->object.sha1), NULL, NULL,
74 ctx.qry.head, sha1_to_hex(p->item->object.sha1)); 77 ctx.qry.head, sha1_to_hex(p->item->object.sha1));
75 html(" ("); 78 html(" (");
76 cgit_diff_link("diff", NULL, NULL, ctx.qry.head, hex, 79 cgit_diff_link("diff", NULL, NULL, ctx.qry.head, hex,
77 sha1_to_hex(p->item->object.sha1), NULL); 80 sha1_to_hex(p->item->object.sha1), NULL);
78 html(")</td></tr>"); 81 html(")</td></tr>");
79 parents++; 82 parents++;
80 } 83 }
81 if (ctx.repo->snapshots) { 84 if (ctx.repo->snapshots) {
82 html("<tr><th>download</th><td colspan='2' class='sha1'>"); 85 html("<tr><th>download</th><td colspan='2' class='sha1'>");
83 cgit_print_snapshot_links(ctx.qry.repo, ctx.qry.head, 86 cgit_print_snapshot_links(ctx.qry.repo, ctx.qry.head,
84 hex, ctx.repo->snapshots); 87 hex, ctx.repo->snapshots);
85 html("</td></tr>"); 88 html("</td></tr>");
86 } 89 }
87 html("</table>\n"); 90 html("</table>\n");
88 html("<div class='commit-subject'>"); 91 html("<div class='commit-subject'>");
89 html_txt(info->subject); 92 html_txt(info->subject);
93 show_commit_decorations(commit);
90 html("</div>"); 94 html("</div>");
91 html("<div class='commit-msg'>"); 95 html("<div class='commit-msg'>");
92 html_txt(info->msg); 96 html_txt(info->msg);
93 html("</div>"); 97 html("</div>");
94 if (parents < 3) { 98 if (parents < 3) {
95 if (parents) 99 if (parents)
96 tmp = sha1_to_hex(commit->parents->item->object.sha1); 100 tmp = sha1_to_hex(commit->parents->item->object.sha1);
97 else 101 else
98 tmp = NULL; 102 tmp = NULL;
99 cgit_print_diff(ctx.qry.sha1, tmp, NULL); 103 cgit_print_diff(ctx.qry.sha1, tmp, NULL);
100 } 104 }
101 cgit_free_commitinfo(info); 105 cgit_free_commitinfo(info);
102} 106}
diff --git a/ui-log.h b/ui-log.h
index 877e40e..6034055 100644
--- a/ui-log.h
+++ b/ui-log.h
@@ -1,7 +1,8 @@
1#ifndef UI_LOG_H 1#ifndef UI_LOG_H
2#define UI_LOG_H 2#define UI_LOG_H
3 3
4extern void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, 4extern void cgit_print_log(const char *tip, int ofs, int cnt, char *grep,
5 char *pattern, char *path, int pager); 5 char *pattern, char *path, int pager);
6extern void show_commit_decorations(struct commit *commit);
6 7
7#endif /* UI_LOG_H */ 8#endif /* UI_LOG_H */