| -rw-r--r-- | ui-commit.c | 17 | ||||
| -rw-r--r-- | ui-log.c | 4 | ||||
| -rw-r--r-- | ui-summary.c | 8 |
3 files changed, 18 insertions, 11 deletions
diff --git a/ui-commit.c b/ui-commit.c index f654208..8916212 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -10,26 +10,24 @@ void cgit_print_commit(const char *hex) { struct commit *commit; struct commitinfo *info; struct commit_list *p; - unsigned char sha1[20]; + char *query; if (get_sha1(hex, sha1)) { cgit_print_error(fmt("Bad object id: %s", hex)); return; } - commit = lookup_commit_reference(sha1); if (!commit) { cgit_print_error(fmt("Bad commit reference: %s", hex)); return; } - info = cgit_parse_commit(commit); html("<table class='commit-info'>\n"); html("<tr><th>author</th><td>"); html_txt(info->author); html(" "); @@ -42,18 +40,21 @@ void cgit_print_commit(const char *hex) html(" "); html_txt(info->committer_email); html("</td><td class='right'>"); cgit_print_date(info->committer_date); html("</td></tr>\n"); html("<tr><th>tree</th><td colspan='2' class='sha1'><a href='"); - html_attr(cgit_pageurl(cgit_query_repo, "tree", fmt("id=%s", sha1_to_hex(commit->tree->object.sha1)))); + query = fmt("id=%s", sha1_to_hex(commit->tree->object.sha1)); + html_attr(cgit_pageurl(cgit_query_repo, "tree", query)); htmlf("'>%s</a></td></tr>\n", sha1_to_hex(commit->tree->object.sha1)); - - for (p = commit->parents; p ; p = p->next) { - html("<tr><th>parent</th><td colspan='2' class='sha1'><a href='"); - html_attr(cgit_pageurl(cgit_query_repo, "commit", fmt("id=%s", sha1_to_hex(p->item->object.sha1)))); + for (p = commit->parents; p ; p = p->next) { + html("<tr><th>parent</th>" + "<td colspan='2' class='sha1'>" + "<a href='"); + query = fmt("id=%s", sha1_to_hex(p->item->object.sha1)); + html_attr(cgit_pageurl(cgit_query_repo, "commit", query)); htmlf("'>%s</a></td></tr>\n", sha1_to_hex(p->item->object.sha1)); } html("</table>\n"); html("<div class='commit-subject'>"); html_txt(info->subject); @@ -46,13 +46,15 @@ void cgit_print_log(const char *tip, int ofs, int cnt) rev.show_root_diff = 0; setup_revisions(2, argv, &rev, NULL); prepare_revision_walk(&rev); html("<h2>Log</h2>"); html("<table class='list log'>"); - html("<tr><th class='left'>Date</th><th class='left'>Message</th><th class='left'>Author</th></tr>\n"); + html("<tr><th class='left'>Date</th>" + "<th class='left'>Message</th>" + "<th class='left'>Author</th></tr>\n"); if (ofs<0) ofs = 0; for (i = 0; i < ofs && (commit = get_revision(&rev)) != NULL; i++) { free(commit->buffer); diff --git a/ui-summary.c b/ui-summary.c index 5ddeee3..638c8f6 100644 --- a/ui-summary.c +++ b/ui-summary.c @@ -25,13 +25,14 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1, strncpy(buf, refname, sizeof(buf)); html_txt(buf); html_link_close(); html("</td><td>"); cgit_print_date(commit->date); html("</td><td>"); - url = cgit_pageurl(cgit_query_repo, "commit", fmt("id=%s", sha1_to_hex(sha1))); + url = cgit_pageurl(cgit_query_repo, "commit", + fmt("id=%s", sha1_to_hex(sha1))); html_link_open(url, NULL, NULL); html_txt(info->subject); html_link_close(); html("</td><td>"); html_txt(info->author); html("</td></tr>\n"); @@ -46,13 +47,16 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1, return 0; } static void cgit_print_branches() { html("<table class='list'>"); - html("<tr><th class='left'>Branch</th><th class='left'>Updated</th><th class='left'>Commit subject</th><th class='left'>Author</th></tr>\n"); + html("<tr><th class='left'>Branch</th>" + "<th class='left'>Updated</th>" + "<th class='left'>Commit subject</th>" + "<th class='left'>Author</th></tr>\n"); for_each_branch_ref(cgit_print_branch_cb, NULL); html("</table>"); } void cgit_print_summary() { |