summaryrefslogtreecommitdiffabout
Unidiff
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--cgit.h2
-rw-r--r--shared.c10
-rw-r--r--ui-commit.c5
-rw-r--r--ui-log.c5
-rw-r--r--ui-summary.c1
5 files changed, 15 insertions, 8 deletions
diff --git a/cgit.h b/cgit.h
index f06a941..02cc26a 100644
--- a/cgit.h
+++ b/cgit.h
@@ -62,12 +62,14 @@ extern int cgit_query_ofs;
62extern int htmlfd; 62extern int htmlfd;
63 63
64extern void cgit_global_config_cb(const char *name, const char *value); 64extern void cgit_global_config_cb(const char *name, const char *value);
65extern void cgit_repo_config_cb(const char *name, const char *value); 65extern void cgit_repo_config_cb(const char *name, const char *value);
66extern void cgit_querystring_cb(const char *name, const char *value); 66extern void cgit_querystring_cb(const char *name, const char *value);
67 67
68extern void *cgit_free_commitinfo(struct commitinfo *info);
69
68extern char *fmt(const char *format,...); 70extern char *fmt(const char *format,...);
69 71
70extern void html(const char *txt); 72extern void html(const char *txt);
71extern void htmlf(const char *format,...); 73extern void htmlf(const char *format,...);
72extern void html_txt(char *txt); 74extern void html_txt(char *txt);
73extern void html_attr(char *txt); 75extern void html_attr(char *txt);
diff --git a/shared.c b/shared.c
index 4574120..b576df8 100644
--- a/shared.c
+++ b/shared.c
@@ -85,6 +85,16 @@ void cgit_querystring_cb(const char *name, const char *value)
85 cgit_query_has_sha1 = 1; 85 cgit_query_has_sha1 = 1;
86 } else if (!strcmp(name, "ofs")) { 86 } else if (!strcmp(name, "ofs")) {
87 cgit_query_ofs = atoi(value); 87 cgit_query_ofs = atoi(value);
88 } 88 }
89} 89}
90 90
91void *cgit_free_commitinfo(struct commitinfo *info)
92{
93 free(info->author);
94 free(info->author_email);
95 free(info->committer);
96 free(info->committer_email);
97 free(info->subject);
98 free(info);
99 return NULL;
100}
diff --git a/ui-commit.c b/ui-commit.c
index b441e14..f654208 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -58,11 +58,8 @@ void cgit_print_commit(const char *hex)
58 html("<div class='commit-subject'>"); 58 html("<div class='commit-subject'>");
59 html_txt(info->subject); 59 html_txt(info->subject);
60 html("</div>"); 60 html("</div>");
61 html("<div class='commit-msg'>"); 61 html("<div class='commit-msg'>");
62 html_txt(info->msg); 62 html_txt(info->msg);
63 html("</div>"); 63 html("</div>");
64 free(info->author); 64 cgit_free_commitinfo(info);
65 free(info->committer);
66 free(info->subject);
67 free(info);
68} 65}
diff --git a/ui-log.c b/ui-log.c
index c52af79..b7da49f 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -25,16 +25,13 @@ void print_commit(struct commit *commit)
25 html_link_open(url, NULL, NULL); 25 html_link_open(url, NULL, NULL);
26 html_txt(info->subject); 26 html_txt(info->subject);
27 html_link_close(); 27 html_link_close();
28 html("</td><td>"); 28 html("</td><td>");
29 html_txt(info->author); 29 html_txt(info->author);
30 html("</td></tr>\n"); 30 html("</td></tr>\n");
31 free(info->author); 31 cgit_free_commitinfo(info);
32 free(info->committer);
33 free(info->subject);
34 free(info);
35} 32}
36 33
37 34
38void cgit_print_log(const char *tip, int ofs, int cnt) 35void cgit_print_log(const char *tip, int ofs, int cnt)
39{ 36{
40 struct rev_info rev; 37 struct rev_info rev;
diff --git a/ui-summary.c b/ui-summary.c
index 8ff3642..5ddeee3 100644
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -32,12 +32,13 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1,
32 html_link_open(url, NULL, NULL); 32 html_link_open(url, NULL, NULL);
33 html_txt(info->subject); 33 html_txt(info->subject);
34 html_link_close(); 34 html_link_close();
35 html("</td><td>"); 35 html("</td><td>");
36 html_txt(info->author); 36 html_txt(info->author);
37 html("</td></tr>\n"); 37 html("</td></tr>\n");
38 cgit_free_commitinfo(info);
38 } else { 39 } else {
39 html("<tr><td>"); 40 html("<tr><td>");
40 html_txt(buf); 41 html_txt(buf);
41 html("</td><td>"); 42 html("</td><td>");
42 htmlf("*** bad ref %s", sha1_to_hex(sha1)); 43 htmlf("*** bad ref %s", sha1_to_hex(sha1));
43 html("</td></tr>\n"); 44 html("</td></tr>\n");