|
diff --git a/ui-diff.c b/ui-diff.c index e0a72f7..0dcabe9 100644 --- a/ ui-diff.c+++ b/ ui-diff.c |
|
@@ -82,144 +82,150 @@ static void print_fileinfo(struct fileinfo *info) |
82 | html("<span class='modechange'>["); |
82 | html("<span class='modechange'>["); |
83 | cgit_print_filemode(info->old_mode); |
83 | cgit_print_filemode(info->old_mode); |
84 | html("]</span>"); |
84 | html("]</span>"); |
85 | } |
85 | } |
86 | htmlf("</td><td class='%s'>", class); |
86 | htmlf("</td><td class='%s'>", class); |
87 | cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
87 | cgit_diff_link(info->new_path, NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
88 | ctx.qry.sha2, info->new_path, 0); |
88 | ctx.qry.sha2, info->new_path, 0); |
89 | if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) |
89 | if (info->status == DIFF_STATUS_COPIED || info->status == DIFF_STATUS_RENAMED) |
90 | htmlf(" (%s from %s)", |
90 | htmlf(" (%s from %s)", |
91 | info->status == DIFF_STATUS_COPIED ? "copied" : "renamed", |
91 | info->status == DIFF_STATUS_COPIED ? "copied" : "renamed", |
92 | info->old_path); |
92 | info->old_path); |
93 | html("</td><td class='right'>"); |
93 | html("</td><td class='right'>"); |
94 | if (info->binary) { |
94 | if (info->binary) { |
95 | htmlf("bin</td><td class='graph'>%d -> %d bytes", |
95 | htmlf("bin</td><td class='graph'>%d -> %d bytes", |
96 | info->old_size, info->new_size); |
96 | info->old_size, info->new_size); |
97 | return; |
97 | return; |
98 | } |
98 | } |
99 | htmlf("%d", info->added + info->removed); |
99 | htmlf("%d", info->added + info->removed); |
100 | html("</td><td class='graph'>"); |
100 | html("</td><td class='graph'>"); |
101 | htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); |
101 | htmlf("<table summary='file diffstat' width='%d%%'><tr>", (max_changes > 100 ? 100 : max_changes)); |
102 | htmlf("<td class='add' style='width: %.1f%%;'/>", |
102 | htmlf("<td class='add' style='width: %.1f%%;'/>", |
103 | info->added * 100.0 / max_changes); |
103 | info->added * 100.0 / max_changes); |
104 | htmlf("<td class='rem' style='width: %.1f%%;'/>", |
104 | htmlf("<td class='rem' style='width: %.1f%%;'/>", |
105 | info->removed * 100.0 / max_changes); |
105 | info->removed * 100.0 / max_changes); |
106 | htmlf("<td class='none' style='width: %.1f%%;'/>", |
106 | htmlf("<td class='none' style='width: %.1f%%;'/>", |
107 | (max_changes - info->removed - info->added) * 100.0 / max_changes); |
107 | (max_changes - info->removed - info->added) * 100.0 / max_changes); |
108 | html("</tr></table></td></tr>\n"); |
108 | html("</tr></table></td></tr>\n"); |
109 | } |
109 | } |
110 | |
110 | |
111 | static void count_diff_lines(char *line, int len) |
111 | static void count_diff_lines(char *line, int len) |
112 | { |
112 | { |
113 | if (line && (len > 0)) { |
113 | if (line && (len > 0)) { |
114 | if (line[0] == '+') |
114 | if (line[0] == '+') |
115 | lines_added++; |
115 | lines_added++; |
116 | else if (line[0] == '-') |
116 | else if (line[0] == '-') |
117 | lines_removed++; |
117 | lines_removed++; |
118 | } |
118 | } |
119 | } |
119 | } |
120 | |
120 | |
121 | static void inspect_filepair(struct diff_filepair *pair) |
121 | static void inspect_filepair(struct diff_filepair *pair) |
122 | { |
122 | { |
123 | int binary = 0; |
123 | int binary = 0; |
124 | unsigned long old_size = 0; |
124 | unsigned long old_size = 0; |
125 | unsigned long new_size = 0; |
125 | unsigned long new_size = 0; |
126 | files++; |
126 | files++; |
127 | lines_added = 0; |
127 | lines_added = 0; |
128 | lines_removed = 0; |
128 | lines_removed = 0; |
129 | cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, &new_size, |
129 | cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, &new_size, |
130 | &binary, 0, count_diff_lines); |
130 | &binary, 0, ctx.qry.ignorews, count_diff_lines); |
131 | if (files >= slots) { |
131 | if (files >= slots) { |
132 | if (slots == 0) |
132 | if (slots == 0) |
133 | slots = 4; |
133 | slots = 4; |
134 | else |
134 | else |
135 | slots = slots * 2; |
135 | slots = slots * 2; |
136 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
136 | items = xrealloc(items, slots * sizeof(struct fileinfo)); |
137 | } |
137 | } |
138 | items[files-1].status = pair->status; |
138 | items[files-1].status = pair->status; |
139 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
139 | hashcpy(items[files-1].old_sha1, pair->one->sha1); |
140 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
140 | hashcpy(items[files-1].new_sha1, pair->two->sha1); |
141 | items[files-1].old_mode = pair->one->mode; |
141 | items[files-1].old_mode = pair->one->mode; |
142 | items[files-1].new_mode = pair->two->mode; |
142 | items[files-1].new_mode = pair->two->mode; |
143 | items[files-1].old_path = xstrdup(pair->one->path); |
143 | items[files-1].old_path = xstrdup(pair->one->path); |
144 | items[files-1].new_path = xstrdup(pair->two->path); |
144 | items[files-1].new_path = xstrdup(pair->two->path); |
145 | items[files-1].added = lines_added; |
145 | items[files-1].added = lines_added; |
146 | items[files-1].removed = lines_removed; |
146 | items[files-1].removed = lines_removed; |
147 | items[files-1].old_size = old_size; |
147 | items[files-1].old_size = old_size; |
148 | items[files-1].new_size = new_size; |
148 | items[files-1].new_size = new_size; |
149 | items[files-1].binary = binary; |
149 | items[files-1].binary = binary; |
150 | if (lines_added + lines_removed > max_changes) |
150 | if (lines_added + lines_removed > max_changes) |
151 | max_changes = lines_added + lines_removed; |
151 | max_changes = lines_added + lines_removed; |
152 | total_adds += lines_added; |
152 | total_adds += lines_added; |
153 | total_rems += lines_removed; |
153 | total_rems += lines_removed; |
154 | } |
154 | } |
155 | |
155 | |
156 | void cgit_print_diffstat(const unsigned char *old_sha1, |
156 | void cgit_print_diffstat(const unsigned char *old_sha1, |
157 | const unsigned char *new_sha1, const char *prefix) |
157 | const unsigned char *new_sha1, const char *prefix) |
158 | { |
158 | { |
159 | int i, save_context = ctx.qry.context; |
159 | int i, save_context = ctx.qry.context; |
160 | |
160 | |
161 | html("<div class='diffstat-header'>"); |
161 | html("<div class='diffstat-header'>"); |
162 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
162 | cgit_diff_link("Diffstat", NULL, NULL, ctx.qry.head, ctx.qry.sha1, |
163 | ctx.qry.sha2, NULL, 0); |
163 | ctx.qry.sha2, NULL, 0); |
164 | if (prefix) |
164 | if (prefix) |
165 | htmlf(" (limited to '%s')", prefix); |
165 | htmlf(" (limited to '%s')", prefix); |
166 | html(" ("); |
166 | html(" ("); |
167 | ctx.qry.context = (save_context > 0 ? save_context : 3) << 1; |
167 | ctx.qry.context = (save_context > 0 ? save_context : 3) << 1; |
168 | cgit_self_link("more", NULL, NULL, &ctx); |
168 | cgit_self_link("more", NULL, NULL, &ctx); |
169 | html("/"); |
169 | html("/"); |
170 | ctx.qry.context = (save_context > 3 ? save_context : 3) >> 1; |
170 | ctx.qry.context = (save_context > 3 ? save_context : 3) >> 1; |
171 | cgit_self_link("less", NULL, NULL, &ctx); |
171 | cgit_self_link("less", NULL, NULL, &ctx); |
172 | ctx.qry.context = save_context; |
172 | ctx.qry.context = save_context; |
173 | html(" context)"); |
173 | html(" context)"); |
| |
174 | html(" ("); |
| |
175 | ctx.qry.ignorews = (ctx.qry.ignorews + 1) % 2; |
| |
176 | cgit_self_link(ctx.qry.ignorews ? "ignore" : "show", NULL, NULL, &ctx); |
| |
177 | ctx.qry.ignorews = (ctx.qry.ignorews + 1) % 2; |
| |
178 | html(" whitespace changes)"); |
174 | html("</div>"); |
179 | html("</div>"); |
175 | html("<table summary='diffstat' class='diffstat'>"); |
180 | html("<table summary='diffstat' class='diffstat'>"); |
176 | max_changes = 0; |
181 | max_changes = 0; |
177 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix); |
182 | cgit_diff_tree(old_sha1, new_sha1, inspect_filepair, prefix, |
| |
183 | ctx.qry.ignorews); |
178 | for(i = 0; i<files; i++) |
184 | for(i = 0; i<files; i++) |
179 | print_fileinfo(&items[i]); |
185 | print_fileinfo(&items[i]); |
180 | html("</table>"); |
186 | html("</table>"); |
181 | html("<div class='diffstat-summary'>"); |
187 | html("<div class='diffstat-summary'>"); |
182 | htmlf("%d files changed, %d insertions, %d deletions", |
188 | htmlf("%d files changed, %d insertions, %d deletions", |
183 | files, total_adds, total_rems); |
189 | files, total_adds, total_rems); |
184 | html("</div>"); |
190 | html("</div>"); |
185 | } |
191 | } |
186 | |
192 | |
187 | |
193 | |
188 | /* |
194 | /* |
189 | * print a single line returned from xdiff |
195 | * print a single line returned from xdiff |
190 | */ |
196 | */ |
191 | static void print_line(char *line, int len) |
197 | static void print_line(char *line, int len) |
192 | { |
198 | { |
193 | char *class = "ctx"; |
199 | char *class = "ctx"; |
194 | char c = line[len-1]; |
200 | char c = line[len-1]; |
195 | |
201 | |
196 | if (line[0] == '+') |
202 | if (line[0] == '+') |
197 | class = "add"; |
203 | class = "add"; |
198 | else if (line[0] == '-') |
204 | else if (line[0] == '-') |
199 | class = "del"; |
205 | class = "del"; |
200 | else if (line[0] == '@') |
206 | else if (line[0] == '@') |
201 | class = "hunk"; |
207 | class = "hunk"; |
202 | |
208 | |
203 | htmlf("<div class='%s'>", class); |
209 | htmlf("<div class='%s'>", class); |
204 | line[len-1] = '\0'; |
210 | line[len-1] = '\0'; |
205 | html_txt(line); |
211 | html_txt(line); |
206 | html("</div>"); |
212 | html("</div>"); |
207 | line[len-1] = c; |
213 | line[len-1] = c; |
208 | } |
214 | } |
209 | |
215 | |
210 | static void header(unsigned char *sha1, char *path1, int mode1, |
216 | static void header(unsigned char *sha1, char *path1, int mode1, |
211 | unsigned char *sha2, char *path2, int mode2) |
217 | unsigned char *sha2, char *path2, int mode2) |
212 | { |
218 | { |
213 | char *abbrev1, *abbrev2; |
219 | char *abbrev1, *abbrev2; |
214 | int subproject; |
220 | int subproject; |
215 | |
221 | |
216 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); |
222 | subproject = (S_ISGITLINK(mode1) || S_ISGITLINK(mode2)); |
217 | html("<div class='head'>"); |
223 | html("<div class='head'>"); |
218 | html("diff --git a/"); |
224 | html("diff --git a/"); |
219 | html_txt(path1); |
225 | html_txt(path1); |
220 | html(" b/"); |
226 | html(" b/"); |
221 | html_txt(path2); |
227 | html_txt(path2); |
222 | |
228 | |
223 | if (is_null_sha1(sha1)) |
229 | if (is_null_sha1(sha1)) |
224 | path1 = "dev/null"; |
230 | path1 = "dev/null"; |
225 | if (is_null_sha1(sha2)) |
231 | if (is_null_sha1(sha2)) |
@@ -251,113 +257,115 @@ static void header(unsigned char *sha1, char *path1, int mode1, |
251 | html("<br/>+++ b/"); |
257 | html("<br/>+++ b/"); |
252 | if (mode2 != 0) |
258 | if (mode2 != 0) |
253 | cgit_tree_link(path2, NULL, NULL, ctx.qry.head, |
259 | cgit_tree_link(path2, NULL, NULL, ctx.qry.head, |
254 | sha1_to_hex(new_rev_sha1), path2); |
260 | sha1_to_hex(new_rev_sha1), path2); |
255 | else |
261 | else |
256 | html_txt(path2); |
262 | html_txt(path2); |
257 | } |
263 | } |
258 | html("</div>"); |
264 | html("</div>"); |
259 | } |
265 | } |
260 | |
266 | |
261 | static void print_ssdiff_link() |
267 | static void print_ssdiff_link() |
262 | { |
268 | { |
263 | if (!strcmp(ctx.qry.page, "diff")) { |
269 | if (!strcmp(ctx.qry.page, "diff")) { |
264 | if (use_ssdiff) |
270 | if (use_ssdiff) |
265 | cgit_diff_link("Unidiff", NULL, NULL, ctx.qry.head, |
271 | cgit_diff_link("Unidiff", NULL, NULL, ctx.qry.head, |
266 | ctx.qry.sha1, ctx.qry.sha2, ctx.qry.path, 1); |
272 | ctx.qry.sha1, ctx.qry.sha2, ctx.qry.path, 1); |
267 | else |
273 | else |
268 | cgit_diff_link("Side-by-side diff", NULL, NULL, |
274 | cgit_diff_link("Side-by-side diff", NULL, NULL, |
269 | ctx.qry.head, ctx.qry.sha1, |
275 | ctx.qry.head, ctx.qry.sha1, |
270 | ctx.qry.sha2, ctx.qry.path, 1); |
276 | ctx.qry.sha2, ctx.qry.path, 1); |
271 | } |
277 | } |
272 | } |
278 | } |
273 | |
279 | |
274 | static void filepair_cb(struct diff_filepair *pair) |
280 | static void filepair_cb(struct diff_filepair *pair) |
275 | { |
281 | { |
276 | unsigned long old_size = 0; |
282 | unsigned long old_size = 0; |
277 | unsigned long new_size = 0; |
283 | unsigned long new_size = 0; |
278 | int binary = 0; |
284 | int binary = 0; |
279 | linediff_fn print_line_fn = print_line; |
285 | linediff_fn print_line_fn = print_line; |
280 | |
286 | |
281 | if (use_ssdiff) { |
287 | if (use_ssdiff) { |
282 | cgit_ssdiff_header_begin(); |
288 | cgit_ssdiff_header_begin(); |
283 | print_line_fn = cgit_ssdiff_line_cb; |
289 | print_line_fn = cgit_ssdiff_line_cb; |
284 | } |
290 | } |
285 | header(pair->one->sha1, pair->one->path, pair->one->mode, |
291 | header(pair->one->sha1, pair->one->path, pair->one->mode, |
286 | pair->two->sha1, pair->two->path, pair->two->mode); |
292 | pair->two->sha1, pair->two->path, pair->two->mode); |
287 | if (use_ssdiff) |
293 | if (use_ssdiff) |
288 | cgit_ssdiff_header_end(); |
294 | cgit_ssdiff_header_end(); |
289 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { |
295 | if (S_ISGITLINK(pair->one->mode) || S_ISGITLINK(pair->two->mode)) { |
290 | if (S_ISGITLINK(pair->one->mode)) |
296 | if (S_ISGITLINK(pair->one->mode)) |
291 | print_line_fn(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); |
297 | print_line_fn(fmt("-Subproject %s", sha1_to_hex(pair->one->sha1)), 52); |
292 | if (S_ISGITLINK(pair->two->mode)) |
298 | if (S_ISGITLINK(pair->two->mode)) |
293 | print_line_fn(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); |
299 | print_line_fn(fmt("+Subproject %s", sha1_to_hex(pair->two->sha1)), 52); |
294 | if (use_ssdiff) |
300 | if (use_ssdiff) |
295 | cgit_ssdiff_footer(); |
301 | cgit_ssdiff_footer(); |
296 | return; |
302 | return; |
297 | } |
303 | } |
298 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, |
304 | if (cgit_diff_files(pair->one->sha1, pair->two->sha1, &old_size, |
299 | &new_size, &binary, ctx.qry.context, print_line_fn)) |
305 | &new_size, &binary, ctx.qry.context, |
| |
306 | ctx.qry.ignorews, print_line_fn)) |
300 | cgit_print_error("Error running diff"); |
307 | cgit_print_error("Error running diff"); |
301 | if (binary) { |
308 | if (binary) { |
302 | if (use_ssdiff) |
309 | if (use_ssdiff) |
303 | html("<tr><td colspan='4'>Binary files differ</td></tr>"); |
310 | html("<tr><td colspan='4'>Binary files differ</td></tr>"); |
304 | else |
311 | else |
305 | html("Binary files differ"); |
312 | html("Binary files differ"); |
306 | } |
313 | } |
307 | if (use_ssdiff) |
314 | if (use_ssdiff) |
308 | cgit_ssdiff_footer(); |
315 | cgit_ssdiff_footer(); |
309 | } |
316 | } |
310 | |
317 | |
311 | void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) |
318 | void cgit_print_diff(const char *new_rev, const char *old_rev, const char *prefix) |
312 | { |
319 | { |
313 | enum object_type type; |
320 | enum object_type type; |
314 | unsigned long size; |
321 | unsigned long size; |
315 | struct commit *commit, *commit2; |
322 | struct commit *commit, *commit2; |
316 | |
323 | |
317 | if (!new_rev) |
324 | if (!new_rev) |
318 | new_rev = ctx.qry.head; |
325 | new_rev = ctx.qry.head; |
319 | get_sha1(new_rev, new_rev_sha1); |
326 | get_sha1(new_rev, new_rev_sha1); |
320 | type = sha1_object_info(new_rev_sha1, &size); |
327 | type = sha1_object_info(new_rev_sha1, &size); |
321 | if (type == OBJ_BAD) { |
328 | if (type == OBJ_BAD) { |
322 | cgit_print_error(fmt("Bad object name: %s", new_rev)); |
329 | cgit_print_error(fmt("Bad object name: %s", new_rev)); |
323 | return; |
330 | return; |
324 | } |
331 | } |
325 | commit = lookup_commit_reference(new_rev_sha1); |
332 | commit = lookup_commit_reference(new_rev_sha1); |
326 | if (!commit || parse_commit(commit)) |
333 | if (!commit || parse_commit(commit)) |
327 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); |
334 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(new_rev_sha1))); |
328 | |
335 | |
329 | if (old_rev) |
336 | if (old_rev) |
330 | get_sha1(old_rev, old_rev_sha1); |
337 | get_sha1(old_rev, old_rev_sha1); |
331 | else if (commit->parents && commit->parents->item) |
338 | else if (commit->parents && commit->parents->item) |
332 | hashcpy(old_rev_sha1, commit->parents->item->object.sha1); |
339 | hashcpy(old_rev_sha1, commit->parents->item->object.sha1); |
333 | else |
340 | else |
334 | hashclr(old_rev_sha1); |
341 | hashclr(old_rev_sha1); |
335 | |
342 | |
336 | if (!is_null_sha1(old_rev_sha1)) { |
343 | if (!is_null_sha1(old_rev_sha1)) { |
337 | type = sha1_object_info(old_rev_sha1, &size); |
344 | type = sha1_object_info(old_rev_sha1, &size); |
338 | if (type == OBJ_BAD) { |
345 | if (type == OBJ_BAD) { |
339 | cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); |
346 | cgit_print_error(fmt("Bad object name: %s", sha1_to_hex(old_rev_sha1))); |
340 | return; |
347 | return; |
341 | } |
348 | } |
342 | commit2 = lookup_commit_reference(old_rev_sha1); |
349 | commit2 = lookup_commit_reference(old_rev_sha1); |
343 | if (!commit2 || parse_commit(commit2)) |
350 | if (!commit2 || parse_commit(commit2)) |
344 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); |
351 | cgit_print_error(fmt("Bad commit: %s", sha1_to_hex(old_rev_sha1))); |
345 | } |
352 | } |
346 | |
353 | |
347 | if ((ctx.qry.ssdiff && !ctx.cfg.ssdiff) || (!ctx.qry.ssdiff && ctx.cfg.ssdiff)) |
354 | if ((ctx.qry.ssdiff && !ctx.cfg.ssdiff) || (!ctx.qry.ssdiff && ctx.cfg.ssdiff)) |
348 | use_ssdiff = 1; |
355 | use_ssdiff = 1; |
349 | |
356 | |
350 | print_ssdiff_link(); |
357 | print_ssdiff_link(); |
351 | cgit_print_diffstat(old_rev_sha1, new_rev_sha1, prefix); |
358 | cgit_print_diffstat(old_rev_sha1, new_rev_sha1, prefix); |
352 | |
359 | |
353 | if (use_ssdiff) { |
360 | if (use_ssdiff) { |
354 | html("<table summary='ssdiff' class='ssdiff'>"); |
361 | html("<table summary='ssdiff' class='ssdiff'>"); |
355 | } else { |
362 | } else { |
356 | html("<table summary='diff' class='diff'>"); |
363 | html("<table summary='diff' class='diff'>"); |
357 | html("<tr><td>"); |
364 | html("<tr><td>"); |
358 | } |
365 | } |
359 | cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix); |
366 | cgit_diff_tree(old_rev_sha1, new_rev_sha1, filepair_cb, prefix, |
| |
367 | ctx.qry.ignorews); |
360 | if (!use_ssdiff) |
368 | if (!use_ssdiff) |
361 | html("</td></tr>"); |
369 | html("</td></tr>"); |
362 | html("</table>"); |
370 | html("</table>"); |
363 | } |
371 | } |
|