1 files changed, 24 insertions, 18 deletions

diff --git a/ui-shared.c b/ui-shared.c
index a03661a..88dd6b8 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -39,61 +39,63 @@ void cgit_print_error(char *msg)
 	html_txt(msg);
 	html("</div>\n");
 }
 
 char *cgit_rooturl()
 {
 	if (cgit_virtual_root)
 		return fmt("%s/", cgit_virtual_root);
 	else
 		return cgit_script_name;
 }
 
 char *cgit_repourl(const char *reponame)
 {
 	if (cgit_virtual_root) {
 		return fmt("%s/%s/", cgit_virtual_root, reponame);
 	} else {
 		return fmt("?r=%s", reponame);
 	}
 }
 
 char *cgit_fileurl(const char *reponame, const char *pagename,
 		   const char *filename, const char *query)
 {
+	char *tmp;
+	char *delim;
+
 	if (cgit_virtual_root) {
-		if (query)
-			return fmt("%s/%s/%s/%s?%s", cgit_virtual_root, reponame,
-				   pagename, filename?filename:"", query);
-		else
-			return fmt("%s/%s/%s/", cgit_virtual_root, reponame,
-				   pagename);
+		tmp = fmt("%s/%s/%s/%s", cgit_virtual_root, reponame,
+			  pagename, (filename ? filename:""));
+		delim = "?";
 	} else {
-		if (query)
-			return fmt("?r=%s&amp;p=%s&amp;%s", reponame, pagename, query);
-		else
-			return fmt("?r=%s&amp;p=%s", reponame, pagename);
+		tmp = fmt("?url=%s/%s/%s", reponame, pagename,
+			  (filename ? filename : ""));
+		delim = "&";
 	}
+	if (query)
+		tmp = fmt("%s%s%s", tmp, delim, query);
+	return tmp;
 }
 
 char *cgit_pageurl(const char *reponame, const char *pagename,
 		   const char *query)
 {
 	return cgit_fileurl(reponame,pagename,0,query);
 }
 
 const char *cgit_repobasename(const char *reponame)
 {
 	/* I assume we don't need to store more than one repo basename */
 	static char rvbuf[1024];
 	int p;
 	const char *rv;
 	strncpy(rvbuf,reponame,sizeof(rvbuf));
 	if(rvbuf[sizeof(rvbuf)-1])
 		die("cgit_repobasename: truncated repository name '%s'", reponame);
 	p = strlen(rvbuf)-1;
 	/* strip trailing slashes */
 	while(p && rvbuf[p]=='/') rvbuf[p--]=0;
 	/* strip trailing .git */
 	if(p>=3 && !strncmp(&rvbuf[p-3],".git",4)) {
 		p -= 3; rvbuf[p--] = 0;
 	}
@@ -400,55 +402,57 @@ int print_archive_ref(const char *refname, const unsigned char *sha1,
 		return 1;
 	if (obj->type == OBJ_TAG) {
 		tag = lookup_tag(sha1);
 		if (!tag || parse_tag(tag) || !(info = cgit_parse_tag(tag)))
 			return 0;
 		hashcpy(fileid, tag->tagged->sha1);
 	} else if (obj->type != OBJ_BLOB) {
 		return 0;
 	} else {
 		hashcpy(fileid, sha1);
 	}
 	if (!*header) {
 		html("<p><h1>download</h1>");
 		*header = 1;
 	}
 	url = cgit_pageurl(cgit_query_repo, "blob",
 			   fmt("id=%s&amp;path=%s", sha1_to_hex(fileid),
 			       buf));
 	html_link_open(url, NULL, "menu");
 	html_txt(strlpart(buf, 20));
 	html_link_close();
 	return 0;
 }
 
-void add_hidden_formfields(int incl_head, int incl_search)
+void add_hidden_formfields(int incl_head, int incl_search, char *page)
 {
+	char *url;
+
 	if (!cgit_virtual_root) {
-		if (cgit_query_repo)
-			html_hidden("r", cgit_query_repo);
-		if (cgit_query_page)
-			html_hidden("p", cgit_query_page);
+		url = fmt("%s/%s", cgit_query_repo, page);
+		if (cgit_query_path)
+			url = fmt("%s/%s", url, cgit_query_path);
+		html_hidden("url", url);
 	}
 
 	if (incl_head && strcmp(cgit_query_head, cgit_repo->defbranch))
 		html_hidden("h", cgit_query_head);
 
 	if (cgit_query_sha1)
 		html_hidden("id", cgit_query_sha1);
 	if (cgit_query_sha2)
 		html_hidden("id2", cgit_query_sha2);
 
 	if (incl_search) {
 		if (cgit_query_grep)
 			html_hidden("qt", cgit_query_grep);
 		if (cgit_query_search)
 			html_hidden("q", cgit_query_search);
 	}
 }
 
 void cgit_print_pageheader(char *title, int show_search)
 {
 	static const char *default_info = "This is cgit, a fast webinterface for git repositories";
 	int header = 0;
 
 	html("<div id='sidebar'>\n");
@@ -462,59 +466,61 @@ void cgit_print_pageheader(char *title, int show_search)
 		html_txt(strrpart(cgit_repo->name, 20));
 		html("</h1>\n");
 		html_txt(cgit_repo->desc);
 		if (cgit_repo->owner) {
 			html("<p>\n<h1>owner</h1>\n");
 			html_txt(cgit_repo->owner);
 		}
 		html("<p>\n<h1>navigate</h1>\n");
 		reporevlink(NULL, "summary", NULL, "menu", cgit_query_head,
 			    NULL, NULL);
 		cgit_log_link("log", NULL, "menu", cgit_query_head,
 			      cgit_query_sha1, cgit_query_path, 0, NULL, NULL);
 		cgit_tree_link("tree", NULL, "menu", cgit_query_head,
 			       cgit_query_sha1, NULL);
 		cgit_commit_link("commit", NULL, "menu", cgit_query_head,
 			      cgit_query_sha1);
 		cgit_diff_link("diff", NULL, "menu", cgit_query_head,
 			       cgit_query_sha1, cgit_query_sha2,
 			       cgit_query_path);
 
 		for_each_ref(print_archive_ref, &header);
 
 		html("<p>\n<h1>branch</h1>\n");
 		html("<form method='get' action=''>\n");
-		add_hidden_formfields(0, 1);
+		add_hidden_formfields(0, 1, cgit_query_page);
 		html("<select name='h' onchange='this.form.submit();'>\n");
 		for_each_branch_ref(print_branch_option, cgit_query_head);
 		html("</select>\n");
 		html("</form>\n");
 
 		html("<p>\n<h1>search</h1>\n");
 		html("<form method='get' action='");
-		html_attr(cgit_pageurl(cgit_query_repo, "log", NULL));
+		if (cgit_virtual_root)
+			html_attr(cgit_fileurl(cgit_query_repo, "log",
+					       cgit_query_path, NULL));
 		html("'>\n");
-		add_hidden_formfields(1, 0);
+		add_hidden_formfields(1, 0, "log");
 		html("<select name='qt'>\n");
 		html_option("grep", "log msg", cgit_query_grep);
 		html_option("author", "author", cgit_query_grep);
 		html_option("committer", "committer", cgit_query_grep);
 		html("</select>\n");
 		html("<input class='txt' type='text' name='q' value='");
 		html_attr(cgit_query_search);
 		html("'/>\n");
 		html("</form>\n");
 	} else {
 		if (!cgit_index_info || html_include(cgit_index_info))
 			html(default_info);
 	}
 
 	html("</div>\n");
 
 	html("</div>\n<table class='grid'><tr><td id='content'>\n");
 }
 
 
 void cgit_print_snapshot_start(const char *mimetype, const char *filename,
 			       struct cacheitem *item)
 {
 	htmlf("Content-Type: %s\n", mimetype);