fix

8 files changed, 51 insertions, 33 deletions

diff --git a/korganizer/calendarview.cpp b/korganizer/calendarview.cpp
index 28b17a5..31e103d 100644
--- a/korganizer/calendarview.cpp
+++ b/korganizer/calendarview.cpp
@@ -361,16 +361,21 @@ CalendarView::CalendarView( Calendar *calendar,
  
     mEventEditor = 0;
     mTodoEditor = 0;
     init();
 }
 
 void CalendarView::init()
 { 
+    flag_blockConflict = false; 
+    flag_blockScrollBar = false;
+    flag_checkFileFirsttime = true;
+    flag_clearallviewsEventDisplay = false;
+    flag_clearallviewsupdateView = false;
     mNextAlarmDateTime = QDateTime::currentDateTime();
     setFocusPolicy (NoFocus ); 
     mViewerCallerIsSearchDialog = false;
     mBlockShowDates = false;
     mConflictingEvent = 0;
     mDatePickerMode = 0;
     mCurrentSyncDevice = "";
     mViewManager = new KOViewManager( this );
@@ -656,19 +661,18 @@ CalendarView::~CalendarView()
     delete mDateFrame ;
     delete mEventViewerDialog;
     //kdDebug() << "~CalendarView() done" << endl;
 }
 
 
 void CalendarView::nextConflict( bool all, bool allday )
 {
-    static bool block = false;
-    if ( block ) return;
-    block = true;
+    if ( flag_blockConflict ) return;
+    flag_blockConflict = true;
     QPtrList<Event> testlist = mCalendar->events();
     Event * test = testlist.first();
     while ( test ) {
         test->setTagged( false );
         test = testlist.next();
     }
     QTime st ( 0,0,0);
     if ( mViewManager->currentView() == mViewManager->agendaView()  )
@@ -735,23 +739,23 @@ void CalendarView::nextConflict( bool all, bool allday )
     //qDebug("Search time : %d", tm.elapsed());
     if ( found ) {
         if ( mViewManager->currentView() != mViewManager->agendaView() || mNavigator->selectedDates().count() > 1 )
             mViewManager->showDayView();
         mNavigator->slotDaySelect( conflict.date() );
         int hour = conflict.time().hour();
         mViewManager->agendaView()->setStartHour( hour  );
         topLevelWidget()->setCaption( i18n("Conflict %1 <-> %2"). arg( cE->summary().left( 20 ) ).arg( cE2->summary().left( 20 ) ) );
-        block = false;
+        flag_blockConflict = false;
         return;
     }
 
     topLevelWidget()->setCaption( i18n("No conflict found") );
     //qDebug("No conflict found ");
-    block = false;
+    flag_blockConflict = false;
     return;
 }
 
 void CalendarView::conflictAll()
 {
     nextConflict ( true, true );
 }
 void CalendarView::conflictAllday()
@@ -775,37 +779,36 @@ void CalendarView::setScrollBarStep(int val )
 #ifdef DESKTOP_VERSION
     mDateScrollBar->setLineStep ( val );
 #endif
 }
 void CalendarView::scrollBarValue(int val )
 {
 #ifdef DESKTOP_VERSION
     if ( QApplication::desktop()->width() < 800 ) return;
-    static bool block = false;
-    if ( block ) return;
-    block = true;
+    if ( flag_blockScrollBar ) return;
+    flag_blockScrollBar = true;
     int count = mNavigator->selectedDates().count();
     int day = mNavigator->selectedDates().first().dayOfYear();
     int  stepdays = val;
     if ( mDateScrollBar->lineStep () <= count ) {
         //val = val/mDateScrollBar->lineStep ()*mDateScrollBar->lineStep();
         //qDebug("VAL %d ",val );
         stepdays = (val-day)/mDateScrollBar->lineStep ()*mDateScrollBar->lineStep();
         stepdays = day+stepdays;
         if ( stepdays < 0 ) stepdays = 0;
     }
     if ( stepdays == day ) {
-        block = false;
+        flag_blockScrollBar = false;
         return;
     }
     int year =  mNavigator->selectedDates().first().year();
     QDate d ( year,1,1 );
     mNavigator->selectDates( d.addDays(  stepdays-1) , count );
-    block = false;
+    flag_blockScrollBar = false;
 #endif
 
 }
 void CalendarView::updateView(const QDate &start, const QDate &end)
 {
 #ifdef DESKTOP_VERSION
     if ( ! mDateScrollBar->draggingSlider () ) {
         int dof = start.dayOfYear();
@@ -834,19 +837,18 @@ void CalendarView::checkFiles()
             message +=  cal->mName +"\n"+KGlobal::formatMessage ( "(" +i18n( "Filepath: ")+ cal->mFileName+")" ,0 )+"\n";
         }
         cal = calendars.next();
     }
     if ( !message.isEmpty() ) {
         message = KGlobal::formatMessage( i18n("Calendar(s) not loaded:"),0 )+"\n" + message +KGlobal::formatMessage(i18n("You can try to reload the calendar in the Resource View!"),0); 
         KMessageBox::error(this,message, i18n("Loading of calendar(s) failed"));
     }
-    static bool firstTime = true;
-    if ( firstTime ) {
-        firstTime = false;
+    if ( flag_checkFileFirsttime ) {
+        flag_checkFileFirsttime = false;
         QTimer::singleShot( 2000, this, SLOT ( checkAlarms() ));
     }
 }
 void CalendarView::checkAlarms()
 {   
     KConfig *config = KOGlobals::config();
     config->setGroup( "AppRun" );
     QDateTime dt ( QDate (2005,1,1), QTime( 0,0,0 ) );
@@ -3011,25 +3013,24 @@ void CalendarView::changeIncidenceDisplay(Incidence *which, int action)
 }
 
 // most of the changeEventDisplays() right now just call the view's
 // total update mode, but they SHOULD be recoded to be more refresh-efficient.
 void CalendarView::changeEventDisplay(Event *which, int action)
 {
     //  kdDebug() << "CalendarView::changeEventDisplay" << endl;
     changeIncidenceDisplay((Incidence *)which,  action);
-    static bool clearallviews = false;
     if ( KOPrefs::instance()->mGlobalUpdateDisabled ) {
-        if ( clearallviews ) {
+        if ( flag_clearallviewsEventDisplay ) {
             clearAllViews();
-            clearallviews = false;
+            flag_clearallviewsEventDisplay = false;
         }
         return;
     }
-    clearallviews = true;
+    flag_clearallviewsEventDisplay = true;
     mDateNavigator->updateView();
     //mDialogManager->updateSearchDialog();
     if (which) {
         // If there is an event view visible update the display
         mViewManager->currentView()->changeEventDisplay(which,action);
         // TODO: check, if update needed
         //    if (which->getTodoStatus()) {
         mTodoList->updateView();
@@ -3172,25 +3173,24 @@ void CalendarView::clearAllViews()
     if ( sd ) {
         KOListView* kol = sd->listview();
         if ( kol )
             kol->clearList();
     }
 }
 void CalendarView::updateView()
 {
-    static bool clearallviews = false;
     if ( KOPrefs::instance()->mGlobalUpdateDisabled ) {
-        if ( clearallviews ) {
+        if ( flag_clearallviewsupdateView ) {
             clearAllViews();
-            clearallviews = false;
+            flag_clearallviewsupdateView = false;
         }
         return;
     }
-    clearallviews = true;
+    flag_clearallviewsupdateView = true;
     DateList tmpList = mNavigator->selectedDates();
 
     if ( KOPrefs::instance()->mHideNonStartedTodos ) 
         mTodoList->updateView();
     // We assume that the navigator only selects consecutive days.
     updateView( tmpList.first(), tmpList.last() );
 }
 
diff --git a/korganizer/calendarview.h b/korganizer/calendarview.h
index 0924f07..80f7ed4 100644
--- a/korganizer/calendarview.h
+++ b/korganizer/calendarview.h
@@ -546,16 +546,21 @@ class CalendarView : public KOrg::CalendarViewBase, public KCal::Calendar::Obser
     int msgItemDelete(const QString name);
     void showEventEditor();
     void showTodoEditor();
     Todo *selectedTodo();
   private:
 #ifdef DESKTOP_VERSION
     QScrollBar * mDateScrollBar;
 #endif
+    bool flag_blockConflict;
+    bool flag_blockScrollBar;
+    bool flag_checkFileFirsttime;
+    bool flag_clearallviewsEventDisplay;
+    bool flag_clearallviewsupdateView;
     QDateTime mNextAlarmDateTime;
     bool mViewerCallerIsSearchDialog;
     bool mBlockShowDates;
     KSyncManager* mSyncManager;
     AlarmDialog * mAlarmDialog;
     QString mAlarmNotification;
     QString mSuspendAlarmNotification;
     QTimer* mSuspendTimer;
diff --git a/korganizer/koagendaview.cpp b/korganizer/koagendaview.cpp
index c1b149f..6e65a03 100644
--- a/korganizer/koagendaview.cpp
+++ b/korganizer/koagendaview.cpp
@@ -372,16 +372,17 @@ void EventIndicator::enableColumn(int column, bool enable)
 
 ////////////////////////////////////////////////////////////////////////////
 ////////////////////////////////////////////////////////////////////////////
 ////////////////////////////////////////////////////////////////////////////
 
 KOAgendaView::KOAgendaView(Calendar *cal,QWidget *parent,const char *name) :
     KOEventView (cal,parent,name)
 {
+    flag_blockfillAgenda = false;
     mBlockUpdating = true;
     mStartHour = 8;
     mSelectedDates.append(QDate::currentDate());
 
     mLayoutDayLabels = 0;
     mDayLabelsFrame = 0;
     mDayLabels = 0;
     bool isRTL = KOGlobals::self()->reverseLayout();
@@ -1137,20 +1138,19 @@ void KOAgendaView::fillAgenda(const QDate &)
 }
 
 void KOAgendaView::fillAgenda()
 {
     if ( globalFlagBlockStartup )
         return;
     if ( globalFlagBlockAgenda == 1 )
         return;
-    static bool onlyOne = false;
-    if ( onlyOne )
+    if ( flag_blockfillAgenda )
         return;
-    onlyOne = true;
+    flag_blockfillAgenda = true;
     //if ( globalFlagBlockAgenda == 2 )
     //globalFlagBlockAgenda = 0;
     // globalFlagBlockPainting = false;
     if ( globalFlagBlockAgenda == 0 )
         globalFlagBlockAgenda = 1;
     //  clearView();
     //qDebug("fillAgenda()++++ ");
     globalFlagBlockAgendaItemPaint = 1;
@@ -1349,17 +1349,17 @@ void KOAgendaView::fillAgenda()
             setStartHour( QTime::currentTime ().hour() );
     }
     qApp->processEvents(); 
     globalFlagBlockAgenda = 0; 
     mAllDayAgenda->drawContentsToPainter();
     mAgenda->drawContentsToPainter();
     repaintAgenda();
     startIdleTimeout();
-    onlyOne = false;
+    flag_blockfillAgenda = false;
 }
 void KOAgendaView::repaintAgenda()
 {
     mAgenda->viewport()->repaint( false );
     mAllDayAgenda->viewport()->repaint( false );
     mAgenda->finishUpdate();
     mAllDayAgenda->finishUpdate();
 }
diff --git a/korganizer/koagendaview.h b/korganizer/koagendaview.h
index 4b7ef5b..5e68146 100644
--- a/korganizer/koagendaview.h
+++ b/korganizer/koagendaview.h
@@ -251,16 +251,17 @@ class KOAgendaView : public KOEventView {
     void updateEventIndicatorBottom(int newY);
     
     /** Updates data for selected timespan */    
     void newTimeSpanSelected(int gxStart, int gyStart, int gxEnd, int gyEnd);
     /** Updates data for selected timespan for all day event*/    
     void newTimeSpanSelectedAllDay(int gxStart, int gyStart, int gxEnd, int gyEnd);
 
   private:
+    bool flag_blockfillAgenda;
     QTimer* mIdleTimer;
     QDateTime mIdleStart;
     // view widgets
     QFrame *mDayLabels;
     QHBox *mDayLabelsFrame;
     QBoxLayout *mLayoutDayLabels;
     QFrame *mAllDayFrame;
     KOAgenda *mAllDayAgenda;
diff --git a/korganizer/kotodoview.cpp b/korganizer/kotodoview.cpp
index a12c43e..d79a9b9 100644
--- a/korganizer/kotodoview.cpp
+++ b/korganizer/kotodoview.cpp
@@ -508,17 +508,17 @@ void KOQuickTodo::focusOutEvent(QFocusEvent *ev)
   QLineEdit::focusOutEvent(ev);
 }
 
 /////////////////////////////////////////////////////////////////////////////
 
 KOTodoView::KOTodoView(Calendar *calendar,QWidget* parent,const char* name) :
   KOrg::BaseView(calendar,parent,name)
 { 
-
+    mIsActiveWindow = false;
     mCurItem = 0;
     mCurItemRootParent = 0;
     mCurItemParent = 0;
     mCurItemAbove = 0; 
     mActiveItem = 0;
     mCategoryPopupMenu = 0;
     mPendingUpdateBeforeRepaint = false;
     isFlatDisplay = false;
@@ -945,16 +945,17 @@ void KOTodoView::updateView()
 }
 
 void KOTodoView::storeCurrentItem()
 {
     mCurItem = 0;
     mCurItemRootParent = 0;
     mCurItemParent = 0;
     mCurItemAbove = 0; 
+    mIsActiveWindow = topLevelWidget()->isActiveWindow();
     mActiveItem = (KOTodoViewItem*)mTodoListView->currentItem();
     if (mActiveItem) {
         mCurItem = mActiveItem->todo();
         KOTodoViewItem* activeItemAbove =  (KOTodoViewItem*)mActiveItem->itemAbove ();
         if ( activeItemAbove )
             mCurItemAbove = activeItemAbove->todo();
         mCurItemRootParent = mCurItem;
         mCurItemParent = mCurItemRootParent->relatedTo();
@@ -1013,16 +1014,17 @@ void KOTodoView::resetCurrentItem()
         }
     }
     processSelectionChange(); 
     if ( mName != "todolistsmall" )
         QTimer::singleShot( 100, this, SLOT ( resetFocusToList() ));
 }
 void KOTodoView::resetFocusToList()
 {
+    if ( mIsActiveWindow ) 
     topLevelWidget()->setActiveWindow();
     mTodoListView->setFocus();
 }
 //Incidence * mCurItem, *mCurItemRootParent,*mCurItemAbove; 
 bool KOTodoView::checkTodo( Todo * todo )
 {
    
     if (  !KOPrefs::instance()->mShowCompletedTodo &&  todo->isCompleted() )
diff --git a/korganizer/kotodoview.h b/korganizer/kotodoview.h
index ecd0ad9..161ecb0 100644
--- a/korganizer/kotodoview.h
+++ b/korganizer/kotodoview.h
@@ -250,16 +250,17 @@ class KOTodoView : public KOrg::BaseView
     void toggleRunningItem();
     void paintNeeded();
     void processSelectionChange();
     void addQuickTodo();
     void setTodoModified( Todo* );
     void todoModified(Todo *, int );
 
   private:
+    bool mIsActiveWindow;
     void addQuickTodoPar( Todo * parentTodo);
     /*
      * the TodoEditor approach is rather unscaling in the long
      * run.
      * Korganizer keeps it in memory and we need to update
      * 1. make KOTodoViewItem a QObject again?
      * 2. add a public method for setting one todo modified?
      * 3. add a private method for setting a todo modified + friend here?
diff --git a/korganizer/koviewmanager.cpp b/korganizer/koviewmanager.cpp
index ba3bc05..4057ae0 100644
--- a/korganizer/koviewmanager.cpp
+++ b/korganizer/koviewmanager.cpp
@@ -55,16 +55,23 @@ int globalFlagBlockAgenda = 0;
 int globalFlagBlockLabel = 0;
 int globalFlagBlockAgendaItemPaint = 1;
 int globalFlagBlockAgendaItemUpdate = 1;
 
 
 KOViewManager::KOViewManager( CalendarView *mainView ) :
     QObject(), mMainView( mainView )
 {
+
+    lastMode = 0;
+    lastCount = 0;
+    lastNDMode = false;
+    selecteddatescount = 0;
+    selecteddate = QDate ( 2000, 1, 1 );
+    baseCycleDate = QDate ( 2000, 1, 1 );
     mCurrentView = 0;
     flagResetViewChangeDate = 0;
     mWhatsNextView = 0;
     mTodoView = 0;
     mAgendaView = 0;
     mMonthView = 0;
     mListView = 0;
     mJournalView = 0;
@@ -108,20 +115,17 @@ void KOViewManager::readSettings(KConfig *config)
         QTimer::singleShot( 1000, mAgendaView, SLOT ( setInitStartHour() ) );
 #endif
     }
 }
 
 
 void KOViewManager::showDateView( int view, QDate date)
 {
-    static int lastMode = 0;
-    static int lastCount = 0;
-    static bool lastNDMode = false;
-    static QDate lastDate;
+
     //qDebug("date %d %s", view, date.toString().latin1());
 
     if (view != 9)
         lastMode = 0;
     //qDebug("%d %d  ", lastNDMode, mFlagShowNextxDays );
     bool savemFlagShowNextxDays = mFlagShowNextxDays;
     mFlagShowNextxDays = false;
     if ( view == 3 ) {
@@ -196,19 +200,17 @@ void KOViewManager::writeSettings(KConfig *config)
         mListView->writeSettings(config);
     }
     if (mTodoView) {
         mTodoView->saveLayout(config,"Todo View");
     }
 }
 void KOViewManager::showNextView()
 { 
-    static int selecteddatescount = 0;
-    static QDate selecteddate = QDate ( 2000, 1, 1 );
-    static QDate baseCycleDate = QDate ( 2000, 1, 1 );
+
     int newCount = mMainView->dateNavigator()->selectedDates().count();
     if ( selecteddatescount != newCount && flagResetViewChangeDate == 0 ) {
         flagResetViewChangeDate = 1;
     }
     if ( selecteddate != mMainView->dateNavigator()->selectedDates().first() )
         flagResetViewChangeDate = 1;
     if ( flagResetViewChangeDate > 0 ) {
         baseCycleDate = mMainView->dateNavigator()->selectedDates().first();
diff --git a/korganizer/koviewmanager.h b/korganizer/koviewmanager.h
index 2e6aaed..2aa46d0 100644
--- a/korganizer/koviewmanager.h
+++ b/korganizer/koviewmanager.h
@@ -99,16 +99,23 @@ class KOViewManager : public QObject
     void showNextXView();
     void showMonthView();
     void showMonthViewWeek();
     void showTodoView();
     void showJournalView();
     void showTimeSpanView();
 
   private:
+    int lastMode;
+    int lastCount;
+    bool lastNDMode;
+    QDate lastDate;
+    int selecteddatescount;
+    QDate selecteddate;
+    QDate baseCycleDate;
     void resetDateSilent( QDate date , int days );
     int flagResetViewChangeDate;
     QDate currentViewChangeDate;
     void createMonthView();
     CalendarView *mMainView;
 
     int             mCurrentAgendaView;
     KOAgendaView    *mAgendaView;