merge contact fixes

1 files changed, 58 insertions, 24 deletions

diff --git a/kabc/addressee.cpp b/kabc/addressee.cpp
index 2aca559..295ee4f 100644
--- a/kabc/addressee.cpp
+++ b/kabc/addressee.cpp
@@ -299,39 +299,38 @@ void Addressee::mergeContact( const Addressee& ad , bool isSubSet) // = false)
     QStringList t;
     QStringList tAD;
     uint iii;
-    if ( isSubSet ) {
-        // ********** phone numbers
-        PhoneNumber::List phoneAD = ad.phoneNumbers();
-        PhoneNumber::List::Iterator phoneItAD;
-        for ( phoneItAD = phoneAD.begin(); phoneItAD != phoneAD.end(); ++phoneItAD ) {
-            bool found = false;
-            PhoneNumber::List::Iterator it;
-            for( it = mData->phoneNumbers.begin(); it != mData->phoneNumbers.end(); ++it ) {
-                if ( ( *phoneItAD ).contains( (*it)  ) ) {
-                    found = true;
-                    (*it).setType( ( *phoneItAD ).type() );
-                    break;
-                }
+
+    // ********** phone numbers
+    PhoneNumber::List phoneAD = ad.phoneNumbers();
+    PhoneNumber::List::Iterator phoneItAD;
+    for ( phoneItAD = phoneAD.begin(); phoneItAD != phoneAD.end(); ++phoneItAD ) {
+        bool found = false;
+        PhoneNumber::List::Iterator it;
+        for( it = mData->phoneNumbers.begin(); it != mData->phoneNumbers.end(); ++it ) {
+            if ( ( *phoneItAD ).contains( (*it)  ) ) {
+                found = true;
+                (*it).setType( ( *phoneItAD ).type() );
+                break;
             }
-            if ( ! found )
-                mData->phoneNumbers.append( *phoneItAD );                
         }
+        if ( isSubSet && ! found )
+            mData->phoneNumbers.append( *phoneItAD );                
+    }
+    if ( isSubSet ) {
         // ************* emails;
         t = mData->emails;
         tAD = ad.mData->emails;
         for ( iii = 0; iii < tAD.count(); ++iii)
             if ( !t.contains(tAD[iii] ) )
                 mData->emails.append( tAD[iii] );
-        // ************* categories;
-        t = mData->categories;
-        tAD = ad.mData->categories;
-        for ( iii = 0; iii < tAD.count(); ++iii)
-            if ( !t.contains(tAD[iii] ) )
-                mData->categories.append( tAD[iii] );
-
-
     }
 
+    // ************* categories;
+    t = mData->categories;
+    tAD = ad.mData->categories;
+    for ( iii = 0; iii < tAD.count(); ++iii)
+        if ( !t.contains(tAD[iii] ) )
+            mData->categories.append( tAD[iii] );
     QStringList::ConstIterator it;
     for( it = ad.mData->custom.begin(); it != ad.mData->custom.end(); ++it ) {
         QString qualifiedName = (*it).left( (*it).find( ":" )); 
@@ -389,7 +388,7 @@ void Addressee::mergeContact( const Addressee& ad , bool isSubSet) // = false)
             }
 
         }
-        if ( ! found ) {
+        if ( isSubSet && ! found ) {
             mData->addresses.append( *addressIterA );
         }
     }
@@ -478,8 +477,43 @@ void Addressee::simplifyEmails()
 
 void Addressee::simplifyPhoneNumbers()
 {
+    int max = 4;
+    int inList = mData->phoneNumbers.count();
     KABC::PhoneNumber::List removeNumbers;
     KABC::PhoneNumber::List::Iterator phoneIter;
+    if ( inList > max ) {
+        // delete non-preferred numbers
+        for ( phoneIter = mData->phoneNumbers.begin(); phoneIter != mData->phoneNumbers.end();
+              ++phoneIter ) {
+            if ( inList > max ) {
+                if ( ! (( *phoneIter ).type() &  PhoneNumber::Pref )) {
+                    removeNumbers.append( ( *phoneIter ) );
+                    --inList;
+                }
+            } else
+                break;
+        }
+        for ( phoneIter = removeNumbers.begin(); phoneIter != removeNumbers.end();
+              ++phoneIter ) {
+            removePhoneNumber(( *phoneIter ));
+        }
+        // delete preferred numbers
+        if ( inList > max ) {
+            for ( phoneIter = mData->phoneNumbers.begin(); phoneIter != mData->phoneNumbers.end();
+                  ++phoneIter ) {
+                if ( inList > max ) {
+                        removeNumbers.append( ( *phoneIter ) );
+                        --inList;
+                } else
+                    break;
+            }
+            for ( phoneIter = removeNumbers.begin(); phoneIter != removeNumbers.end();
+                  ++phoneIter ) {
+                removePhoneNumber(( *phoneIter ));
+            }
+        }
+    }
+    // remove non-numeric characters
     for ( phoneIter = mData->phoneNumbers.begin(); phoneIter != mData->phoneNumbers.end();
           ++phoneIter ) {
         if ( ! ( *phoneIter ).simplifyNumber() )