changes on how we call external email application

1 files changed, 55 insertions, 29 deletions

diff --git a/libkdepim/externalapphandler.cpp b/libkdepim/externalapphandler.cpp
index 5a56d68..1093abf 100644
--- a/libkdepim/externalapphandler.cpp
+++ b/libkdepim/externalapphandler.cpp
@@ -93,13 +93,13 @@ void ExternalAppHandler::loadConfig()
 
   if (( QFile::exists( qtopiapath + "/bin/ompi" )) ||
      ( QFile::exists( opiepath + "/bin/ompi" )))
-    addDefaultAppItem(ExternalAppHandler::EMAIL, KPimGlobalPrefs::OMPI_EMC,   "OM/Pi email client",       "QPE/Application/ompi",     "newMail(QString)", "%1",        mailmsg2,    "ATTACHMENT=%1");
+    addDefaultAppItem(ExternalAppHandler::EMAIL, KPimGlobalPrefs::OMPI_EMC,   "OM/Pi email client",   "QPE/Application/ompi",    mailmsg1, "%1;%2",        mailmsg2,   "TO=%1;ATTACHMENT=%2");
 
   if ( QFile::exists( qtopiapath + "/bin/qtmail" ))
-    addDefaultAppItem(ExternalAppHandler::EMAIL, KPimGlobalPrefs::QTOPIA_EMC, "Qtopia email client", "QPE/Application/qtmail",   mailmsg1,           ";%1",       mailmsg2,    "ATTACHMENT=%1");
+    addDefaultAppItem(ExternalAppHandler::EMAIL, KPimGlobalPrefs::QTOPIA_EMC, "Qtopia email client", "QPE/Application/qtmail",   mailmsg1, "%1;%2",       mailmsg2,    "TO=%1;ATTACHMENT=%2");
 
   if ( QFile::exists( opiepath + "/bin/opiemail" ))
-    addDefaultAppItem(ExternalAppHandler::EMAIL, KPimGlobalPrefs::OPIE_EMC,   "Opie email client",   "QPE/Application/opiemail", mailmsg1,           ";%1",       mailmsg2,    "ATTACHMENT=%1");
+    addDefaultAppItem(ExternalAppHandler::EMAIL, KPimGlobalPrefs::OPIE_EMC,   "Opie email client",   "QPE/Application/opiemail", mailmsg1, "%1;%2",       mailmsg2,    "TO=%1;ATTACHMENT=%2");
 
 
 
@@ -267,10 +267,10 @@ bool ExternalAppHandler::isPagerAppAvailable()
 
 
 //calls the emailapplication with a number of attachments that need to be send (Seperated by Comma)
-bool ExternalAppHandler::mailAttachments( const QString& urls )
+bool ExternalAppHandler::mailToMultipleContacts( const QString& emails, const QString& urls )
 {
 
-#ifndef DESKTOP_VERSION 
+#ifndef DESKTOP_VERSION
   QString channel;
   QString message2;
   QString parameters2;
@@ -296,15 +296,18 @@ bool ExternalAppHandler::mailAttachments( const QString& urls )
     parameters2 = dai->_parameters2;
   }
 
+  //first check if one of the mailers need the emails right in the message.
+  message2 = translateMessage(message2, emails, urls);
+
 
   qDebug("Using QCopEnvelope e(\"%s\",\"%s\")", channel.latin1(), message2.latin1());
-  qDebug("passing attachmenturls:(%s) as parameter in the form %s to QCopEnvelope", urls.latin1(), parameters2.latin1());
+  qDebug("passing emailadresses:(%s), attachmenturls:(%s) as parameters in the form %s to QCopEnvelope", emails.latin1() , urls.latin1(), parameters2.latin1());
 
 
   QCopEnvelope e(channel.latin1(), message2.latin1());
     //US we need no names in the To field. The emailadresses are enough
 
-  passParameter(&e, parameters2, urls);
+  passParameters(&e, parameters2, emails, urls);
 
 
 
@@ -321,9 +324,9 @@ bool ExternalAppHandler::mailAttachments( const QString& urls )
 
 
 //calls the emailapplication and creates a mail with parameter emails as recipients
-bool ExternalAppHandler::mailToContacts( const QString& emails )
+bool ExternalAppHandler::mailToOneContact( const QString& name, const QString& emailadress )
 {
-#ifndef DESKTOP_VERSION 
+#ifndef DESKTOP_VERSION
   QString channel;
   QString message;
   QString parameters;
@@ -351,16 +354,16 @@ bool ExternalAppHandler::mailToContacts( const QString& emails )
 
 
   //first check if one of the mailers need the emails right in the message.
-  message = translateMessage(message, emails);
+  message = translateMessage(message, name, emailadress);
 
 
   qDebug("Using QCopEnvelope e(\"%s\",\"%s\")", channel.latin1(), message.latin1());
-  qDebug("passing emailadresses:(%s) as parameter in the form %s to QCopEnvelope", emails.latin1(), parameters.latin1());
+  qDebug("passing name:(%s), emailadresses:(%s) as parameters in the form %s to QCopEnvelope", name.latin1(), emailadress.latin1(), parameters.latin1());
 
   QCopEnvelope e(channel.latin1(), message.latin1());
     //US we need no names in the To field. The emailadresses are enough
 
-  passParameter(&e, parameters, emails);
+  passParameters(&e, parameters, name, emailadress);
 
 
 #else
@@ -375,10 +378,31 @@ bool ExternalAppHandler::mailToContacts( const QString& emails )
  *
  **************************************************************************/
 
+//calls the emailapplication and creates a mail with parameter as recipients
+// parameters format is
+//  NAME <EMAIL>:SUBJECT
+bool ExternalAppHandler::mailToOneContact( const QString& adressline )
+{
+  QString line = adressline;
+
+  int first = line.find( "<");
+  int last = line.find( ">");
+  QString name = line.left(first);
+  QString emailadress = line.mid(first+1, last-first-1);
+
+  //Subject can not be handled right now.
+  mailToOneContact( name, emailadress );
+}
+
+
+/**************************************************************************
+ *
+ **************************************************************************/
+
 //calls the phoneapplication with the number
 bool ExternalAppHandler::callByPhone( const QString& phonenumber )
 {
-#ifndef DESKTOP_VERSION 
+#ifndef DESKTOP_VERSION
   QString channel;
   QString message;
   QString parameters;
@@ -406,7 +430,7 @@ bool ExternalAppHandler::callByPhone( const QString& phonenumber )
 
 
   //first check if one of the mailers need the emails right in the message.
-  message = translateMessage(message, phonenumber);
+  message = translateMessage(message, phonenumber, "");
 
 
   qDebug("Using QCopEnvelope e(\"%s\",\"%s\")", channel.latin1(), message.latin1());
@@ -415,7 +439,7 @@ bool ExternalAppHandler::callByPhone( const QString& phonenumber )
   QCopEnvelope e(channel.latin1(), message.latin1());
     //US we need no names in the To field. The emailadresses are enough
 
-  passParameter(&e, parameters, phonenumber);
+  passParameters(&e, parameters, phonenumber, "");
 
 
 #else
@@ -433,7 +457,7 @@ bool ExternalAppHandler::callByPhone( const QString& phonenumber )
 //calls the smsapplication with the number
 bool ExternalAppHandler::callBySMS( const QString& phonenumber )
 {
-#ifndef DESKTOP_VERSION 
+#ifndef DESKTOP_VERSION
   QString channel;
   QString message;
   QString parameters;
@@ -461,7 +485,7 @@ bool ExternalAppHandler::callBySMS( const QString& phonenumber )
 
 
   //first check if one of the mailers need the emails right in the message.
-  message = translateMessage(message, phonenumber);
+  message = translateMessage(message, phonenumber, "");
 
 
   qDebug("Using QCopEnvelope e(\"%s\",\"%s\")", channel.latin1(), message.latin1());
@@ -470,7 +494,7 @@ bool ExternalAppHandler::callBySMS( const QString& phonenumber )
   QCopEnvelope e(channel.latin1(), message.latin1());
     //US we need no names in the To field. The emailadresses are enough
 
-  passParameter(&e, parameters, phonenumber);
+  passParameters(&e, parameters, phonenumber, "");
 
 
 #else
@@ -488,7 +512,7 @@ bool ExternalAppHandler::callBySMS( const QString& phonenumber )
 //calls the pagerapplication with the number
 bool ExternalAppHandler::callByPager( const QString& pagernumber )
 {
-#ifndef DESKTOP_VERSION 
+#ifndef DESKTOP_VERSION
   QString channel;
   QString message;
   QString parameters;
@@ -516,7 +540,7 @@ bool ExternalAppHandler::callByPager( const QString& pagernumber )
 
 
   //first check if one of the mailers need the emails right in the message.
-  message = translateMessage(message, pagernumber);
+  message = translateMessage(message, pagernumber, "");
 
 
   qDebug("Using QCopEnvelope e(\"%s\",\"%s\")", channel.latin1(), message.latin1());
@@ -525,7 +549,7 @@ bool ExternalAppHandler::callByPager( const QString& pagernumber )
   QCopEnvelope e(channel.latin1(), message.latin1());
     //US we need no names in the To field. The emailadresses are enough
 
-  passParameter(&e, parameters, pagernumber);
+  passParameters(&e, parameters, pagernumber, "");
 
 
 #else
@@ -543,7 +567,7 @@ bool ExternalAppHandler::callByPager( const QString& pagernumber )
 //calls the faxapplication with the number
 bool ExternalAppHandler::callByFax( const QString& faxnumber )
 {
-#ifndef DESKTOP_VERSION 
+#ifndef DESKTOP_VERSION
   QString channel;
   QString message;
   QString parameters;
@@ -571,7 +595,7 @@ bool ExternalAppHandler::callByFax( const QString& faxnumber )
 
 
   //first check if one of the mailers need the emails right in the message.
-  message = translateMessage(message, faxnumber);
+  message = translateMessage(message, faxnumber, "");
 
 
   qDebug("Using QCopEnvelope e(\"%s\",\"%s\")", channel.latin1(), message.latin1());
@@ -580,7 +604,7 @@ bool ExternalAppHandler::callByFax( const QString& faxnumber )
   QCopEnvelope e(channel.latin1(), message.latin1());
     //US we need no names in the To field. The emailadresses are enough
 
-  passParameter(&e, parameters, faxnumber);
+  passParameters(&e, parameters, faxnumber, "");
 
 
 #else
@@ -596,19 +620,19 @@ bool ExternalAppHandler::callByFax( const QString& faxnumber )
  **************************************************************************/
 
 
-
-QString& ExternalAppHandler::translateMessage(QString& message, const QString& param1) const
+QString& ExternalAppHandler::translateMessage(QString& message, const QString& param1, const QString& param2 ) const
 {
-  return message.replace( QRegExp("%1"), param1 );
+  message = message.replace( QRegExp("%1"), param1 );
+  return message.replace( QRegExp("%2"), param2 );
 }
 
 /**************************************************************************
  *
  **************************************************************************/
 
-void ExternalAppHandler::passParameter(QCopEnvelope* e, const QString& parameters, const QString& param1) const
+void ExternalAppHandler::passParameters(QCopEnvelope* e, const QString& parameters, const QString& param1 , const QString& param2) const
 {
-#ifndef DESKTOP_VERSION 
+#ifndef DESKTOP_VERSION
   QMap<QString, QString> valmap;
   bool useValMap = false;
 
@@ -627,12 +651,14 @@ void ExternalAppHandler::passParameter(QCopEnvelope* e, const QString& parameter
     QStringList::Iterator it2 = keyvallist.begin();
     QString key = (*it2);
     key = key.replace( QRegExp("%1"), param1 );
+    key = key.replace( QRegExp("%2"), param2 );
     ++it2;
 
     if(it2 != keyvallist.end())
     {
       QString value = (*it2);
       value = value.replace( QRegExp("%1"), param1 );
+      value = value.replace( QRegExp("%2"), param2 );
 
           valmap.insert(key, value);
           useValMap = true;