tab fixes

6 files changed, 30 insertions, 3 deletions

diff --git a/pwmanager/pwmanager/addentrywnd_emb.cpp b/pwmanager/pwmanager/addentrywnd_emb.cpp
index f065058..c2590f0 100644
--- a/pwmanager/pwmanager/addentrywnd_emb.cpp
+++ b/pwmanager/pwmanager/addentrywnd_emb.cpp
@@ -148,48 +148,55 @@ addEntryWnd::addEntryWnd( PwMDoc* d, QWidget* parent, const char* name)
     QLabel* label4 = new QLabel( launcherLineEdit, i18n("$u = URL"), tab3 );
     QLabel* label5 = new QLabel( launcherLineEdit, i18n("$p = Password"), tab3 );
 
     label = new QLabel( launcherLineEdit, i18n("Launcher:"), tab3 );
 
     layout->addWidget( label1, i, 0 );
     layout->addWidget( label2, i, 1 );
     i++;
     layout->addWidget( label3, i, 0 );
     layout->addWidget( label4, i, 1 );
     i++;
     layout->addWidget( label5, i, 0 );
     i++;
 
     layout->addWidget( label, i, 0 );
     layout->addWidget( launcherLineEdit, i, 1 );
     i++;
 
 
     mTabWidget->addTab( tab3, i18n( "&Launcher" ) );
 
     // signals and slots connections
     connect( generateButton, SIGNAL( clicked() ), this, SLOT( generateButton_slot() ) );
     connect( revealButton, SIGNAL( toggled(bool) ), this, SLOT( revealButton_slot() ) );
+
+#if 0
+    if ( QApplication::desktop()->width() <= 640 && QApplication::desktop()->width() >= 480 ) {
+        resize ( 440, 400 );
+    }
+#endif
+
 }
 
 /*
  *  Destroys the object and frees any allocated resources
  */
 addEntryWnd::~addEntryWnd()
 {
     // no need to delete child widgets, Qt does it all for us
 }
 
 void addEntryWnd::slotOk()
 {
     qWarning( "addEntryWnd::slotOk(): Not implemented yet" );
 }
 
 void addEntryWnd::revealButton_slot()
 {
     qWarning( "addEntryWnd::revealButton_slot(): Not implemented yet" );
 }
 
 void addEntryWnd::generateButton_slot()
 {
     qWarning( "addEntryWnd::generateButton_slot(): Not implemented yet" );
 }
diff --git a/pwmanager/pwmanager/commentbox.cpp b/pwmanager/pwmanager/commentbox.cpp
index e2d2d2b..0f32561 100644
--- a/pwmanager/pwmanager/commentbox.cpp
+++ b/pwmanager/pwmanager/commentbox.cpp
@@ -211,48 +211,49 @@ QSize CommentBox::size()
 		PWM_ASSERT(textDta);
 		return textDta->size();
 		break;
 	case mode_html:
 		PWM_ASSERT(htmlDta);
 		return htmlDta->view()->size();
 		break;
 	default:
 		break;
 	}
 
 	return QSize();
 }
 
 
 ////////////////////////////////////////////////////////////////////////
 
 #else
 
 CommentBox::CommentBox(QWidget *_parentWidget)
   : QMultiLineEdit(_parentWidget) 
 
 {
   this->setReadOnly(true);
+  setFocusPolicy( QWidget::ClickFocus );
 }
 
 CommentBox::~CommentBox()
 {
 }
 
 void CommentBox::clear()
 {
 	this->hide();
 }
 
 
 void CommentBox::setText(const QString &text)
 {
 	QMultiLineEdit::setText( text);
 	if (!this->isVisible())
 		this->show();
 }
 
 bool CommentBox::getText(QString *text)
 {
 	*text = this->text();
 	return true;
 }
diff --git a/pwmanager/pwmanager/pwm.cpp b/pwmanager/pwmanager/pwm.cpp
index fc6837f..aed8ec0 100644
--- a/pwmanager/pwmanager/pwm.cpp
+++ b/pwmanager/pwmanager/pwm.cpp
@@ -638,48 +638,49 @@ void PwM::addPwd_slot1(QString *pw, PwMDoc *_doc)
 	if (_doc) {
 		doc = _doc;
 	} else {
 		doc = curDoc();
 	}
 	PWM_ASSERT(doc);
 	doc->timer()->getLock(DocTimer::id_autoLockTimer);
 #ifndef PWM_EMBEDDED
 	AddEntryWndImpl w;
 #else
 	AddEntryWndImpl w(doc, this, "addentrywndimpl");
 #endif
     w.setCaption( i18n ("Add new password") );
 	vector<string> catList;
 	doc->getCategoryList(&catList);
 	unsigned i, size = catList.size();
 	for (i = 0; i < size; ++i) {
 		w.addCategory(catList[i].c_str());
 	}
 	w.setCurrCategory(view->getCurrentCategory());
 	if (pw)
 		w.pwLineEdit->setText(*pw);
 
       tryAgain:
+    w.descLineEdit->setFocus();
 	if (w.exec() == 1) 
 	  {
 		PwMDataItem d;
 
 		//US BUG: to initialize all values of curEntr with meaningfulldata,
 		// we call clear on it. Reason: Metadata will be uninitialized otherwise.
 		// another option would be to create a constructor for PwMDataItem
 		d.clear(true);
 
 		d.desc = w.getDescription().latin1();
 		d.name = w.getUsername().latin1();
 		d.pw = w.getPassword().latin1();
 		d.comment = w.getComment().latin1();
 		d.url = w.getUrl().latin1();
 		d.launcher = w.getLauncher().latin1();
 		PwMerror ret = doc->addEntry(w.getCategory(), &d);
 		if (ret == e_entryExists) {
 			KMessageBox::error(this,
 					   i18n
 					   ("An entry with this \"Description\",\n"
 					    "does already exist.\n"
 					    "Please select another description."),
 					   i18n("entry already exists."));
 			goto tryAgain;
@@ -738,48 +739,49 @@ void PwM::editPwd_slot3(const QString *category, const int *index,
 		curCategory = view->getCurrentCategory();
 	}
 	PwMDataItem currItem;
 	if (!doc->getEntry(curCategory, curEntryIndex, &currItem, true)) {
 		doc->timer()->putLock(DocTimer::id_autoLockTimer);
 		return;
 	}
 	BUG_ON(currItem.binary);
 
 	AddEntryWndImpl w(doc);
     w.setCaption( i18n ("Edit password") );
 	vector<string> catList;
 	doc->getCategoryList(&catList);
 	unsigned i, size = catList.size();
 	for (i = 0; i < size; ++i) {
 		w.addCategory(catList[i].c_str());
 	}
 	w.setCurrCategory(curCategory);
 	w.setDescription(currItem.desc.c_str());
 	w.setUsername(currItem.name.c_str());
 	w.setPassword(currItem.pw.c_str());
 	w.setUrl(currItem.url.c_str());
 	w.setLauncher(currItem.launcher.c_str());
 	w.setComment(currItem.comment.c_str());
+    w.descLineEdit->setFocus();
 	if (w.exec() == 1) {
 		currItem.desc = w.getDescription().latin1();
 		currItem.name = w.getUsername().latin1();
 		currItem.pw = w.getPassword().latin1();
 		currItem.comment = w.getComment().latin1();
 		currItem.url = w.getUrl().latin1();
 		currItem.launcher = w.getLauncher().latin1();
 		if (!doc->editEntry(curCategory, w.getCategory(),
 					 curEntryIndex, &currItem)) {
 			KMessageBox::error(this,
 					   i18n("Couldn't edit the entry.\n"
 						"Maybe you changed the category and\n"
 						"this entry is already present\nin the new "
 						"category?"),
 					   i18n("couldn't edit entry."));
 			doc->timer()->putLock(DocTimer::id_autoLockTimer);
 			return;
 		}
 	}
 	doc->timer()->putLock(DocTimer::id_autoLockTimer);
 }
 
 void PwM::deletePwd_slot()
 {
diff --git a/pwmanager/pwmanager/pwmview.cpp b/pwmanager/pwmanager/pwmview.cpp
index 8c4d9cc..7f7dd6f 100644
--- a/pwmanager/pwmanager/pwmview.cpp
+++ b/pwmanager/pwmanager/pwmview.cpp
@@ -44,48 +44,49 @@
 #define COLUMN_DESC		0
 #define COLUMN_NAME		1
 #define COLUMN_PW		2
 #define COLUMN_URL		3
 #define COLUMN_LAUNCHER		4
 */
 
 PwMView::PwMView(PwM *_mainClass,
 		 QWidget *parent, PwMDoc *_doc,
 		 const char *name)
  : PwMViewStyle(parent, name)
 {
 	PWM_ASSERT(_mainClass);
 	PWM_ASSERT(parent);
 	PWM_ASSERT(_doc);
 	setView(this);
 	doc = _doc;
 	doc->setListViewPointer(this);
 	mainClass = _mainClass;
 	resize(_mainClass->size());
 	initStyle(conf()->confWndMainViewStyle());
 	initCtxMenu();
 	doc->setCurrentView(this);
 	connect(doc, SIGNAL(dataChanged(PwMDoc *)), this, SLOT(updateView()));
+	connect(this, SIGNAL(editPW()), mainClass, SLOT(editPwd_slot()));
 }
 
 PwMView::~PwMView()
 {
 }
 
 void PwMView::initCtxMenu()
 {
 	ctxMenu = new QPopupMenu(this);
 	ctxMenu->insertItem(i18n("&Add password"), mainClass, SLOT(addPwd_slot()));
 	ctxMenu->insertSeparator();
 	ctxMenu->insertItem(i18n("&Edit"), mainClass, SLOT(editPwd_slot()));
 	ctxMenu->insertItem(i18n("&Delete"), mainClass, SLOT(deletePwd_slot()));
 	ctxMenu->insertSeparator();
 	ctxMenu->insertItem(i18n("copy password to clipboard"),
 			    this, SLOT(copyPwToClip()));
 	ctxMenu->insertItem(i18n("copy username to clipboard"),
 			    this, SLOT(copyNameToClip()));
 	ctxMenu->insertItem(i18n("copy description to clipboard"),
 			    this, SLOT(copyDescToClip()));
 	ctxMenu->insertItem(i18n("copy url to clipboard"),
 			    this, SLOT(copyUrlToClip()));
 	ctxMenu->insertItem(i18n("copy launcher to clipboard"),
 			    this, SLOT(copyLauncherToClip()));
diff --git a/pwmanager/pwmanager/pwmviewstyle.cpp b/pwmanager/pwmanager/pwmviewstyle.cpp
index 0af1473..5f25880 100644
--- a/pwmanager/pwmanager/pwmviewstyle.cpp
+++ b/pwmanager/pwmanager/pwmviewstyle.cpp
@@ -40,80 +40,91 @@ PwMViewStyle::PwMViewStyle(QWidget *parent, const char *name)
 }
 
 PwMViewStyle::~PwMViewStyle()
 {
 	//US ENH : store the size of the listviewcolumns
         switch (curStyle)
 	  {
 	  case style_0:
 	    s0->saveSettings(PWMPrefs::instance());
 	    break;
 	  case style_1:
 	    s1->saveSettings(PWMPrefs::instance());
 	    break;
 	  default:
 		BUG();
 	  }
 
 
 	PWMPrefs::instance()->writeConfig();
 
 	delete_ifnot_null(s0);
 	delete_ifnot_null(s1);
 }
 
+void PwMViewStyle::editPassWord( QListViewItem * i )
+{
+    if ( !i )
+        return;
+    emit editPW();
+}
 void PwMViewStyle::initStyle(style_t style)
 {
 	printDebug(string("initializing style ") + tostr(style));
 	bool wasMaximized = v->isMaximized();
 	if (v->isVisible())
 		v->hide();
 	switch (style) {
 	case style_0:
 		delete_ifnot_null(s0);
 		delete_ifnot_null(s1);
 		s0 = new PwMViewStyle_0(v);
 		lv = s0->getLv();
 		commentBox = s0->getCommentBox();
 		break;
 	case style_1:
 		delete_ifnot_null(s0);
 		delete_ifnot_null(s1);
 		s1 = new PwMViewStyle_1(v);
 		lv = s1->getLv();
 		commentBox = s1->getCommentBox();
 		break;
 	default:
 		BUG();
 		return;
 	}
 	curStyle = style;
 	connect(lv, SIGNAL(pressed(QListViewItem *)),
 		v, SLOT(handleToggle(QListViewItem *)));
 	connect(lv, SIGNAL(rightButtonClicked(QListViewItem *, const QPoint &, int)),
 		v, SLOT(handleRightClick(QListViewItem *, const QPoint &, int)));
 	connect(lv, SIGNAL(clicked(QListViewItem *)),
 		v, SLOT(refreshCommentTextEdit(QListViewItem *)));
+	connect(lv, SIGNAL(returnPressed(QListViewItem *)),
+		this, SLOT(editPassWord(QListViewItem *)));
+	connect(lv, SIGNAL(doubleClicked(QListViewItem *)),
+		this, SLOT(editPassWord(QListViewItem *)));
+
 	lv->addColumn(i18n("Description"), 180);
 	lv->addColumn(i18n("Username"), 150);
 	lv->addColumn(i18n("Password"), 150);
 	lv->addColumn(i18n("URL"), 180);
 	lv->addColumn(i18n("Launcher"), 120);
 	v->tmpReEnableSort();
 
 	//US ENH : load the size of the listviewcolumns
 	switch (curStyle)
 	  {
 	  case style_0:
 	    s0->restoreSettings(PWMPrefs::instance());
 	    break;
 	  case style_1:
 	    s1->restoreSettings(PWMPrefs::instance());
 	    break;
 	  default:
 		BUG();
 	  }
 
 	resizeView(v->size());
 	v->updateView();
 	if (wasMaximized) {
 		v->showMaximized();
diff --git a/pwmanager/pwmanager/pwmviewstyle.h b/pwmanager/pwmanager/pwmviewstyle.h
index bf5ce91..5656cbc 100644
--- a/pwmanager/pwmanager/pwmviewstyle.h
+++ b/pwmanager/pwmanager/pwmviewstyle.h
@@ -21,88 +21,93 @@
 #ifndef PWMVIEWSTYLE_H
 #define PWMVIEWSTYLE_H
 
 #include <qwidget.h>
 #include <qsplitter.h>
 #include <qhbox.h>
 #include <qvbox.h>
 #include <qpushbutton.h>
 #include <qpopupmenu.h>
 #ifndef PWM_EMBEDDED
 #include <qtextedit.h>
 #else
 #include <qmultilineedit.h>
 #endif
 
 #include <qlabel.h>
 #include <qlistbox.h>
 #include <qcombobox.h>
 #include <qsize.h>
 
 class ListViewPwM;
 class PwMViewStyle_0;
 class PwMViewStyle_1;
 class PwMView;
+class QListViewItem;
 class CommentBox;
 
 class PwMViewStyle : public QWidget
 {
 	Q_OBJECT
 
 public:
 	enum style_t
 	{
 		style_notset	= -1,
 		style_0		= 0,
 		style_1		= 1
 	};
 
 public:
 	PwMViewStyle(QWidget *parent = 0, const char *name = 0);
 	~PwMViewStyle();
 
 	/** initialize a new style */
 	void initStyle(style_t style);
 	void initStyle(int style)
 			{ initStyle(static_cast<style_t>(style)); }
 	/** returns the currently used style */
 	style_t getCurStyle()
 			 { return curStyle; }
 	void setView(PwMView *view)
 			{ v = view; }
 
 	/** returns the currently selected category */
 	QString getCurrentCategory();
 
 protected:
 	/** add Category to the view */
 	void addCategory(const QString &cat);
 	/** delete Category from view */
 	void delCategory(const QString &cat);
 	/** delete all categories from view */
 	void delAllCategories();
 	/** select the specified category */
 	void selectCategory(const QString &cat);
 	/** returns the number of categories in this view.
 	  * This value dosn't say anything about the number of
 	  * categories in the document.
 	  */
 	int numCategories();
 	/** resize the view */
 	void resizeView(const QSize &size);
+	ListViewPwM *lv;
+	CommentBox *commentBox;
+
+protected slots:
+    void editPassWord( QListViewItem * );
 
 private:
 	/** which style has the view?
 	  * KListBox on the left,
 	  * or QComboBox on the top?
 	  */
 	style_t curStyle;
 
 	PwMViewStyle_0 *s0;
 	PwMViewStyle_1 *s1;
 	PwMView *v;
+ signals:
+    void editPW();
 
-protected:
-	ListViewPwM *lv;
-	CommentBox *commentBox;
 };
 #endif