1 files changed, 43 insertions, 104 deletions

diff --git a/korganizer/kolistview.cpp b/korganizer/kolistview.cpp
index e5e3704..4c815d8 100644
--- a/korganizer/kolistview.cpp
+++ b/korganizer/kolistview.cpp
@@ -269,102 +269,99 @@ KOListView::KOListView(Calendar *calendar, QWidget *parent,
     mListView->addColumn(i18n("Calendar"));
 
     mListView->setColumnAlignment(0,AlignLeft);
     mListView->setColumnAlignment(1,AlignLeft);
     mListView->setColumnAlignment(2,AlignHCenter);
     mListView->setColumnAlignment(3,AlignLeft);
     mListView->setColumnAlignment(4,AlignHCenter);
     mListView->setColumnAlignment(5,AlignLeft);
     mListView->setColumnAlignment(6,AlignLeft);
     mListView->setColumnAlignment(7,AlignLeft);
     mListView->setColumnAlignment(8,AlignLeft);
     mListView->setColumnAlignment(9,AlignLeft);
     mListView->setColumnAlignment(10,AlignLeft);
     mListView->setColumnAlignment(11,AlignLeft);
     mKOListViewWhatsThis = new KOListViewWhatsThis(mListView->viewport(),this);
 
     int iii = 0;
     for ( iii = 0; iii< 12 ; ++iii )
         mListView->setColumnWidthMode( iii, QListView::Manual );
 
     QBoxLayout *layoutTop = new QVBoxLayout(this);
     layoutTop->addWidget(mListView);
     mListView->setFont ( KOPrefs::instance()->mListViewFont );
     mPopupMenu = eventPopup();
-    mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
-                                  i18n("Select all"),this,
-                                  SLOT(allSelection()),true);
-    mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
-                                  i18n("Deselect all"),this,
-                                  SLOT(clearSelection()),true);
-    mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
-                                  i18n("Delete all selected"),this,
-                                  SLOT(deleteAll()),true);
+    QPopupMenu* selPopup = new QPopupMenu ( this );
+    mPopupMenu->insertSeparator();
 
+    selPopup->insertItem(i18n("All"),this,
+                                  SLOT(allSelection()));
+    selPopup->insertItem(i18n("None"),this,
+                                  SLOT(clearSelection()));
+    selPopup->insertItem(i18n("Delete selected..."),this,
+                                  SLOT(deleteAll()));
+    mPopupMenu->insertItem(i18n("Selection"), selPopup );
     mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
                                   i18n("Hide all selected"),this,
                                   SLOT(hideAll()),true);
 
     mPopupMenu->insertSeparator();
 #ifdef DESKTOP_VERSION
     mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
                                   i18n("Print complete list"),this,
                                   SLOT(printList()),true);
     mPopupMenu->insertSeparator();
 #endif
     mCalPopup = new QPopupMenu ( this );
     mPopupMenu->insertItem( i18n("Set Calendar"),  mCalPopup );
 
+    mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
+                                  i18n("Set categories")+"...",this,
+                                  SLOT(setCat()),true);
+    mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
+                                  i18n("Set alarm..."),this,
+                                  SLOT(setAlarm()),true); 
     QObject::connect(mCalPopup,SIGNAL(aboutToShow()),this,
                      SLOT( populateCalPopup() ));
     QObject::connect(mCalPopup,SIGNAL(activated( int )),this,
                      SLOT( setCalendar( int ) ));
     QPopupMenu * exportPO = new QPopupMenu ( this );
-    mPopupMenu->insertItem( i18n("Export selected"),  exportPO );
+    mPopupMenu->insertItem( i18n("Export"),  exportPO );
     exportPO->insertItem( i18n("As iCal (ics) file..."),this,
                                   SLOT(saveToFile()));
     exportPO->insertItem( i18n("As vCal (vcs) file..."),this,
                                   SLOT(saveToFileVCS()));
     exportPO->insertItem( i18n("Journal/Details..."),this,
                                   SLOT(saveDescriptionToFile()));
     // mPopupMenu->insertSeparator();
-    mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
-                                  i18n("Add Categ. to selected..."),this,
-                                  SLOT(addCat()),true);
-    mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
-                                  i18n("Set Categ. for selected..."),this,
-                                  SLOT(setCat()),true);
+    // mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
+    //                            i18n("Add Categ. to selected..."),this,
+    //                            SLOT(addCat()),true);
     //mPopupMenu->insertSeparator();
-    mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
-                                  i18n("Set alarm for selected..."),this,
-                                  SLOT(setAlarm()),true);
-
-
-    
 #ifndef DESKTOP_VERSION
     mPopupMenu->insertSeparator();
     mPopupMenu->addAdditionalItem(QIconSet(QPixmap()),
-                                  i18n("Beam selected via IR"),this,
+                                  i18n("Beam via IR"),this,
                                   SLOT(beamSelected()),true);
 #endif
     /*
       mPopupMenu = new QPopupMenu;
       mPopupMenu->insertItem(i18n("Edit Event"), this,
       SLOT (editEvent()));
       mPopupMenu->insertItem(SmallIcon("delete"), i18n("Delete Event"), this,
       SLOT (deleteEvent()));
       mPopupMenu->insertSeparator();
       mPopupMenu->insertItem(i18n("Show Dates"), this,
       SLOT(showDates()));
       mPopupMenu->insertItem(i18n("Hide Dates"), this,
       SLOT(hideDates()));
     */
     QObject::connect(mListView,SIGNAL( newEvent()),
                      this,SIGNAL(signalNewEvent()));
     QObject::connect(mListView,SIGNAL(doubleClicked(QListViewItem *)),
                      this,SLOT(defaultItemAction(QListViewItem *)));
     QObject::connect(mListView,SIGNAL(rightButtonPressed( QListViewItem *,
                                                            const QPoint &, int )),
                      this,SLOT(popupMenu(QListViewItem *,const QPoint &,int)));
     QObject::connect(mListView,SIGNAL(currentChanged(QListViewItem *)),
                      SLOT(processSelectionChange(QListViewItem *)));
     QObject::connect(mListView,SIGNAL(showIncidence(Incidence *)),
@@ -417,79 +414,84 @@ void KOListView::setCalendar( int c )
                 incidence->accept(v);
             }
             incidence = delSel.next();
         }
     }
     QPtrList<KopiCalendarFile> calendars = KOPrefs::instance()->mCalendars;
     KopiCalendarFile * cal = calendars.first();
     while ( cal ) {
         mCalendar->setCalendarEnabled( cal->mCalNumber,cal->isEnabled );
         mCalendar->setAlarmEnabled( cal->mCalNumber, cal->isAlarmEnabled );
         mCalendar->setReadOnly( cal->mCalNumber, cal->isReadOnly );
         if ( cal->isStandard )
             mCalendar->setDefaultCalendar( cal->mCalNumber );
         cal = calendars.next();
     }
     mCalendar->setSyncEventsReadOnly();
     mCalendar->reInitAlarmSettings();
 
 }
 void KOListView::populateCalPopup()
 {
     mCalPopup->clear();
     KopiCalendarFile * kkf = KOPrefs::instance()->mCalendars.first();
     while ( kkf ) {
-        int index = mCalPopup->insertItem( kkf->mName, kkf->mCalNumber);
+        int index = mCalPopup->insertItem( kkf->mName+"...", kkf->mCalNumber);
         if ( kkf->mErrorOnLoad || kkf->isReadOnly )
         mCalPopup->setItemEnabled( index, false );
         kkf = KOPrefs::instance()->mCalendars.next();
     }
 }
 void KOListView::updateList()
 {
     // qDebug(" KOListView::updateList() ");
 
 }
 
 void KOListView::clearList()
 {
     clear ();
 }
-void KOListView::addCat( )
-{
-    setCategories( false );
-}
+
 void KOListView::setCat()
 {
-    setCategories( true );
+
+    bool set = true;
+    int result = KMessageBox::warningYesNoCancel(this, 
+                                                 i18n("Do you want to <b>add</b> categories to the selected items or <b>reset</b> the list (i.e. remove current categories)?"),
+                                                 i18n("Set categories"),
+                                                 i18n("Add"),
+                                                 i18n("Reset"));
+    if (result == KMessageBox::Cancel) return;
+    if (result == KMessageBox::Yes) set = false;
+    setCategories( set );
 }
 
 void  KOListView::setAlarm()
 {
     KOAlarmPrefs kap( this);
     if ( !kap.exec() )
         return;
-    QStringList itemList;
     QPtrList<KOListViewItem> sel ;
     QListViewItem *qitem  = mListView->firstChild ();
     while ( qitem ) {
         if ( qitem->isSelected() ) {
             Incidence* inc = ((KOListViewItem *) qitem)->data();
             if ( inc->typeID() != journalID ) {
                 if ( inc->typeID() == todoID ) {
                     if ( ((Todo*)inc)->hasDueDate() )
                       sel.append(((KOListViewItem *)qitem));
                 } else
                       sel.append(((KOListViewItem *)qitem));
             }
         }
         qitem = qitem->nextSibling();
     }
     int count = 0;
     KOListViewItem * item, *temp;
     item = sel.first();
     Incidence* inc;
     while ( item ) {
         inc = item->data();
             ++count;
             if (kap.mAlarmButton->isChecked()) {
                 if (inc->alarms().count() == 0) 
@@ -522,133 +524,71 @@ void  KOListView::setAlarm()
                     alarm->setEnabled(false);
                     alarm->setType(Alarm::Invalid);
                 }
             }
             ListItemVisitor v(item, mStartDate );
             inc->accept(v);
             item = sel.next();
     }
     topLevelWidget()->setCaption( i18n("Changed alarm for %1 items").arg( count )  );
     qDebug("KO: Set alarm for %d items", count);
     calendar()->reInitAlarmSettings();
     QTimer::singleShot( 1, this, SLOT ( resetFocus() ) );
 }
 void KOListView::setCategories( bool removeOld )
 {
    
     KPIM::CategorySelectDialog* csd = new KPIM::CategorySelectDialog( KOPrefs::instance(), 0 );
     csd->setColorEnabled();
     if (! csd->exec()) { 
         delete csd;
         return;
     }
     QStringList catList = csd->selectedCategories();
     delete csd;
-    // if ( catList.count() == 0 )
-    //   return;
-    //catList.sort();
-    QString categoriesStr = catList.join(",");
-    int i;
-    QStringList itemList;
-    QPtrList<KOListViewItem> sel ;
-    QListViewItem *qitem  = mListView->firstChild ();
-    while ( qitem ) {
-        if ( qitem->isSelected() ) {
-            sel.append(((KOListViewItem *)qitem));
-        }
-        qitem = qitem->nextSibling();
-    }
-    KOListViewItem * item, *temp;
-    item = sel.first();
-    if( item ) {
-        Incidence* inc = item->data() ;
-        bool setSub = false;
-        if( inc->typeID() == todoID && sel.count() == 1 &&  inc->relations().count() > 0 ) {
-            int result = KMessageBox::warningYesNoCancel(this, 
-                                                         i18n("The todo\n%1\nhas subtodos!\nDo you want to set\nthe categories for\nall subtodos as well?").arg( inc->summary().left ( 25 ) ),
-                                                         i18n("Todo has subtodos"),
-                                                         i18n("Yes"),
-                                                         i18n("No"));
-            if (result == KMessageBox::Cancel) item = 0;
-            if (result == KMessageBox::Yes) setSub = true;
-        }
-        while ( item ) {
-            inc = item->data();
+    QPtrList<Incidence> delSel = getSelectedIncidences(); // all inc allowed;
+    Incidence* inc = delSel.first();
+    while ( inc ) {
             if ( removeOld ) {
-                inc->setCategories( catList, setSub );
+            inc->setCategories( catList, false );
             } else {
-                inc->addCategories( catList, setSub );
+            inc->addCategories( catList, false );
             } 
+        KOListViewItem* item = getItemForEvent(inc);
+        if (item) { 
             ListItemVisitor v(item, mStartDate );
             inc->accept(v);
-            item = sel.next();
         }
+        inc = delSel.next();
     }
     QTimer::singleShot( 1, this, SLOT ( resetFocus() ) );
 }
 
 void KOListView::beamSelected()
 {
     QPtrList<Incidence> delSel = getSelectedIncidences() ;
-    int icount = delSel.count();
-    if ( icount ) {
+    if ( delSel.count() )
         emit beamIncidenceList( delSel );
-        return;
-        QString fn ;
-        fn = QDir::homeDirPath()+"/kopitempbeamfile.vcs";
-        QString mes;
-        bool createbup = true;
-        if ( createbup ) {
-            QString description = "\n";
-            CalendarLocal* cal = new CalendarLocal();
-            cal->setTimeZoneId(KPimGlobalPrefs::instance()->mTimeZoneId);
-            Incidence *incidence = delSel.first();
-            while ( incidence ) {
-                Incidence *in = incidence->clone();
-                description += in->summary() + "\n";
-                cal->addIncidence( in );
-                incidence = delSel.next();
-            }
-            FileStorage storage( cal, fn, new VCalFormat );
-            storage.save();
-            delete cal;
-            mes = i18n("KO/Pi: Ready for beaming");
-            topLevelWidget()->setCaption(mes); 
-
-#ifndef DESKTOP_VERSION
-            Ir *ir = new Ir( this ); 
-            connect( ir, SIGNAL( done( Ir * ) ), this, SLOT( beamDone( Ir * ) ) );
-            ir->send( fn, description, "text/x-vCalendar" );
-#endif
-        }
-    }
-}
-void KOListView::beamDone( Ir *ir )
-{
-#ifndef DESKTOP_VERSION
-    delete ir;
-#endif
-    topLevelWidget()->setCaption(i18n("KO/Pi:Beaming done")); 
 }
 
 void KOListView::saveDescriptionToFile()
 {
 
     int result = QMessageBox::warning( this, i18n("KO/Pi: Information!"),
                                        i18n("This saves the text/details of selected\nJournals and Events/Todos\nto a text file."),
                                        i18n("Continue"), i18n("Cancel"), 0,
                                        0, 1 );
     if ( result != 0 ) {
         return;
     }
     QPtrList<Incidence> delSel = getSelectedIncidences() ;
     int icount = delSel.count();
     if ( icount ) {
         QString fn =  KOPrefs::instance()->mLastSaveFile;
         fn =  KFileDialog::getSaveFileName( fn, i18n("Save filename"), this );
     
         if ( fn == "" )
             return;
         QFileInfo info;
         info.setFile( fn );
         QString mes;
         bool createbup = true;
@@ -1085,51 +1025,50 @@ void KOListView::showEvents(QPtrList<Event> eventList)
 {
     clear();
 
     addEvents(eventList);
 
     // After new creation of list view no events are selected.
     emit incidenceSelected( 0 );
 }
 int KOListView::count()
 {
     return mListView->childCount();
 }
 
 void KOListView::changeEventDisplay(Event *event, int action)
 {
     KOListViewItem *item;
 
     switch(action) {
     case KOGlobals::EVENTADDED:
         addIncidence( event );
         break;
     case KOGlobals::EVENTEDITED:
         item = getItemForEvent(event);
         if (item) { 
-            mUidDict.remove( event->uid() ); 
-            delete item;
-            addIncidence( event );
+            ListItemVisitor v(item, mStartDate );
+            ((Incidence*)event)->accept(v);
         }
         break;
     case KOGlobals::EVENTDELETED:
         item = getItemForEvent(event);
         if (item) {
             mUidDict.remove( event->uid() ); 
             delete item;
         }
         break;
     default:
         ;
     }
 }
 
 KOListViewItem *KOListView::getItemForEvent(Incidence *event)
 {
     KOListViewItem *item = (KOListViewItem *)mListView->firstChild();
     while (item) {
         if (item->data() == event) return item;
         item = (KOListViewItem *)item->nextSibling();
     }
     return 0;
 }