13 files changed, 26 insertions, 23 deletions

diff --git a/libkcal/calendar.cpp b/libkcal/calendar.cpp
index ed39ddb..7e8e2c5 100644
--- a/libkcal/calendar.cpp
+++ b/libkcal/calendar.cpp
@@ -354,9 +354,9 @@ bool Calendar::addIncidence(Incidence *i)
 void Calendar::deleteIncidence(Incidence *in)
 {
-    if ( in->type() == "Event" )
+    if ( in->typeID() == eventID )
         deleteEvent( (Event*) in );
-    else if ( in->type() =="Todo" )
+    else if ( in->typeID() == todoID )
         deleteTodo( (Todo*) in);
-    else if ( in->type() =="Journal" )
+    else if ( in->typeID() == journalID )
         deleteJournal( (Journal*) in );
 }
diff --git a/libkcal/calendarlocal.cpp b/libkcal/calendarlocal.cpp
index bc76c0b..fe74052 100644
--- a/libkcal/calendarlocal.cpp
+++ b/libkcal/calendarlocal.cpp
@@ -459,7 +459,5 @@ Alarm::List CalendarLocal::alarmsTo( const QDateTime &to )
 Alarm::List CalendarLocal::alarms( const QDateTime &from, const QDateTime &to )
 {
-  kdDebug(5800) << "CalendarLocal::alarms(" << from.toString() << " - "
-                << to.toString() << ")\n";
-
+ 
   Alarm::List alarms;
 
@@ -489,6 +487,4 @@ void CalendarLocal::appendAlarms( Alarm::List &alarms, Incidence *incidence,
     if ( alarm->enabled() ) {
       if ( alarm->time() >= from && alarm->time() <= to ) {
-        kdDebug(5800) << "CalendarLocal::appendAlarms() '" << incidence->summary()
-                      << "': " << alarm->time().toString() << endl;
         alarms.append( alarm );
       }
diff --git a/libkcal/calfilter.cpp b/libkcal/calfilter.cpp
index c425dfc..20078a7 100644
--- a/libkcal/calfilter.cpp
+++ b/libkcal/calfilter.cpp
@@ -79,9 +79,9 @@ void CalFilter::apply(QPtrList<Todo> *eventlist)
 bool CalFilter::filterCalendarItem(Incidence *in)
 {
-    if ( in->type() == "Event" )
+    if ( in->typeID() == eventID )
         return filterEvent( (Event*) in );
-    else if ( in->type() =="Todo" )
+    else if ( in->typeID() == todoID )
         return filterTodo( (Todo*) in);
-    else if ( in->type() =="Journal" )
+    else if ( in->typeID () == journalID )
         return filterJournal( (Journal*) in );
     return false;
diff --git a/libkcal/event.h b/libkcal/event.h
index 8729956..287d403 100644
--- a/libkcal/event.h
+++ b/libkcal/event.h
@@ -41,4 +41,5 @@ class Event : public Incidence
 
     QCString type() const { return "Event"; }
+    IncTypeID typeID() const { return eventID; }
 
     Incidence *clone();
diff --git a/libkcal/freebusy.h b/libkcal/freebusy.h
index 054feda..d741c72 100644
--- a/libkcal/freebusy.h
+++ b/libkcal/freebusy.h
@@ -49,4 +49,5 @@ class FreeBusy : public IncidenceBase
     
     QCString type() const { return "FreeBusy"; }
+    IncTypeID typeID() const { return freebusyID; }
 
     virtual QDateTime dtEnd() const;
diff --git a/libkcal/icalformat.cpp b/libkcal/icalformat.cpp
index 3a2aac6..d9fe40b 100644
--- a/libkcal/icalformat.cpp
+++ b/libkcal/icalformat.cpp
@@ -385,10 +385,10 @@ ScheduleMessage *ICalFormat::parseScheduleMessage( Calendar *cal,
   if (existingIncidence) {
     // TODO: check, if cast is required, or if it can be done by virtual funcs.
-    if (existingIncidence->type() == "Todo") {
+    if (existingIncidence->typeID() == todoID ) {
       Todo *todo = static_cast<Todo *>(existingIncidence);
       icalcomponent_add_component(calendarComponent,
                                   mImpl->writeTodo(todo));
     }
-    if (existingIncidence->type() == "Event") {
+    if (existingIncidence->typeID() == eventID ) {
       Event *event = static_cast<Event *>(existingIncidence);
       icalcomponent_add_component(calendarComponent,
diff --git a/libkcal/icalformatimpl.cpp b/libkcal/icalformatimpl.cpp
index 2405682..3e28714 100644
--- a/libkcal/icalformatimpl.cpp
+++ b/libkcal/icalformatimpl.cpp
@@ -2156,13 +2156,13 @@ icalcomponent *ICalFormatImpl::createScheduleComponent(IncidenceBase *incidence,
 
   // TODO: check, if dynamic cast is required
-  if(incidence->type() == "Todo") {
+  if(incidence->typeID() == todoID ) {
     Todo *todo = static_cast<Todo *>(incidence);
     icalcomponent_add_component(message,writeTodo(todo));
   }
-  if(incidence->type() == "Event") {
+  if(incidence->typeID() == eventID ) {
     Event *event = static_cast<Event *>(incidence);
     icalcomponent_add_component(message,writeEvent(event));
   }
-  if(incidence->type() == "FreeBusy") {
+  if(incidence->typeID() == freebusyID) {
     FreeBusy *freebusy = static_cast<FreeBusy *>(incidence);
     icalcomponent_add_component(message,writeFreeBusy(freebusy, method));
diff --git a/libkcal/incidence.cpp b/libkcal/incidence.cpp
index 762103f..f446197 100644
--- a/libkcal/incidence.cpp
+++ b/libkcal/incidence.cpp
@@ -237,5 +237,5 @@ Incidence* Incidence::recreateCloneException( QDate d  )
         addExDate( d );
         newInc->recurrence()->unsetRecurs();
-        if ( type() == "Event") {
+        if ( typeID() == eventID ) {
             int len = dtStart().secsTo( ((Event*)this)->dtEnd());
             QTime tim = dtStart().time();
@@ -725,5 +725,5 @@ QDateTime Incidence::getNextOccurence( const QDateTime& dt, bool* ok ) const
             incidenceStart = dtStart(); 
         }
-        if ( type() =="Todo" ) {
+        if ( typeID() == todoID ) {
             if ( ((Todo*)this)->hasDueDate() )
                 incidenceStart = ((Todo*)this)->dtDue();
@@ -737,5 +737,5 @@ QDateTime Incidence::dtStart() const
 {
     if ( doesRecur() ) {
-        if ( type() == "Todo" ) {
+        if ( typeID() == todoID ) {
             ((Todo*)this)->checkSetCompletedFalse();
         }
diff --git a/libkcal/incidencebase.h b/libkcal/incidencebase.h
index 8624786..05209e0 100644
--- a/libkcal/incidencebase.h
+++ b/libkcal/incidencebase.h
@@ -35,4 +35,5 @@ namespace KCal {
 
 typedef QValueList<QDate> DateList;
+ enum IncTypeID { eventID,todoID,journalID,freebusyID };
 
 /**
@@ -52,4 +53,5 @@ class IncidenceBase : public CustomProperties
 
     virtual QCString type() const = 0;
+    virtual  IncTypeID typeID() const = 0;
 
     /** Set the unique id for the event */
diff --git a/libkcal/journal.h b/libkcal/journal.h
index 2c1d7ea..1cd0a22 100644
--- a/libkcal/journal.h
+++ b/libkcal/journal.h
@@ -38,4 +38,5 @@ class Journal : public Incidence
 
     QCString type() const { return "Journal"; }
+    IncTypeID typeID() const { return journalID; }
     
     Incidence *clone();  
diff --git a/libkcal/kincidenceformatter.cpp b/libkcal/kincidenceformatter.cpp
index 7d61b7f..d1ace4f 100644
--- a/libkcal/kincidenceformatter.cpp
+++ b/libkcal/kincidenceformatter.cpp
@@ -22,7 +22,7 @@ QString KIncidenceFormatter::getFormattedText( Incidence * inc, bool details, bo
     mModified = modified;
     mText = "";
-    if ( inc->type() == "Event" )
+    if ( inc->typeID() == eventID )
         setEvent((Event *) inc );
-    else if ( inc->type() == "Todo" )
+    else if ( inc->typeID() == todoID )
         setTodo((Todo *) inc );
     return mText;
diff --git a/libkcal/todo.cpp b/libkcal/todo.cpp
index 38ba2c7..c97a61e 100644
--- a/libkcal/todo.cpp
+++ b/libkcal/todo.cpp
@@ -131,5 +131,5 @@ void Todo::saveParents()
         return;
     Incidence * inc = relatedTo();
-    if ( inc->type() != "Todo" )
+    if ( inc->typeID() != todoID )
         return;
     Todo* to = (Todo*)inc;
@@ -565,6 +565,7 @@ QDateTime Todo::getNextAlarmDateTime( bool * ok, int * offset, QDateTime start_d
 void Todo::checkSetCompletedFalse()
 {
-    if ( !hasRecurrenceID() ) {
+    if ( !mHasRecurrenceID ) {
         qDebug("ERROR 1 in Todo::checkSetCompletedFalse");
+        return;
     }
     // qDebug("Todo::checkSetCompletedFalse()");
diff --git a/libkcal/todo.h b/libkcal/todo.h
index ab8fdf1..501c2ba 100644
--- a/libkcal/todo.h
+++ b/libkcal/todo.h
@@ -42,4 +42,5 @@ namespace KCal {
     typedef ListBase<Todo> List;
     QCString type() const { return "Todo"; }
+    IncTypeID typeID() const { return todoID; }
 
     /** Return an exact copy of this todo. */