1 files changed, 17 insertions, 8 deletions

diff --git a/pwmanager/pwmanager/libgcryptif.cpp b/pwmanager/pwmanager/libgcryptif.cpp
index ff94bf6..15f6cef 100644
--- a/pwmanager/pwmanager/libgcryptif.cpp
+++ b/pwmanager/pwmanager/libgcryptif.cpp
@@ -41,7 +41,9 @@ PwMerror LibGCryptIf::encrypt(unsigned char **outBuf,
                               size_t inBufLen,
                               const unsigned char *key,
                               size_t keylen,
-                              char _algo)
+                              char _algo,
+                              char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+                              )
 {
         PwMerror ret = e_success;
         gcry_error_t err;
@@ -105,7 +107,7 @@ PwMerror LibGCryptIf::encrypt(unsigned char **outBuf,
         }
         // hash the "key" to a fixed size hash matching "cipherKeylen"
         hashedKey = new unsigned char[cipherKeylen];
-        hashPassphrase(key, keylen, salt, hashedKey, cipherKeylen, true);
+        hashPassphrase(key, keylen, salt, hashedKey, cipherKeylen, true, _hashalgo);
         // so now set the hashed key
         err = gcry_cipher_setkey(handle, hashedKey, cipherKeylen);
         if (err != GPG_ERR_NO_ERROR) {
@@ -152,7 +154,9 @@ PwMerror LibGCryptIf::decrypt(unsigned char **outBuf,
                               size_t inBufLen,
                               const unsigned char *key,
                               size_t keylen,
-                              char _algo)
+                              char _algo,
+                              char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+)
 {
         PwMerror ret = e_success;
         gcry_error_t err;
@@ -201,7 +205,7 @@ PwMerror LibGCryptIf::decrypt(unsigned char **outBuf,
         }
         // hash the "key" to a fixed size hash matching "cipherKeylen"
         hashedKey = new unsigned char[cipherKeylen];
-        hashPassphrase(key, keylen, salt, hashedKey, cipherKeylen, false);
+        hashPassphrase(key, keylen, salt, hashedKey, cipherKeylen, false, _hashalgo);
         // so now set the hashed key
         err = gcry_cipher_setkey(handle, hashedKey, cipherKeylen);
         if (err != GPG_ERR_NO_ERROR) {
@@ -314,7 +318,9 @@ bool LibGCryptIf::hashPassphrase(const unsigned char *pw,
                                  unsigned char *salt,
                                  unsigned char *key,
                                  size_t keylen,
-                                 bool create)
+                                 bool create,
+                                 char _hashalgo //US BUG: pass _hashalgo because we need it in hashPassphrase
+)
 {
         DEK dek;
         STRING2KEY s2k;
@@ -322,7 +328,10 @@ bool LibGCryptIf::hashPassphrase(const unsigned char *pw,
 
         dek.keylen = keylen;
         s2k.mode = 1;
-        s2k.hash_algo = mapHashId(conf()->confGlobHashAlgo());
+        //US bug: do not use the global hash algo here. Use the passed ago instead. The hashalgo stored in the file can
+        // be different from the one in the configuration.
+        s2k.hash_algo = mapHashId(_hashalgo //conf()->confGlobHashAlgo()
+                                  );
         s2k.count = 0;
         if (!create)
                 memcpy(s2k.salt, salt, STRING2KEY_SALTLEN);
@@ -439,7 +448,7 @@ void LibGCryptIf::unpadData(const unsigned char *buf,
         BUG_ON(*bufLen % 8);
         pos = *bufLen - 1;
         while (buf[pos] != static_cast<char>(0x01)) {
-        qDebug("pos %d %d %d", pos, buf[pos],   static_cast<char>(0x01)     );
+          //qDebug("pos %d %d %d", pos, buf[pos],   static_cast<char>(0x01)     );
                 BUG_ON(!pos);
         //LR BUG we should terminte the loop if p == 0
         if ( pos == 0 )
@@ -447,7 +456,7 @@ void LibGCryptIf::unpadData(const unsigned char *buf,
                 --pos;
         }
         *bufLen = pos;
-    qDebug("ente ");
+        //qDebug("ente ");
 }
 
 #endif // CONFIG_PWMANAGER_GCRY