summaryrefslogtreecommitdiff
authordrw <drw>2005-02-02 01:07:14 (UTC)
committer drw <drw>2005-02-02 01:07:14 (UTC)
commit9c9c35ab1c0366b69ba1be63a4b7ba7b847fb66a (patch) (side-by-side diff)
tree88d42e3fee67021735890852bf73e53c209bac6f
parent7500adc8443f9044da7773e32742dbae51391bef (diff)
downloadopie-9c9c35ab1c0366b69ba1be63a4b7ba7b847fb66a.zip
opie-9c9c35ab1c0366b69ba1be63a4b7ba7b847fb66a.tar.gz
opie-9c9c35ab1c0366b69ba1be63a4b7ba7b847fb66a.tar.bz2
Change the way categories can be selected, combo box is much more useful than a menu for many different categories
Diffstat (more/less context) (ignore whitespace changes)
-rw-r--r--libopie2/opiepim/ui/opimmainwindow.cpp115
-rw-r--r--libopie2/opiepim/ui/opimmainwindow.h14
2 files changed, 45 insertions, 84 deletions
diff --git a/libopie2/opiepim/ui/opimmainwindow.cpp b/libopie2/opiepim/ui/opimmainwindow.cpp
index d46df69..a72d174 100644
--- a/libopie2/opiepim/ui/opimmainwindow.cpp
+++ b/libopie2/opiepim/ui/opimmainwindow.cpp
@@ -45,2 +45,3 @@
#include <qapplication.h>
+#include <qcombobox.h>
#include <qcopchannel_qws.h>
@@ -241,4 +242,2 @@ void OPimMainWindow::insertViewMenuItems( QActionGroup *items ) {
m_viewMenu->clear();
- m_viewMenuCategories->addTo( m_viewMenu );
- m_viewMenu->insertSeparator();
m_viewMenuGroup->addTo( m_viewMenu );
@@ -250,7 +249,7 @@ void OPimMainWindow::insertViewMenuItems( QActionGroup *items ) {
-void OPimMainWindow::slotViewCategory( QAction *category ) {
+void OPimMainWindow::slotViewCategory( const QString &category ) {
// Set application caption
QString caption = m_appName;
- if ( category->text() != tr( "All" ) )
- caption.append( QString( " - %1" ).arg( category->text() ) );
+ if ( category != tr( "All" ) )
+ caption.append( QString( " - %1" ).arg( category ) );
setCaption( caption );
@@ -258,3 +257,3 @@ void OPimMainWindow::slotViewCategory( QAction *category ) {
// Notify application
- emit categorySelected( category->text() );
+ emit categorySelected( category );
}
@@ -262,14 +261,10 @@ void OPimMainWindow::slotViewCategory( QAction *category ) {
void OPimMainWindow::setViewCategory( const QString &category ) {
- // Find category in menu
- QObjectListIt kidIt( *(m_viewMenuCategories->children()) );
- QObject *obj;
- while ( (obj=kidIt.current()) != 0 ) {
- QAction *currAction = reinterpret_cast<QAction*>(obj);
- if ( currAction->text() == category ) {
- // Category was found, enable it
- currAction->setOn( true );
- return;
- }
- ++kidIt;
+ // Find category in list
+ for ( int i = 0; i < m_catSelect->count(); i++ ) {
+ if ( m_catSelect->text( i ) == category ) {
+ m_catSelect->setCurrentItem( i );
+ slotViewCategory( category );
+ return;
}
+ }
}
@@ -277,54 +272,13 @@ void OPimMainWindow::setViewCategory( const QString &category ) {
void OPimMainWindow::reloadCategories() {
- QString selected;
-
- // Remove old categories from View menu
- if ( m_viewMenuCategories ) {
- QObjectListIt kidIt( *(m_viewMenuCategories->children()) );
- QObject *obj;
- while ( (obj=kidIt.current()) != 0 ) {
- QAction *currAction = reinterpret_cast<QAction*>(obj);
- if ( currAction->isOn() )
- selected = currAction->text();
- ++kidIt;
- delete currAction;
- }
- }
- else {
- m_viewMenuCategories = new QActionGroup( this );
- connect( m_viewMenuCategories, SIGNAL(selected(QAction*)), this, SLOT(slotViewCategory(QAction*)) );
+ QString selected = m_catSelect->currentText();
- selected = tr( "All" );
- }
-
- m_viewMenu->clear();
-
- // Add categories to View menu
- QAction *a = new QAction( tr( "All" ), QString::null, 0, m_viewMenuCategories, QString::null, true );
- a->setWhatsThis( tr( "Click here to view all items." ) );
- a->setOn( selected == tr( "All" ) );
+ // Remove old categories from list
+ m_catSelect->clear();
+ // Add categories to list
Categories cats;
cats.load( categoryFileName() );
- QStringList catList = cats.labels( m_catGroupName );
- for ( QStringList::Iterator it = catList.begin(); it != catList.end(); ++it ) {
- a = new QAction( tr( (*it) ), QString::null, 0, m_viewMenuCategories, QString::null, true );
- a->setWhatsThis( tr( "Click here to view items belonging to %1." ).arg( (*it) ) );
- a->setOn( selected == (*it) );
- }
-
- a = new QAction( tr( "Unfiled" ), QString::null, 0, m_viewMenuCategories, QString::null, true );
- a->setWhatsThis( tr( "Click here to view all unfiled items." ) );
- a->setOn( selected == tr( "Unfiled" ) );
-
- m_viewMenuCategories->addTo( m_viewMenu );
-
- // Add default items to View menu
- m_viewMenu->insertSeparator();
- m_viewMenuGroup->addTo( m_viewMenu );
-
- // Insert application-specific items (if any)
- if ( m_viewMenuAppGroup ) {
- m_viewMenu->insertSeparator();
- m_viewMenuAppGroup->addTo( m_viewMenu );
- }
+ m_catSelect->insertItem( tr( "All" ) );
+ m_catSelect->insertStringList( cats.labels( m_catGroupName ) );
+ m_catSelect->insertItem( tr( "Unfiled" ) );
}
@@ -344,3 +298,3 @@ void OPimMainWindow::initBars( const QString &itemName ) {
QToolBar *toolbar = new QToolBar( this );
-
+
// Create sub-menus
@@ -353,8 +307,7 @@ void OPimMainWindow::initBars( const QString &itemName ) {
- m_viewMenuCategories = 0l;
m_viewMenuAppGroup = 0l;
-
+
// Item menu
m_itemMenuGroup1 = new QActionGroup( this, QString::null, false );
-
+
QAction *a = new QAction( tr( "New" ), Resource::loadPixmap( "new" ),
@@ -375,3 +328,3 @@ void OPimMainWindow::initBars( const QString &itemName ) {
m_itemDuplicateAction->setWhatsThis( tr( "Click here to duplicate the selected item." ) );
-
+
m_itemDeleteAction = new QAction( tr( "Delete" ), Resource::loadPixmap( "trash" ),
@@ -397,7 +350,7 @@ void OPimMainWindow::initBars( const QString &itemName ) {
- a = new QAction( tr( "Find" ), Resource::loadPixmap( "find" ),
- QString::null, 0, m_itemMenuGroup2, 0 );
- connect( a, SIGNAL(activated()), this, SLOT(slotItemFind()) );
- a->setWhatsThis( tr( "Click here to search for an item." ) );
- a->addTo( toolbar );
+// a = new QAction( tr( "Find" ), Resource::loadPixmap( "find" ),
+// QString::null, 0, m_itemMenuGroup2, 0 );
+// connect( a, SIGNAL(activated()), this, SLOT(slotItemFind()) );
+// a->setWhatsThis( tr( "Click here to search for an item." ) );
+// a->addTo( toolbar );
@@ -409,6 +362,6 @@ void OPimMainWindow::initBars( const QString &itemName ) {
m_itemMenuGroup2->addTo( m_itemMenu );
-
+
// View menu
m_viewMenuGroup = new QActionGroup( this, QString::null, false );
-
+
a = new QAction( tr( "Filter" ), QString::null, 0, m_viewMenuGroup, 0 );
@@ -416,3 +369,3 @@ void OPimMainWindow::initBars( const QString &itemName ) {
a->setWhatsThis( tr( "Click here to filter the items displayed." ) );
-
+
a = new QAction( tr( "Filter Settings" ), QString::null, 0, m_viewMenuGroup, 0 );
@@ -421,2 +374,8 @@ void OPimMainWindow::initBars( const QString &itemName ) {
+ // Create view toolbar
+ toolbar = new QToolBar( this );
+ m_catSelect = new QComboBox( toolbar );
+ connect( m_catSelect, SIGNAL(activated(const QString&)), this, SLOT(slotViewCategory(const QString&)) );
+
+ // Do initial load of categories
reloadCategories();
diff --git a/libopie2/opiepim/ui/opimmainwindow.h b/libopie2/opiepim/ui/opimmainwindow.h
index 4aed8b8..ffc7feb 100644
--- a/libopie2/opiepim/ui/opimmainwindow.h
+++ b/libopie2/opiepim/ui/opimmainwindow.h
@@ -40,2 +40,3 @@ class QAction;
class QActionGroup;
+class QComboBox;
class QCopChannel;
@@ -109,3 +110,3 @@ protected slots:
virtual void slotItemBeam() = 0;
- virtual void slotItemFind() = 0;
+ //virtual void slotItemFind() = 0;
virtual void slotConfigure() = 0;
@@ -123,3 +124,3 @@ protected:
QPopupMenu *itemContextMenu();
-
+
void insertItemMenuItems( QActionGroup *items );
@@ -129,3 +130,3 @@ protected:
void reloadCategories();
-
+
private slots:
@@ -135,4 +136,4 @@ private slots:
/** UI-related slots */
- void slotViewCategory( QAction *category );
-
+ void slotViewCategory( const QString &category );
+
private:
@@ -162,3 +163,2 @@ private:
QActionGroup *m_viewMenuGroup; // Action group containing default items in View menu
- QActionGroup *m_viewMenuCategories; // Pointer to action group containing categories in View menu
QAction *m_itemEditAction; // Edit current item action
@@ -167,2 +167,4 @@ private:
+ QComboBox *m_catSelect; // Category selection combo box
+
/* I would love to do this as a template