Added icons. Especially the main-contact table has an icon

to show whether it is a work-, home- number or if it
is a mobile...
The pictures may need improvements due to my incompetence in creating pictures..
Do we have anyone who may paint such stuff ?

7 files changed, 122 insertions, 65 deletions

diff --git a/core/pim/addressbook/TODO b/core/pim/addressbook/TODO
index f62b075..906b462 100644
--- a/core/pim/addressbook/TODO
+++ b/core/pim/addressbook/TODO
@@ -20,3 +20,4 @@ Known Bugs:
 -----------
-- Email-button: A lot of problems.. :(
+- Default Email-button: A lot of problems:
+        If on second tab: The combo chooser is on the top left of the screen ! :(
 - Default Email-Button: Sometimes not hiding the textfields completely
@@ -38,3 +39,2 @@ ContactEditor:
 
-- Personal and Business Web-page is not editable 
 
@@ -117 +117,2 @@ Fixed/Ready:
 - Store last settings of combo-boxes
+- Personal and Business Web-page is not editable 
diff --git a/core/pim/addressbook/abtable.cpp b/core/pim/addressbook/abtable.cpp
index aec390d..55b1ba1 100644
--- a/core/pim/addressbook/abtable.cpp
+++ b/core/pim/addressbook/abtable.cpp
@@ -27,2 +27,3 @@
 #include <qpe/timestring.h>
+#include <qpe/resource.h>
 
@@ -216,13 +217,15 @@ void AbTable::insertIntoTable( const OContact& cnt, int row )
                 //qWarning( "void AbTable::insertIntoTable( const OContact& cnt, %d )", row );
-        QString strName,
-                strContact;
+        QString strName;
+        ContactItem contactItem;
         
         strName = findContactName( cnt );
-        strContact = findContactContact( cnt, row );
+        contactItem = findContactContact( cnt, row );
         
         AbTableItem *ati;
-        ati = new AbTableItem( this, QTableItem::Never, strName, strContact);
+        ati = new AbTableItem( this, QTableItem::Never, strName, contactItem.value );
         contactList.insert( ati, cnt );
         setItem( row, 0, ati );
-        ati = new AbTableItem( this, QTableItem::Never, strContact, strName);
+        ati = new AbTableItem( this, QTableItem::Never, contactItem.value, strName);
+        if ( !contactItem.icon.isNull() )
+                ati->setPixmap( contactItem.icon );
         setItem( row, 1, ati );
@@ -308,4 +311,4 @@ void AbTable::refresh()
         int rows = numRows();
-        QString value;
         AbTableItem *abi;
+        ContactItem contactItem;
 
@@ -314,4 +317,8 @@ void AbTable::refresh()
                 abi = static_cast<AbTableItem*>( item(r, 0) );
-                value = findContactContact( contactList[abi], r );
-                static_cast<AbTableItem*>( item(r, 1) )->setItem( value, abi->text() );
+                contactItem = findContactContact( contactList[abi], r );
+                static_cast<AbTableItem*>( item(r, 1) )->setItem( contactItem.value, abi->text() );
+                if ( !contactItem.icon.isNull() )
+                        static_cast<AbTableItem*>( item(r, 1) )->
+                                setPixmap( contactItem.icon );
+
         }
@@ -620,6 +627,9 @@ void AbTable::rowHeightChanged( int row )
 }
-QString AbTable::findContactContact( const OContact &entry, int /* row */ )
+ContactItem AbTable::findContactContact( const OContact &entry, int /* row */ )
 {
-        QString value;
-        value = "";
+
+        ContactItem item;
+
+        item.value = "";
+
         for ( QValueList<int>::ConstIterator it = intFields.begin();
@@ -630,118 +640,141 @@ QString AbTable::findContactContact( const OContact &entry, int /* row */ )
                 case Qtopia::Title:
-                        value = entry.title();
+                        item.value = entry.title();
                         break;
                 case Qtopia::Suffix:
-                        value = entry.suffix();
+                        item.value = entry.suffix();
                         break;
                 case Qtopia::FileAs:
-                        value = entry.fileAs();
+                        item.value = entry.fileAs();
                         break;
                 case Qtopia::DefaultEmail:
-                        value = entry.defaultEmail();
+                        item.value = entry.defaultEmail();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/email" );
+                        break;
                 case Qtopia::Emails:
-                        value = entry.emails();
+                        item.value = entry.emails();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/email" );
                         break;
                 case Qtopia::HomeStreet:
-                        value = entry.homeStreet();
+                        item.value = entry.homeStreet();
                         break;
                 case Qtopia::HomeCity:
-                        value = entry.homeCity();
+                        item.value = entry.homeCity();
                         break;
                 case Qtopia::HomeState:
-                        value = entry.homeState();
+                        item.value = entry.homeState();
                         break;
                 case Qtopia::HomeZip:
-                        value = entry.homeZip();
+                        item.value = entry.homeZip();
                         break;
                 case Qtopia::HomeCountry:
-                        value = entry.homeCountry();
+                        item.value = entry.homeCountry();
                         break;
                 case Qtopia::HomePhone:
-                        value = entry.homePhone();
+                        item.value = entry.homePhone();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/phonehome" );
                         break;
                 case Qtopia::HomeFax:
-                        value = entry.homeFax();
+                        item.value = entry.homeFax();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/faxhome" );
                         break;
                 case Qtopia::HomeMobile:
-                        value = entry.homeMobile();
+                        item.value = entry.homeMobile();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/mobilehome" );
                         break;
                 case Qtopia::HomeWebPage:
-                        value = entry.homeWebpage();
+                        item.value = entry.homeWebpage();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/webpagehome" );
                         break;
                 case Qtopia::Company:
-                        value = entry.company();
+                        item.value = entry.company();
                         break;
                 case Qtopia::BusinessCity:
-                        value = entry.businessCity();
+                        item.value = entry.businessCity();
                         break;
                 case Qtopia::BusinessStreet:
-                        value = entry.businessStreet();
+                        item.value = entry.businessStreet();
                         break;
                 case Qtopia::BusinessZip:
-                        value = entry.businessZip();
+                        item.value = entry.businessZip();
                         break;
                 case Qtopia::BusinessCountry:
-                        value = entry.businessCountry();
+                        item.value = entry.businessCountry();
                         break;
                 case Qtopia::BusinessWebPage:
-                        value = entry.businessWebpage();
+                        item.value = entry.businessWebpage();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/webpagework" );
                         break;
                 case Qtopia::JobTitle:
-                        value = entry.jobTitle();
+                        item.value = entry.jobTitle();
                         break;
                 case Qtopia::Department:
-                        value = entry.department();
+                        item.value = entry.department();
                         break;
                 case Qtopia::Office:
-                        value = entry.office();
+                        item.value = entry.office();
                         break;
                 case Qtopia::BusinessPhone:
-                        value = entry.businessPhone();
+                        item.value = entry.businessPhone();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/phonework" );
                         break;
                 case Qtopia::BusinessFax:
-                        value = entry.businessFax();
+                        item.value = entry.businessFax();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/faxwork" );
                         break;
                 case Qtopia::BusinessMobile:
-                        value = entry.businessMobile();
+                        item.value = entry.businessMobile();
+                        if ( !item.value.isEmpty() )
+                                item.icon = Resource::loadPixmap( "addressbook/mobilework" );
                         break;
                 case Qtopia::BusinessPager:
-                        value = entry.businessPager();
+                        item.value = entry.businessPager();
                         break;
                 case Qtopia::Profession:
-                        value = entry.profession();
+                        item.value = entry.profession();
                         break;
                 case Qtopia::Assistant:
-                        value = entry.assistant();
+                        item.value = entry.assistant();
                         break;
                 case Qtopia::Manager:
-                        value = entry.manager();
+                        item.value = entry.manager();
                         break;
                 case Qtopia::Spouse:
-                        value = entry.spouse();
+                        item.value = entry.spouse();
                         break;
                 case Qtopia::Gender:
-                        value = entry.gender();
+                        item.value = entry.gender();
                         break;
                 case Qtopia::Birthday:
-                        if ( ! entry.birthday().isNull() )
-                                value = TimeString::numberDateString( entry.birthday() );
+                        if ( ! entry.birthday().isNull() ){
+                                item.value = TimeString::numberDateString( entry.birthday() );
+                        }
                         break;
                 case Qtopia::Anniversary:
-                        if ( ! entry.anniversary().isNull() )
-                                value = TimeString::numberDateString( entry.anniversary() );
+                        if ( ! entry.anniversary().isNull() ){
+                                item.value = TimeString::numberDateString( entry.anniversary() );
+                        }
                         break;
                 case Qtopia::Nickname:
-                        value = entry.nickname();
+                        item.value = entry.nickname();
                         break;
                 case Qtopia::Children:
-                        value = entry.children();
+                        item.value = entry.children();
                         break;
                 case Qtopia::Notes:
-                        value = entry.notes();
+                        item.value = entry.notes();
                         break;
                 }
-                if ( !value.isEmpty() )
+                if ( !item.value.isEmpty() )
                         break;
         }
-        return value;
+        return item;
 }
diff --git a/core/pim/addressbook/abtable.h b/core/pim/addressbook/abtable.h
index 9825665..092e86f 100644
--- a/core/pim/addressbook/abtable.h
+++ b/core/pim/addressbook/abtable.h
@@ -32,2 +32,3 @@
 #include <qcombobox.h>
+#include <qpixmap.h> 
 
@@ -48,2 +49,11 @@ private:
 
+// This is a simple container, storing all contact
+// information
+class ContactItem
+{
+ public:
+        QPixmap icon;
+        QString value;
+};
+
 class AbPickItem : public QTableItem
@@ -117,3 +127,3 @@ private:
     void insertIntoTable( const OContact &cnt, int row );
-    QString findContactContact( const OContact &entry, int row );
+    ContactItem findContactContact( const OContact &entry, int row );
     void fitColumns();
diff --git a/core/pim/addressbook/addressbook.cpp b/core/pim/addressbook/addressbook.cpp
index ad8315d..881b839 100644
--- a/core/pim/addressbook/addressbook.cpp
+++ b/core/pim/addressbook/addressbook.cpp
@@ -203,3 +203,4 @@ AddressbookWindow::AddressbookWindow( QWidget *parent, const char *name,
         
-        a = new QAction( tr("My Personal Details"), QString::null, 0, 0, 0, TRUE );
+        a = new QAction( tr("My Personal Details"), Resource::loadPixmap( "addressbook/identity" ), 
+                         QString::null, 0, this, 0 );
         actionPersonal = a;
@@ -216,3 +217,3 @@ AddressbookWindow::AddressbookWindow( QWidget *parent, const char *name,
 #endif
-        a = new QAction( tr( "Config" ), Resource::loadPixmap( "today/config" ), QString::null,
+        a = new QAction( tr( "Config" ), Resource::loadPixmap( "addressbook/configure" ), QString::null,
                          0, this, 0 );
diff --git a/core/pim/addressbook/configdlg.cpp b/core/pim/addressbook/configdlg.cpp
index afba688..f5c0c5b 100644
--- a/core/pim/addressbook/configdlg.cpp
+++ b/core/pim/addressbook/configdlg.cpp
@@ -2,2 +2,3 @@
 #include "ocontactfields.h"
+
 #include <qcheckbox.h>
@@ -6,2 +7,5 @@
 #include <qpushbutton.h>
+#include <qiconset.h> 
+
+#include <qpe/resource.h>
 
@@ -19,2 +23,9 @@ ConfigDlg::ConfigDlg( QWidget *parent, const char *name):
 
+        // Set Pics to Buttons and Tabs
+        m_upButton->setIconSet( QIconSet( Resource::loadPixmap( "addressbook/up" ) ) );
+        m_downButton->setIconSet( QIconSet( Resource::loadPixmap( "addressbook/down" ) ) );
+        m_addButton->setIconSet( QIconSet( Resource::loadPixmap( "addressbook/add" ) ) );
+        m_removeButton->setIconSet( QIconSet( Resource::loadPixmap( "addressbook/sub" ) ) );
+        
+
         // Get the translation maps between Field ID and translated strings
diff --git a/core/pim/addressbook/contacteditor.cpp b/core/pim/addressbook/contacteditor.cpp
index 9efb8c0..97573af 100644
--- a/core/pim/addressbook/contacteditor.cpp
+++ b/core/pim/addressbook/contacteditor.cpp
@@ -550,6 +550,5 @@ void ContactEditor::init() {
         QStringList::ConstIterator it = slDynamicEntries.begin();
-        QStringList::ConstIterator trit = trlDynamicEntries.begin();
         QMap<QString, int> mapStrToID = OContactFields::untrFieldsToId();
         QMap<int, QString> mapIdToStr = OContactFields::idToTrFields();
-        for (i = counter; it != slDynamicEntries.end(); i++, ++it, ++trit) {
+        for (i = counter; it != slDynamicEntries.end(); i++, ++it ) {
           
diff --git a/core/pim/addressbook/ocontactfields.cpp b/core/pim/addressbook/ocontactfields.cpp
index 18b68c4..ffb88e8 100644
--- a/core/pim/addressbook/ocontactfields.cpp
+++ b/core/pim/addressbook/ocontactfields.cpp
@@ -74,2 +74,4 @@ QStringList OContactFields::trphonefields( bool sorted )
     list.append( mapIdToStr[Qtopia::BusinessMobile] ); 
+    list.append( mapIdToStr[Qtopia::BusinessPager] );
+    list.append( mapIdToStr[Qtopia::BusinessWebPage] );
 
@@ -81,2 +83,4 @@ QStringList OContactFields::trphonefields( bool sorted )
     list.append( mapIdToStr[Qtopia::HomeMobile] );
+    // list.append( mapIdToStr[Qtopia::HomePager] );
+    list.append( mapIdToStr[Qtopia::HomeWebPage] );
 
@@ -100,2 +104,4 @@ QStringList OContactFields::untrphonefields( bool sorted )
     list.append( mapIdToStr[ Qtopia::BusinessMobile ] );
+    list.append( mapIdToStr[ Qtopia::BusinessPager ] );
+    list.append( mapIdToStr[ Qtopia::BusinessWebPage ] );
 
@@ -107,2 +113,4 @@ QStringList OContactFields::untrphonefields( bool sorted )
     list.append( mapIdToStr[ Qtopia::HomeMobile ] );
+    //list.append( mapIdToStr[Qtopia::HomePager] );
+    list.append( mapIdToStr[Qtopia::HomeWebPage] );
 
@@ -141,4 +149,2 @@ QStringList OContactFields::trfields( bool sorted )
     list.append( mapIdToStr[Qtopia::BusinessCountry] );
-    list.append( mapIdToStr[Qtopia::BusinessPager] );
-    list.append( mapIdToStr[Qtopia::BusinessWebPage] );
 
@@ -149,3 +155,2 @@ QStringList OContactFields::trfields( bool sorted )
     list.append( mapIdToStr[Qtopia::HomeCountry] );
-    list.append( mapIdToStr[Qtopia::HomeWebPage] );
 
@@ -188,4 +193,2 @@ QStringList OContactFields::untrfields( bool sorted )
     list.append( mapIdToStr[ Qtopia::BusinessCountry ] );
-    list.append( mapIdToStr[ Qtopia::BusinessPager ] );
-    list.append( mapIdToStr[ Qtopia::BusinessWebPage ] );
 
@@ -196,3 +199,2 @@ QStringList OContactFields::untrfields( bool sorted )
     list.append( mapIdToStr[ Qtopia::HomeCountry ] );
-    list.append( mapIdToStr[ Qtopia::HomeWebPage] );